Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
From:   Biju Das <biju.das.jz@bp.renesas.com>
To:     Alexandre Belloni <alexandre.belloni@bootlin.com>
CC:     Thomas Gleixner <tglx@linutronix.de>,
        Alessandro Zummo <a.zummo@towertech.it>,
        John Stultz <jstultz@google.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Biju Das <biju.das.au@gmail.com>,
        "linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-renesas-soc@vger.kernel.org" 
        <linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH] alarmtimer: Fix rebind failure
Thread-Topic: [PATCH] alarmtimer: Fix rebind failure
Thread-Index: AQHZ67nxDPIpzSJRaUGrxRMZix2AJrAjtMiAgAAA3DA=
Date:   Wed, 20 Sep 2023 13:31:10 +0000
Message-ID: <OS0PR01MB592280D33C80AACADEB5958886F9A@OS0PR01MB5922.jpnprd01.prod.outlook.com>
References: <20230920115935.144391-1-biju.das.jz@bp.renesas.com>
 <2023092013265355e7a02a@mail.local>
In-Reply-To: <2023092013265355e7a02a@mail.local>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?815g9Z0TpyVuS8cl4Yd42l5B/R59flqZX/Kobn8sQawkHvyilqLU5FK4VCjK?=
 =?us-ascii?Q?FwHH9xlV1mDMnBzVkyChKYOCHwMMrH8Y8LOKj20E9iy6/TOci/mSVYKbscLF?=
 =?us-ascii?Q?9O/3PCMVEhz7ZlERMtfkZP/AJ+4+8xnG4pDeAHtK+KiSC4n/l9ZS1/yiGOHK?=
 =?us-ascii?Q?0VeTVZRW8oSIFjXA2rT7FJDyCQ7/CJZykUJ4FVKJSqLpiveXpiRfdR3XO4PM?=
 =?us-ascii?Q?LtakSZEcp0YI7mOzPWrj7h0hh803KRKHpFUIix9QgS74XcsDYD2kYdcW0dJz?=
 =?us-ascii?Q?wGw5bUEXHyB5/NpyF+wIvIMHlWRtka0dB2QwVe+dorNgdN0OUAOfrP+YU8v3?=
 =?us-ascii?Q?ChyR53mMCCJ4PvhjswuevZKYHqmzWGPkR49M0EWQsWr5KmIiL400DSYZmon6?=
 =?us-ascii?Q?q8VCmxUCxnHGpAm9smPzIuHtDE31+14RZBeTiSaVRCp8kS8LZWVb93lG2Ctx?=
 =?us-ascii?Q?NANy3lsn8ExQssqiuMLcu4RLWCX6tFbGCsbBGjzm8ZyeuXNvnsnkcuHrSOK3?=
 =?us-ascii?Q?ugTy+SxHvaxvGLGIDXRt5QbuBt+gllcvWjpABpf2mccr+fW/jgMuUBqt2cXr?=
 =?us-ascii?Q?Koz9p02K+0JlR/SyhdnXHxqe2gZ7C9xoaY9vVCcs2zqWuhihqpeztXCG/BCn?=
 =?us-ascii?Q?WlIWm4dYSVddr23WMV1e+ypn69Rsjktvj2TU6fPnfaY2CAu/ocLeQTDtPXAH?=
 =?us-ascii?Q?ZafczXuE9Y3M/6HFC/Fs5Rka/gxpmbEgD8CqkLHxWM8jBJli7uXV4m83CU7i?=
 =?us-ascii?Q?uMwq1V+xjaPNgcEa01Tx/Xrm0+sPvPooyEbKUEBRi65bRF0zJelkK9fVTYk8?=
 =?us-ascii?Q?aqxprY7XwrAzlqbT0PDhKAqEkTE/mStup50D1+2djf9FRhNTuCHpChv95QXK?=
 =?us-ascii?Q?tUQCnNxU9zbkI/gqo9HIftAWCHgYlFVXui62DSH6yfE1FF1LVradka8XKMzL?=
 =?us-ascii?Q?oRAv35MXwI3QNkqojppFNdWeaHdAp2sUIv4vdoR1osz6FYZR/PBR2pV0QKKo?=
 =?us-ascii?Q?5I7jRsr/nxebRmesqDWhRMJgIvr/9TxqD3LNQbOP6LCXdYZG1rzeqWYE1De5?=
 =?us-ascii?Q?YY9RpfWRLh9WJlzGgxQ4qHycPmR6KO8Lb9+zGSZ/3P2UpkOHLc/D2fI4DAcz?=
 =?us-ascii?Q?kS9o1XM+FOCSm+xHxUCm96L5Foecc1ZoIlQM8Tg8w28LgKSWN0wulbnAN81h?=
 =?us-ascii?Q?qDpV2kM5QW6tbuLX0NYV0U1zkE2x2mH7ZXCrlQ6/WTpIPd9yNpBeLEi+5ZAR?=
 =?us-ascii?Q?OmT+XkZHQ3tsp6vLigJoDdS0ZykD0nDqgis3oGAleAMkOa8pP/XJIa/omv21?=
 =?us-ascii?Q?8+Q1UWaV93T5YAPTAgO+cXJMq9Jj58Nw4l6xuOH1b4IJTczzodd1AWgy6ZFq?=
 =?us-ascii?Q?aZLF1fzyB4LFKxQmkXJDBQRcn6FGuqm3Wh9Euid9KrmkFGTXY0UoSEwpHlkk?=
 =?us-ascii?Q?OfFUS4gRp6xZoT4XcvR3cTzcay1KH8STNf0/wffnDVGpkALBuRQLLYi+OrrI?=
 =?us-ascii?Q?BXr1q4EuwnlmwRbO7A85oljF/7GVCPDajC0ssyAx6oBlLdj29UNn2mBWjGRN?=
 =?us-ascii?Q?01avUHSk0Js9FWseZhQ=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: bp.renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: OS0PR01MB5922.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 42a312fb-73d4-433c-f21c-08dbb9ddda78
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Sep 2023 13:31:10.6811
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: BUifPHQud3o4+uVgr9mxnlHl6YhpcR8D8PSD2/PUkIKSz0AQ+iXe8KPZnrhaMDjv6t8d6KkMrXZY+pOQikx+/mVyCH769s4WlrNhyyMYZy4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWPR01MB10115
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 20 Sep 2023 06:31:24 -0700 (PDT)

Hi Alexandre Belloni,

> Subject: Re: [PATCH] alarmtimer: Fix rebind failure
>=20
> On 20/09/2023 12:59:35+0100, Biju Das wrote:
> > The resources allocated in alarmtimer_rtc_add_device() are not freed
> > leading to re-bind failure for the endpoint driver. Fix this issue by
> > adding alarmtimer_rtc_remove_device().
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > ---
> > This issue is found while adding irq support for built in RTC found on
> > Renesas PMIC RAA215300 device. This issue should present on all RTC
> > drivers which calls device_init_wakeup() in probe().
> > ---
> >  kernel/time/alarmtimer.c | 20 ++++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> >
> > diff --git a/kernel/time/alarmtimer.c b/kernel/time/alarmtimer.c index
> > 8d9f13d847f0..592668136bb5 100644
> > --- a/kernel/time/alarmtimer.c
> > +++ b/kernel/time/alarmtimer.c
> > @@ -61,6 +61,7 @@ static DEFINE_SPINLOCK(freezer_delta_lock);
> >  /* rtc timer and device for setting alarm wakeups at suspend */
> >  static struct rtc_timer		rtctimer;
> >  static struct rtc_device	*rtcdev;
> > +static struct platform_device	*rtc_pdev;
>=20
> This is the alarmtimer pdev, not the RTC one, right?

Yes, it is alarmtimer pdev.

Cheers,
Biju

>=20
> >  static DEFINE_SPINLOCK(rtcdev_lock);
> >
> >  /**
> > @@ -109,6 +110,7 @@ static int alarmtimer_rtc_add_device(struct device
> *dev)
> >  		}
> >
> >  		rtcdev =3D rtc;
> > +		rtc_pdev =3D pdev;
> >  		/* hold a reference so it doesn't go away */
> >  		get_device(dev);
> >  		pdev =3D NULL;
> > @@ -123,6 +125,23 @@ static int alarmtimer_rtc_add_device(struct device
> *dev)
> >  	return ret;
> >  }
> >
> > +static void alarmtimer_rtc_remove_device(struct device *dev) {
> > +	struct rtc_device *rtc =3D to_rtc_device(dev);
> > +
> > +	if (rtc_pdev) {
> > +		module_put(rtc->owner);
> > +		if (device_may_wakeup(rtc->dev.parent))
> > +			device_init_wakeup(&rtc_pdev->dev, false);
> > +
> > +		platform_device_unregister(rtc_pdev);
> > +		put_device(dev);
> > +	}
> > +
> > +	rtcdev =3D NULL;
> > +	rtc_pdev =3D NULL;
> > +}
> > +
> >  static inline void alarmtimer_rtc_timer_init(void)  {
> >  	rtc_timer_init(&rtctimer, NULL, NULL); @@ -130,6 +149,7 @@ static
> > inline void alarmtimer_rtc_timer_init(void)
> >
> >  static struct class_interface alarmtimer_rtc_interface =3D {
> >  	.add_dev =3D &alarmtimer_rtc_add_device,
> > +	.remove_dev =3D &alarmtimer_rtc_remove_device,
> >  };
> >
> >  static int alarmtimer_rtc_interface_setup(void)
> > --
> > 2.25.1
> >
>=20
> --
>=20