Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
From:   "Liu, Yi L" <yi.l.liu@intel.com>
To:     Jason Gunthorpe <jgg@nvidia.com>,
        Baolu Lu <baolu.lu@linux.intel.com>
CC:     "joro@8bytes.org" <joro@8bytes.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "Tian, Kevin" <kevin.tian@intel.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "cohuck@redhat.com" <cohuck@redhat.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
        "yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
        "peterx@redhat.com" <peterx@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
        "Martins, Joao" <joao.m.martins@oracle.com>
Subject: RE: [PATCH 6/6] iommu/vt-d: Add domain_alloc_user op
Thread-Topic: [PATCH 6/6] iommu/vt-d: Add domain_alloc_user op
Thread-Index: AQHZ6ttUqZRrjysqnUa2j9no88GC0rAjMOqAgAB/mQCAAABTMA==
Date:   Wed, 20 Sep 2023 13:10:04 +0000
Message-ID: <DS0PR11MB7529609BC4574A17ECE469A2C3F9A@DS0PR11MB7529.namprd11.prod.outlook.com>
References: <20230919092523.39286-1-yi.l.liu@intel.com>
 <20230919092523.39286-7-yi.l.liu@intel.com>
 <7aa8fd9e-e43d-db68-bdb6-fe4f891255ca@linux.intel.com>
 <20230920130522.GV13733@nvidia.com>
In-Reply-To: <20230920130522.GV13733@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6NtGT8FLt16tv81hUNUEPY6Rk0BNxfbsvWhMPbof2wtGwymybfSS342wJZDE?=
 =?us-ascii?Q?xYUkWhLOxC6/PbXAhpkl432jjnoLc4sfvm/v9TgxwyC6oqHRdAmhSpY9Ijci?=
 =?us-ascii?Q?tinqJQkxmbwtp7wF/QwG0Ij8O+1+9eiNm+bwM6snosXByW3c4vy9q0EdAYfL?=
 =?us-ascii?Q?k4I+RfHOZhts7eNIA5awy5J+cROjzHrgFtu3YGJnZaZA6JK7OHH5O49aWgOs?=
 =?us-ascii?Q?e+VOgoJPLc1YPBrG6PJhAaM8CieuOYe14feegDtuGVxUoYwY469ND7aEdqmk?=
 =?us-ascii?Q?rhcw7BWK17JINQjLRkU7xvmNWAdOUdsmIDKP2TA9YcemFIoJ3ZqC6moMSToh?=
 =?us-ascii?Q?txWvOstM3LgMmENS+PvgLjCfFXX+FJS6GCfQ12TFU7EmMKW5MDq1SbSvIvJc?=
 =?us-ascii?Q?nzmcTIkLZ6FdqK8JRa0TsVBv/hHWiC8zzno7mqTHeCu259pKwa5K8KbLeqSy?=
 =?us-ascii?Q?i2kyP4EZS9LHAzVg4NVEVb+OBdhXNoTx5RH4kpzoqCzEQGaWSPfwEh+AL42g?=
 =?us-ascii?Q?B49CmzglbtrjYEmf5saIaAOxiYLX9iUTVCr0IvCL0jtvPLXDP8hN5SxdDEVc?=
 =?us-ascii?Q?Cr1/0EZ4rys827aQoUMmKG5XTeRCtRfglbqcWyudpV+UHXEXOueTXIDkn4tM?=
 =?us-ascii?Q?4N3Nc/dOSrQANS51rOcy1kA+0Hnp9Y0RGzm089NtLtH95HSgC0eO/LsP/vM/?=
 =?us-ascii?Q?ZS2QE2uU1KN2GoqxQS3cgp8xxA/4P55RRu2LohedsJrLOJCF0LuMR6a0Sv7r?=
 =?us-ascii?Q?KpBh+a0EPxcbstrRgw2IqSZ6CJAE/Af+kmR/NRepHIDMSS0DmJSEbvdfzUs5?=
 =?us-ascii?Q?lHSeqSfgABY3pyNCOkD6Rt4Ok2cmAXkCsn0E5sWyg2Y/dvSWOfZ1Ah9njS3M?=
 =?us-ascii?Q?Ph9TohkBvI2dUmFcfCE3IVXwwnYkrDoTjmwUrXxZi/zqtOXbfvPA0dWXR0OY?=
 =?us-ascii?Q?iv+n8pyplaeQ43I5xd5Ltug1640M6LdJcqKKpNvTuFCaUCqk/shDLaLN2vaU?=
 =?us-ascii?Q?QOF/LQn9xevp7kOgcByIpxVTOutbQuXxg2Cq49K7+Wc7Jg5Qqf6KMRPf6SDN?=
 =?us-ascii?Q?lyvmJ79SyIAjEO9BmGYGxXPCnfhX8csrIxfXrTI/hwAXx7Gz39bTRTF2Jbk1?=
 =?us-ascii?Q?EdYR3ZPm/7W2QK8DUZllpp9T+74/eLuh22dXMO3AdJY1ndLFg70P2w2L25tC?=
 =?us-ascii?Q?GG4YHZ/SsvYjom2S891IwwNauQPbwCFzB0In7+KNIpAqxyJU69Pzm+vOBtbN?=
 =?us-ascii?Q?SQ3z546XIlzAERMSO8R4EqqlaEfuBpRuEmUivYVoArxX+vug8J6OAwVH50Hi?=
 =?us-ascii?Q?W2h5egQ6fuqyvHZSbboyve8dEqE1U4q4oX2W5Y6gwXHcSU/Y3yAzfwMYb7DN?=
 =?us-ascii?Q?FKJi1bnv0UoLHWXckyoZwbXnP5Thfqs8qaOpgdS1tDFYpBsD70LdgqfwxGCS?=
 =?us-ascii?Q?TTDycxQkf/7kfKnaQWMP3WiHvZ5djTva0miWe0jl74qIEz62kK03SVVYNGg/?=
 =?us-ascii?Q?I20HGEgyOLudL2aIwv7LbbSrWfwqF7fLOLXhiUw0Q7HWvjHHtW13n7SP6SfJ?=
 =?us-ascii?Q?yPnbtSup9lsCWweJeFY=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7529.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: feadcf91-0d59-4ace-8bd5-08dbb9dae7a5
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Sep 2023 13:10:04.3268
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 8QuvPV1ML5f//QfRDECuXYAJIl/VSFZkL0pXx4v6CLaEX57gMbQb1PEFzBDwoi8GoXcdsGrYTFqAN8TJlxeWaA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4806
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 20 Sep 2023 06:10:17 -0700 (PDT)

> From: Jason Gunthorpe <jgg@nvidia.com>
> Sent: Wednesday, September 20, 2023 9:05 PM
>=20
> On Wed, Sep 20, 2023 at 01:28:41PM +0800, Baolu Lu wrote:
> > >
> > > diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.=
c
> > > index 5db283c17e0d..491bcde1ff96 100644
> > > --- a/drivers/iommu/intel/iommu.c
> > > +++ b/drivers/iommu/intel/iommu.c
> > > @@ -4074,6 +4074,25 @@ static struct iommu_domain
> *intel_iommu_domain_alloc(unsigned type)
> > >   	return NULL;
> > >   }
> > > +static struct iommu_domain *
> > > +intel_iommu_domain_alloc_user(struct device *dev, u32 flags)
> > > +{
> > > +	struct iommu_domain *domain;
> > > +	struct intel_iommu *iommu;
> > > +
> > > +	iommu =3D device_to_iommu(dev, NULL, NULL);
> > > +	if (!iommu)
> > > +		return ERR_PTR(-ENODEV);
> > > +
> > > +	if ((flags & IOMMU_HWPT_ALLOC_NEST_PARENT) && !ecap_nest(iommu-
> >ecap))
> > > +		return ERR_PTR(-EOPNOTSUPP);
>=20
> There is a check missing for supported flags
>=20
>  if (flags & (~IOMMU_HWPT_ALLOC_NEST_PARENT))
> 	return ERR_PTR(-EOPNOTSUPP);

Well, the iommufd has such check. But I also noticed your another
reply to Weijiang. So your preference is to do the flags validation
in iommu driver instead of iommufd. Isn't it?

> > > +
> > > +	domain =3D iommu_domain_alloc(dev->bus);
> >
> > No need to bounce between core and driver. Just,
> >
> > 	intel_iommu_domain_alloc(IOMMU_DOMAIN_UNMANAGED);
> >
> > and fully initialize it before return.
>=20
> If you are going to do that then intel_iommu_domain_alloc() should
> fully initialize the domain, not here.

I've also considered what Baolu described, but it requires to do some
extra initialization which is duplicated with iommu_domain_alloc().
So I chose this simple way.

Regards,
Yi Liu