Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp1430038rdb; Wed, 20 Sep 2023 08:55:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEwmOEZNmsX7hCNlRDX2mx6cKt0oKBuG0Gnd/SRTMDuIEyxT/1nJdzq0MqYR3tqR3O/30GZ X-Received: by 2002:a17:90a:3006:b0:268:5575:93d9 with SMTP id g6-20020a17090a300600b00268557593d9mr2982228pjb.10.1695225335958; Wed, 20 Sep 2023 08:55:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695225335; cv=none; d=google.com; s=arc-20160816; b=RW9+8Y20UNpD/6e5Qeo/hdHsUYblyjniX9vBxd9ujOSZ/zeOxFXUbzKSscVlwBl3K/ JHbj/B0rF33oNiBtTlaDLHbNrdcsPhNqbhU+rWPaWnMY6zXeINHFr4FbZl5+SBKAC67d Sqp19YXGtkd4TIlBiLjCYY9s2FH/XaP2TL5+1eBmwfMUstxs5WDEX4HaQFhWa8A9Wk6v QHZMg5hJgrDhtgqqrAOBJ2J/5nksCT9f2yB2yz1qltl2v2/8n2pCcaSe+OOvDCvI8viQ LgSnsfH85RcHYq4fzkE1CFAHMvGBd1Hj6xNCRV9GcQUj2AWHXN6o+kmMvPKRnVLV5Wnb Qqog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ZMbp5HTqzRJSg8VsgOW6uuoByeuTCjNSPL9JeNv0S6o=; fh=JCH4opCpOsgrOwquCv+DFBaV8ZiyEjcwnR374CFOO2k=; b=WcjA5jWO+mRX2HRskjbeEsb8H9ouN5EYlY20g62J5aC0tC/KJw7fDzcJTt3B9IzebP +IMm2Ns4zJenwvIlMRf9ncj5X8ehBrrq6QRlgyhs6ciawAMeJnkeF9FUT6DdTHJrAXKF LEALGq02cJxRNd3SqtqN5BDwjx0ATv7jxWadw/SL5MGYupMi7f/NkTDZyFK56HFQzjBV RjGgwIDLRsIv5QTUJqxXguJrueUIRqALk0hgv1UCQchUnVr/SkAkxhBPVnU0rFXt9cwQ QZ12tTK+uqnLqa9lEebHxl89n/ufk3hl4ytBeqJZqEMdB3G8Q43ocJbHX5uu50d9bRXt JdyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=alien8 header.b=UTsmLHl2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id u15-20020a17090a6a8f00b0026b0c3f1506si1755413pjj.155.2023.09.20.08.55.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Sep 2023 08:55:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=alien8 header.b=UTsmLHl2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 052F281C46FC; Wed, 20 Sep 2023 06:24:21 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234788AbjITNYT (ORCPT + 99 others); Wed, 20 Sep 2023 09:24:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233952AbjITNYS (ORCPT ); Wed, 20 Sep 2023 09:24:18 -0400 Received: from mail.alien8.de (mail.alien8.de [IPv6:2a01:4f9:3051:3f93::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26A039E for ; Wed, 20 Sep 2023 06:24:11 -0700 (PDT) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id C76E640E014B; Wed, 20 Sep 2023 13:24:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Authentication-Results: mail.alien8.de (amavisd-new); dkim=pass (4096-bit key) header.d=alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id GHQ-TslXAbQ5; Wed, 20 Sep 2023 13:24:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1695216245; bh=ZMbp5HTqzRJSg8VsgOW6uuoByeuTCjNSPL9JeNv0S6o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UTsmLHl2DtuxJSHyDbZmTJPz0AY1KEpWsPP1mk+/9JpdDf8IIN6xBpLHFRlsuv52g Ev3aM1pWWtuCxBdBniFMjw9TJAVd98eZOfbsW9gYWtsEaVBa3g+CPeobzpCRgJMVOF N6rq4MEf5MfOAuE9ooWuOeHeV00jD6AFqENBrCRc04JW9qEZ2dkWSS2nNw0Ju8EUtj yC2LKvRUw9m7+46fqEYweYzpMuVX8RBkL2QsjINodrAhRGrubpFgG0+R5EtnqGfA2m 0d8/wAo9HpEzrS+3wiFLxY1tgFShdy9Qazvim05PKTRn9u7u4QIU3aEm4pWwVvmNwR Yz9OSvyi5XSE2tALrxmhIvOhth0yHwJELx5/K1CJzxygu6hJRIZVTEpeDrDaVp37wr 29PORG+0dxSuOlk2Zi6K/Eu6ijJht3Jeo3osovrus6uST080FTAWl21oIlkblwKbGm YZ6zQaATvM8tUa+Imw8rIy562OopWjb38w4smXge3YnVYwpgGJg/tLlRnTlQflwZgZ Id4F7RE8R2btNBqh/j1WSQS85gKDA971D2ul0s3NZ6oM4eDSVKM44/05cSgeTQmJtG YBLL9MXqMlsbLjiq6cNMqpy10mpIP1lNi28HQh769RAwZmy8nWz1RXZCsgnZJ+P8yb WdjpXDDej7ffqzyjjNQQSbXE= Received: from zn.tnic (pd953036a.dip0.t-ipconnect.de [217.83.3.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 7E78740E01A1; Wed, 20 Sep 2023 13:23:48 +0000 (UTC) Date: Wed, 20 Sep 2023 15:23:43 +0200 From: Borislav Petkov To: Huibin Shi Cc: Hans de Goede , Henry Shi , "hbshi69@hotmail.com" , "tglx@linutronix.de" , "mingo@redhat.com" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , "markgross@kernel.org" , "jdelvare@suse.com" , "linux@roeck-us.net" , "linux-kernel@vger.kernel.org" , "platform-driver-x86@vger.kernel.org" , "linux-hwmon@vger.kernel.org" , "hb_shi2003@yahoo.com" , Wen Wang Subject: Re: [PATCH v7] platform/x86: Add Silicom Platform Driver Message-ID: <20230920132343.GEZQryX/gCegY09+Qp@fat_crate.local> References: <20230919211650.25325-1-henryshi2018@gmail.com> <69a6279d-a191-e294-3db2-8041c4208783@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 20 Sep 2023 06:24:22 -0700 (PDT) On Wed, Sep 20, 2023 at 11:33:59AM +0000, Huibin Shi wrote: > Sorry for missing your inline code comments. I will address them and > send out new patch soon. Don't send soon. Take your time, give people a week to look at your patch and then send a new version. Go over the replies so that you don't miss review comments. Test it. Make sure you've designed it right. This is not a contest about who sends a new revision as quickly as possible. In the meantime, read this file: From: Documentation/process/submitting-patches.rst "Don't get discouraged - or impatient ------------------------------------ After you have submitted your change, be patient and wait. Reviewers are busy people and may not get to your patch right away. Once upon a time, patches used to disappear into the void without comment, but the development process works more smoothly than that now. You should receive comments within a week or so; if that does not happen, make sure that you have sent your patches to the right place. Wait for a minimum of one week before resubmitting or pinging reviewers - possibly longer during busy times like merge windows." Thanks. P.S. Do not top-post but put your reply text *under* the quoted text you're replying to. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette