Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp1495400rdb; Wed, 20 Sep 2023 10:38:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGq2TtLt5hhoJAjepWCeWoqt7TM0i1TLqrMpXJiFa5pmtqFsZI4RhSmSTYTfyfJ2bi3vly0 X-Received: by 2002:a17:902:a3c7:b0:1c4:50f0:c4e1 with SMTP id q7-20020a170902a3c700b001c450f0c4e1mr2600282plb.38.1695231484346; Wed, 20 Sep 2023 10:38:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695231484; cv=none; d=google.com; s=arc-20160816; b=weLlauahL1/RbK0M1Jm1a97ZHfpdGDAX4lULtlzxGWhWN6dX1TlBnAfsA0xhl8tbK/ iXQy139Xc80g2Zt23XrkRvYUa5aBQTW7PYDiuM5OI80HKBNdCREYj8Pq2YEs+HyuNMV9 u4HxGVNQ5yam72PIQQSk+AxdoUhScFLhX/9gW1byru9EKfEcmTR6VAFbafns+MB8XiLb 65LU7R2dny3uMMmuNuAcKFmQMlZza6dc5kAjpslC89k6qov2R4E1vZ+XJduLSOPz3oOh 5oLGb56PcGK2cHLdCxZoUeni2WxBweJEMelfSLT330cxpVucOrTUQKvZayfo1kgydIt+ P8Aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=o25gjUHbl611jCqet+ZUhfwKD5OSmvMAvsYQvfR7RMk=; fh=UQ0Whax078GRV4pCkO6jdRlVIo9hSnkV3Otdd6YySmc=; b=Dhy/5WQql6fZDOPa/pYAeFJkroW/IGCDGPTotDfAxXncul2eIuDnqINNDv3MveWWbF oZbESXXldX9whisJATmuayl23jdFLgS/zAhONuzQhC0/0uBnB14aZsryCTro4JuuZdcP v2hkejolLCaP5I/BXAw2uJr44llx/BRRYkV/MakRsVGnKaRqV9kOPxuZ6EafAArqUueC cN7gFWK74EDWaRcXaLYFW8b6ZofKr2mgFdjWHd3ZS+tW/ayak2jsrJIapM9kUlyay9vB 1KcqtPIZoZnRfMvUAYHeJb7CYbYO5PaQ5yA1VkJa4Xvht8/BF9XztujvIRQ+NKP+YLS8 pizw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pCQ2j0lI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id u16-20020a17090341d000b001c568490749si6161353ple.502.2023.09.20.10.38.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Sep 2023 10:38:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pCQ2j0lI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 1C62082224C7; Wed, 20 Sep 2023 10:11:12 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235686AbjITRKu (ORCPT + 99 others); Wed, 20 Sep 2023 13:10:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235516AbjITRKc (ORCPT ); Wed, 20 Sep 2023 13:10:32 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4101DA3; Wed, 20 Sep 2023 10:10:22 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59508C4339A; Wed, 20 Sep 2023 17:10:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695229822; bh=yi/QaKUzu89G9FWmGFRchfsQQ/b6YUKl1lKijsBirj4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pCQ2j0lIK/SfCLhJx5NnqapK9sHxDjO9QgCbQhyfVH2W2lEB8+jy4jUtiOY3DonSY UPmLszfxgEvSVNV2OGjaiSWvuatayoV+NsncV/6bXcGnd+k9gs/vxmExPI7oudUnkJ IUGiw7qssgqP0pLvI53w8/8vTMp3HRkeiWKrvXdTTSjmGEGk6iI1nErkTRgjFvRPJS UJP1rrK4p2iGlw/ZhrF9O9/l/cnrmQLixzFrBF3FIl37yxDXoH+629mBd/10A5XzwC yHBmZVfISC0eIMxDS+8EhrlGLCzxRD7qrnne44yysWiaaurR+nhA3VXw9hCdBU0+0L CXKaDyLZI5JXQ== From: Bjorn Andersson To: agross@kernel.org, konrad.dybcio@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, mturquette@linaro.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Devi Priya Cc: quic_saahtoma@quicinc.com Subject: Re: [PATCH V2] clk: qcom: clk-rcg2: Fix clock rate overflow for high parent frequencies Date: Wed, 20 Sep 2023 10:14:08 -0700 Message-ID: <169523004952.2665018.4505782565131153297.b4-ty@kernel.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20230901073640.4973-1-quic_devipriy@quicinc.com> References: <20230901073640.4973-1-quic_devipriy@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 20 Sep 2023 10:11:12 -0700 (PDT) On Fri, 01 Sep 2023 13:06:40 +0530, Devi Priya wrote: > If the parent clock rate is greater than unsigned long max/2 then > integer overflow happens when calculating the clock rate on 32-bit systems. > As RCG2 uses half integer dividers, the clock rate is first being > multiplied by 2 which will overflow the unsigned long max value. > Hence, replace the common pattern of doing 64-bit multiplication > and then a do_div() call with simpler mult_frac call. > > [...] Applied, thanks! [1/1] clk: qcom: clk-rcg2: Fix clock rate overflow for high parent frequencies commit: f7b7d30158cff246667273bd2a62fc93ee0725d2 Best regards, -- Bjorn Andersson