Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
From:   "Luck, Tony" <tony.luck@intel.com>
To:     "Wieczor-Retman, Maciej" <maciej.wieczor-retman@intel.com>
CC:     "Shaopeng Tan (Fujitsu)" <tan.shaopeng@fujitsu.com>,
        "Yu, Fenghua" <fenghua.yu@intel.com>,
        "Chatre, Reinette" <reinette.chatre@intel.com>,
        Peter Newman <peternewman@google.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Shuah Khan <skhan@linuxfoundation.org>,
        "x86@kernel.org" <x86@kernel.org>,
        James Morse <james.morse@arm.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        "Babu Moger" <babu.moger@amd.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "patches@lists.linux.dev" <patches@lists.linux.dev>
Subject: RE: [PATCH v5 8/8] selftests/resctrl: Adjust effective L3 cache size
 when SNC enabled
Thread-Topic: [PATCH v5 8/8] selftests/resctrl: Adjust effective L3 cache size
 when SNC enabled
Thread-Index: AQHZ2tLQzZViQZuDwEGXIVxBB0yNB7AO4J8AgAC3GnCAEj3NgIAAfdyAgAEIEYCAAJM4YA==
Date:   Wed, 20 Sep 2023 15:00:50 +0000
Message-ID: <SJ1PR11MB608385721D0F2B5C5BCB5D0FFCF9A@SJ1PR11MB6083.namprd11.prod.outlook.com>
References: <20230722190740.326190-1-tony.luck@intel.com>
 <20230829234426.64421-1-tony.luck@intel.com>
 <20230829234426.64421-9-tony.luck@intel.com>
 <TYAPR01MB633033C489AAC0E514CBC6688BEEA@TYAPR01MB6330.jpnprd01.prod.outlook.com>
 <SJ1PR11MB60839EB5CC3D172D864DF7A7FCEEA@SJ1PR11MB6083.namprd11.prod.outlook.com>
 <7gbxb6kxwa6anvcc4dquyuu7yronww6ztelazn2xllplorhbp5@i7o4fum5tjuf>
 <SJ1PR11MB608362BE12F47FFA54381FB9FCFAA@SJ1PR11MB6083.namprd11.prod.outlook.com>
 <nchqtx6dp3e2pcp64j7fdeyauarl4funonwkjx3nn5zztgpfw2@2xpb44k52ke6>
In-Reply-To: <nchqtx6dp3e2pcp64j7fdeyauarl4funonwkjx3nn5zztgpfw2@2xpb44k52ke6>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wPkCm8p0kgj+x9oD67Df0d4gMBPpkHMTjX05IWwUe1P5Jd8ZO1MF1Pk2FE7X?=
 =?us-ascii?Q?S586qRXcz6udbDFclvy+BN7bo7oubZCEik7mgu9GTXPNjcsDWfTwkn3mwzfg?=
 =?us-ascii?Q?/CtYP9DDdSUAK4KFDGcbZJDUZURVNexC0ahVzRD6F31NMbvn3fe27NIjKuZz?=
 =?us-ascii?Q?b/BUwS6ue9lBMe9YFR5KJDqFRvEQSziHSRcdM4ApDudGQ69ophYvVHJpWsuB?=
 =?us-ascii?Q?9GpD8zTGC490YaH1kkuTupuxdqZ1wJw8vVeQs4sfHX3GQW0eSZ/ceOk+Hpoq?=
 =?us-ascii?Q?Gl0TyNSY7rFyAlxOiJs+5oISzVO9Hlv++eDDRc7gsU/Zh3J/p3kRdc4qFfE2?=
 =?us-ascii?Q?X+I43lOQbIP82pCMR/EuRhchMGl9cH8Nobp8pchMX1BYLHkmgBEEpwXdWzGC?=
 =?us-ascii?Q?GYX767eAgLhs4oo6UZ8jH2j17wXD8b3wUkrvYIg3xQkSW0O8te0cqQe1AdI8?=
 =?us-ascii?Q?02tNNTjywoAknl7fR5RNbLLf9ay5jagjq4XT0uliIA1apJGowabpwnzBb6io?=
 =?us-ascii?Q?tAzbSQmabcYeaiX7MUiWDb/UuMhE/fkIwS6khE1yY36qVHzppvRLuUDgs1Z+?=
 =?us-ascii?Q?b55cyaqDmPF7ZJxBAyRygRVHDwEphyFvBRbwz9THd3Du05BmMNi8Q19+u2Tc?=
 =?us-ascii?Q?WTMmlA2SCVLXdxrZw/PeF5LBzos6+uILmQhmKGTkzycGylzAEVZ4AOGJ9IB+?=
 =?us-ascii?Q?uDnPByQfleNWCC/tnpdcMf8QKJdG7NgWfjOhEtXo7vM39Vfqc2IMeBAOACZl?=
 =?us-ascii?Q?WUQWoxzIuWujnhNPrwgqDBcu/G7AG4OsHd2+L61krvnngjZ+HWGHw3Q7Otmx?=
 =?us-ascii?Q?BCHCT3kw+96cXxaCr+BqVOl4lZyUz6uXN8AbpiJ9BQ3oZ3qsdVTswmt2kinB?=
 =?us-ascii?Q?KAO0Ra+BqWg7z84uqNkTspCquzmHokbfsoIzqfiC8k70lF47L2KEYFCR6s9L?=
 =?us-ascii?Q?9slSd+nInx366Rt+s6rPrO1/JA6uiC5ZbtJ+CkzhjeIbPWeUb/maXgJdyWHo?=
 =?us-ascii?Q?YgdJcZDZ4g3LxHm6eccsfeshvgz4CqMvE7GdF5b3AYBzBqlJhRkt8C5aEW9R?=
 =?us-ascii?Q?DP33X8xhSTdhmywjqKEdEDnPPVaUMgKIErDsMYXWH7DozFC42DKhyHUlgZZS?=
 =?us-ascii?Q?2TAS979YtWNGptsGZneWWOMcEXZuTdxBXoiZBZgjIiJ6/biBHeT1rPl6Lni0?=
 =?us-ascii?Q?5rmIX79oB4sbj+0T1kIsbraMweNDqdsJiNLv9NFE5u12CP1dPl/j32nCURs+?=
 =?us-ascii?Q?5f+KOP0gsBQERsE47N97QfVsyUCbDsIosE34UwntI7xlzdNhbYyvaFm+Of32?=
 =?us-ascii?Q?Jgq04iLfVOhWUhaj778v0kC85Ps+fIlPQIp+9o95gHgYJNf7m5SUEm/PJJqS?=
 =?us-ascii?Q?uGq/rtEnbZqNz8s6PBEhZ8PEBLdBYZ3W4hDwJWR+6oI0An+ptNOkmJ97fh1x?=
 =?us-ascii?Q?FlbG4qGIOCW3fNquoQt8/KMg8ucFzlRXqke72dW+kAxNKzPDndUvb3oh6To8?=
 =?us-ascii?Q?CQC+IsnFYo7QMoBFlfd0cmDA3Sgs2kStm6X6+CRtMPufiV9vBxBSjKR6aB9O?=
 =?us-ascii?Q?KZwF9S/L6+nhRlHgxlnDMbWx6WdusVAXxoqQ2r6x?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6083.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5a6afd72-e8f3-4e6a-f622-08dbb9ea613e
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Sep 2023 15:00:50.7965
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6E6Nv1CI5DJHG4vlFGWrEaTJ7FbS8Jumd/iZiueSKP93PBU4YYo+A8PQjViagfmyLnBuNKNbOoylz/XUzZWZjg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5420
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 20 Sep 2023 08:03:20 -0700 (PDT)

> What about outputing this value to userspace from resctrl? The ratio is
> already saved inside snc_nodes_per_l3_cache variable. And that would
> help avoid these difficult cases when some cpus are offline which could
> cause snc_ways() to return a wrong value. Or are there some pitfalls
> to that approach?

My original patch series added an "snc_ways" file to the info/ directory
to make this visible. But I was talked out of it because of a lack of clear
user mode use case that needs it.

https://lore.kernel.org/all/f0841866-315b-4727-0a6c-ec60d22ca29c@arm.com/

I don't know if the resctrl self tests constitute a valid use case. Perhaps=
 not
as they can figure this out.

But ... maybe the difficulties that user mode has (because of possibly offl=
ine
CPUs) are an indicator that the kernel should expose this. If only to
make the kernel's view clear in case there are situations where it got the
calculation wrong. E.g. kernel booted with a maxcpus=3DN parameter.

-Tony