Date: Fri, 9 Nov 2007 14:25:00 +0000
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Frank Seidel <fseidel@suse.de>
Cc: linux-kernel@vger.kernel.org, greg@kroah.com, p.hardwick@option.com,
       Marcel Holtmann <marcel@holtmann.org>
Subject: Re: nozomi version 2.1c for review
Message-ID: <20071109142500.0201fe4a@the-village.bc.nu>
In-Reply-To: <200711091449.24648.fseidel@suse.de>
References: <200711091449.24648.fseidel@suse.de>
Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street,
 Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a
 Lloegr o'r rhif cofrestru 3798903
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 973
Lines: 35

> and already in Gregs git repository) i resolved and removed all those
> GET_* and SET_* macros.

Oh good, that was long overdue.

> +	switch (port) {
> +	case PORT_MDM:
> +		dc->last_ier = (dc->last_ier & ~MDM_UL) | MDM_UL;
> +		break;

	The & ~xxx is unneeded if you then set it again always

Could also clean up to be

	u8 mask[NR_PORTS] = { DIAG_UGL, APP1_UL, ... }
	dc->last_ier |= mask[port];

instead of the switch - ditto disable transmit_ul etc

> +	case PORT_DIAG:
> +		dc->last_ier = (dc->last_ier & ~DIAG_UL) | DIAG_UL;
> +		break;
> +	case PORT_APP1:
> +		dc->last_ier = (dc->last_ier & ~APP1_UL) | APP1_UL;


Looking a lot better than before and with plenty of scope for more
improvement now it can be read.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/