Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Date:   Wed, 20 Sep 2023 16:39:28 +0200
From:   Borislav Petkov <bp@alien8.de>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     LKML <linux-kernel@vger.kernel.org>, x86@kernel.org,
        "Chang S. Bae" <chang.seok.bae@intel.com>,
        Arjan van de Ven <arjan@linux.intel.com>,
        Nikolay Borisov <nik.borisov@suse.com>
Subject: Re: [patch V3 08/30] x86/microcode/intel: Save the microcode only
 after a successful late-load
Message-ID: <20230920143928.GFZQsEIFvAuH8YMSq6@fat_crate.local>
References: <20230912065249.695681286@linutronix.de>
 <20230912065501.269244004@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20230912065501.269244004@linutronix.de>
Precedence: bulk

On Tue, Sep 12, 2023 at 09:57:56AM +0200, Thomas Gleixner wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
> 
> There are situations where the late microcode is loaded into memory, but is
> not applied:
> 
>   1) The rendevouz fails
>   2) The microcode is rejected by the CPUs
> 
> If any of this happens then the pointer which was updated at firmware load
> time is stale and subsequent CPU hotplug operations either fail to update
> or create inconsistent microcode state.
> 
> Save the loaded microcode in a separate pointer from with the late load is

s/from with/before/

> attempted and when successful, update the hotplug pointer accordingly via a
> new micrcode_ops callback.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette