Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
From:   Biju Das <biju.das.jz@bp.renesas.com>
To:     Thomas Gleixner <tglx@linutronix.de>,
        John Stultz <jstultz@google.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Geert Uytterhoeven <geert+renesas@glider.be>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        John Stultz <jstultz@google.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Stephen Boyd <sboyd@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Biju Das <biju.das.au@gmail.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        "linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
        "linux-renesas-soc@vger.kernel.org" 
        <linux-renesas-soc@vger.kernel.org>,
        Trent Piepho <tpiepho@gmail.com>
Subject: RE: [Query]: Resource cleanup for Alarmtimer
Thread-Topic: [Query]: Resource cleanup for Alarmtimer
Thread-Index: AdnrmFAjUih7l1QlSdSObu7MvB/BAQAH7oWA
Date:   Wed, 20 Sep 2023 11:46:56 +0000
Message-ID: <OS0PR01MB5922E907FCC5B7638B9CA29A86F9A@OS0PR01MB5922.jpnprd01.prod.outlook.com>
References: <OS0PR01MB5922DD412F43E1C836E32AF486F9A@OS0PR01MB5922.jpnprd01.prod.outlook.com>
In-Reply-To: <OS0PR01MB5922DD412F43E1C836E32AF486F9A@OS0PR01MB5922.jpnprd01.prod.outlook.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4QbKqCyWfyzXSdQpNQrQ8nuWmB4tT9V1SIeOn0sS1DwxDdqFBsNKUu+fUEcw?=
 =?us-ascii?Q?eUxXRVoauCEZrtp3J0+NWvwsjZ60SjqyYLGT7G06Jy7zMcBoc8iugdXdqtjl?=
 =?us-ascii?Q?V+t7fodO8APd4FG88z2EiESK2VGqDGSp/6xfD42B5ZqGlYCrA2VE2Qe/rxnV?=
 =?us-ascii?Q?jMeB5YvcRURSpymEpFbz+BrqQmIOL0IGfCEe2GgBfG8pdGAV/34Nvz2sAD86?=
 =?us-ascii?Q?Rm5djXDDpemHaeUoQJpgJxpyIgEehb8qvCtOLizbm7NOAjbiKCKwrrq94iX0?=
 =?us-ascii?Q?gFztRM0HsvcLEPFC7KZfYH1jkVMAP8CdK8T/YHEpXstOCvX/DDFF+xasM3it?=
 =?us-ascii?Q?2EPHy/pUJOVUNrRiJFyP69DPUUya271ZfH4Yq+5BF6OkP1/Jv9v6CkB4dojR?=
 =?us-ascii?Q?rAAlBDGZ/qi+aMdPgB3alDMjsuwqwEMPkWJBqp6dF/5nleQvENXTlGEurx3c?=
 =?us-ascii?Q?J5YAqYVZyNzXIXZmW5IpGnjXKH3Febf/zPszvnd6PA+qOiHsoDp0LTfj3Obh?=
 =?us-ascii?Q?MQi2pvGnGLBV8LmpNAkURyttSsTajrfAdbKvfPxSMhq19AJS2ETWgQg8Gs/F?=
 =?us-ascii?Q?/S+PKyvkunbVdE/5IDKl0JhteHMD0ykNoXPvUeQCDQSSArBbfnQVF3NBywN/?=
 =?us-ascii?Q?b0vLOyyBZzRJg1Y+GUf+1yRvbJ875r+Ik5gxkOYJ9jJc3OcU4XdzvOfeIo2g?=
 =?us-ascii?Q?OXo6zJ312iSVLxfzj0d68fhSpzEBMORZtuHVtV7bC5XjokrxJ3ZvsqnAJxcy?=
 =?us-ascii?Q?kg/3g4eOaaUMcIsvo/iYwFs4rX9N84/XU8J3u7nFNX2auvX6nfiL4zRPeg7b?=
 =?us-ascii?Q?8e59BiK3mz1+TDojwhlGxbmvdjnyYGPtCfV5q1J7r9pEA6CAirzcO1hBUSwU?=
 =?us-ascii?Q?iHsrMOxnxRVPTXANxyraEXA4Z2YLt3WboPyRzwKadlLJGrEaGe8PxSedtIGV?=
 =?us-ascii?Q?0mnP7pJzFfn3sK6tGes+4QA/Y//yw84wFpGFdxq7Hi8JxvfJlLBav+zrbiQC?=
 =?us-ascii?Q?HJJ8QV1G5bjB+t5mcEcXELEcVVU6mJYCiRW5Vs7PDF/Y1or9aO4nt7hEYIEr?=
 =?us-ascii?Q?xa4Y6jO37Fx7Gxs01j72E4J31QoZ65SMUpQn87qEPMIedc6qbgf7tLnHrD2m?=
 =?us-ascii?Q?3dZFeDCyIeZgQRKmTrhMzxMfuMpHVgdc+gzu1BTf4NDLlg8/bmuedBFnnLHy?=
 =?us-ascii?Q?ivu2KRR+kTSYOVsOLoFoyKO1awwFfrZSdEg703dyM6P4+/AYJz2U4E2DdLlM?=
 =?us-ascii?Q?cAWzPbJZYprx+JqPp8QmgmVRO3tcoTUHocvOGyqvKQgnnxlP1xnN1BwuDxdU?=
 =?us-ascii?Q?KoDNrjNeRjPdLcAuwYbAdv//Mm/e9FqbpatFIl1ZT6yN5Xs81Jdla6c/Z3Nx?=
 =?us-ascii?Q?Iin56XwngKffc4v5jxR2sActKvephUxNImuieSSVQWIdeXYCToTNKpvf9xRu?=
 =?us-ascii?Q?wQWjVNY3u/JlnORsf4HiG2ufSTa/nxyXh9djzVuc/X3LZYDZrjB3BUuWdArk?=
 =?us-ascii?Q?Qv0WeLU6gsBVdJtdlsKhhwq5xvcnrREnuvtSMxco2NkVIIwOawrbomZHmnPY?=
 =?us-ascii?Q?roAGPEhmUS1makfkFVc=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: bp.renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: OS0PR01MB5922.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: da2a09a3-12d0-4d8d-73eb-08dbb9cf4af5
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Sep 2023 11:46:56.9779
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: BssCwHosGTEeijBuFrZsPcLwNa4kkGC1j60EOHe+xjzuKpHAqftC5oPnEmfu8W7Fnhn0MXwmH4w5mh1/znqShewnqUz2i2LGGVqFU7bIrUs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY3PR01MB10517
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 20 Sep 2023 04:47:14 -0700 (PDT)

HI all,

I will send a patch to fix this issue soon. We will discuss
this topic there.

Cheers,
Biju

> Subject: [Query]: Resource cleanup for Alarmtimer
>=20
> Hi All,
>=20
> Currently unbind/bind is not working as expected on rtc-isl1208 driver. T=
he
> reason is put_device() is not calling rtc_device_release() as some of the
> kobjects are not freed during unbind.
>=20
> The commit 	c79108bd19a8 "alarmtimer: Make alarmtimer platform device
> child of RTC device" adds kobjects for alarmtimer device/sysfs, when we
> call device_init_wakeup() followed by devm_rtc_register_device()from the
> end point driver during probe().
> But these kobjects are never freed when we do unbind on the endpoint
> driver.
>=20
> The alarm timer device has alarmtimer_rtc_add_device() but it does not ha=
ve
> remove_device() callbacks to free kbjects.
>=20
> Q1) Has anyone tested unbind/rebind on RTC subsystem with
> device_init_wakeup() followed by devm_rtc_register_device() in the probe?
>=20
> Cheers,
> Biju
>=20