Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp1547000rdb; Wed, 20 Sep 2023 12:11:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEXMrBRleKzYtwz34Ls2ALzQMl2V0e5JQF0gDU6AZi8BGFUlHaco7JEBMNhxnYX/is4KV/c X-Received: by 2002:a05:6358:9224:b0:139:e766:5cbd with SMTP id d36-20020a056358922400b00139e7665cbdmr3779005rwb.32.1695237098123; Wed, 20 Sep 2023 12:11:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695237098; cv=none; d=google.com; s=arc-20160816; b=w5Q2SZMCwZ0vvVev5/u7xnVfpZwGVPOFTUJ9uT2MPkKrAQqXZ/f27w8INEKOeA6sNZ btt/9l5Ht2NlpDwQx4YIsyVC2OplVGAdH4SVkPqzT0IzUJmsYyAQIAKnDlE2Q2KdbEd/ r77Fwi8ExGL2oFf7H4vrDoLkqBGwbnSVt1QPiwjhMrEPVUbRCKc9Bibp6BLVx0B7yLS/ o6z848Llb1O4idvo/GY1pfywtCdUBQUF8H4jteTksp3Z/K/wVE7SY/GL7FH2HJ3MFdv9 KfROr53d+aNFWM0sA9MvRy/mRtPRHjQGOzNVCrNhxzz4EIPz+OISRzGuIZcDy9Uy5/C5 NE0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=KIinxHgd3W5A5KZig7FsyZOy3C3CzjLyJqwrfF5qVT8=; fh=sS+J4OyOC0EcVLWJpS3mBHGeO+0+dYZJ+ImCUfzsrH4=; b=Ify7eth39Vb/HPexi/k4A20GckVbkrva8J7fSTvX2QIj5C6p5YS3wokvmOPdeipfnf o/FG4y8MR6BsUV+KiGiK69a+llsfpHncqPRc9LvsG7x6bsFfoQENU36fy4pUsJGa27fM mu/5nwLFLc/gSR+JjH7JTG7s+26pQK9ggcWQasKibDjkPHN9NsKBTtsPEipTslU+achO rM0q6/9O5JrLcLNxtK4QnGNAleMjRJxSND2IFMR3k93bvCGsQ2UZevskuRajQA0+JYWf NG5zVSdyDRVt1TfhL/KzRFiRo+d3TMh7xk9wOHho13GHCzjpYKIti1/xCi70877Lymam DffA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id l191-20020a6388c8000000b005783f4fa3a8si2677029pgd.203.2023.09.20.12.11.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Sep 2023 12:11:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 2B0C78199710; Wed, 20 Sep 2023 12:02:13 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229871AbjITTBq (ORCPT + 99 others); Wed, 20 Sep 2023 15:01:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229832AbjITTBm (ORCPT ); Wed, 20 Sep 2023 15:01:42 -0400 Received: from 66-220-144-179.mail-mxout.facebook.com (66-220-144-179.mail-mxout.facebook.com [66.220.144.179]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6F99C2 for ; Wed, 20 Sep 2023 12:01:35 -0700 (PDT) Received: by devbig1114.prn1.facebook.com (Postfix, from userid 425415) id 3BE9EC4363F8; Wed, 20 Sep 2023 12:01:22 -0700 (PDT) From: Stefan Roesch To: kernel-team@fb.com Cc: shr@devkernel.io, akpm@linux-foundation.org, david@redhat.com, hannes@cmpxchg.org, riel@surriel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH v2 2/2] mm/ksm: Test case for prctl fork/exec workflow Date: Wed, 20 Sep 2023 12:01:17 -0700 Message-Id: <20230920190117.784151-3-shr@devkernel.io> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20230920190117.784151-1-shr@devkernel.io> References: <20230920190117.784151-1-shr@devkernel.io> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 20 Sep 2023 12:02:13 -0700 (PDT) This adds a new test case to the ksm functional tests to make sure that the KSM setting is inherited by the child process when doing a fork/exec. Signed-off-by: Stefan Roesch --- .../selftests/mm/ksm_functional_tests.c | 67 ++++++++++++++++++- 1 file changed, 66 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/ksm_functional_tests.c b/tools/te= sting/selftests/mm/ksm_functional_tests.c index 901e950f9138..40b86c9caf3a 100644 --- a/tools/testing/selftests/mm/ksm_functional_tests.c +++ b/tools/testing/selftests/mm/ksm_functional_tests.c @@ -26,6 +26,7 @@ =20 #define KiB 1024u #define MiB (1024 * KiB) +#define FORK_EXEC_CHILD_PRG_NAME "ksm_fork_exec_child" =20 static int mem_fd; static int ksm_fd; @@ -479,6 +480,65 @@ static void test_prctl_fork(void) ksft_test_result_pass("PR_SET_MEMORY_MERGE value is inherited\n"); } =20 +static int ksm_fork_exec_child(void) +{ + /* Test if KSM is enabled for the process. */ + int ksm =3D prctl(PR_GET_MEMORY_MERGE, 0, 0, 0, 0); + return ksm =3D=3D 1; +} + +static void test_prctl_fork_exec(void) +{ + int ret, status; + pid_t child_pid; + + ksft_print_msg("[RUN] %s\n", __func__); + + ret =3D prctl(PR_SET_MEMORY_MERGE, 1, 0, 0, 0); + if (ret < 0 && errno =3D=3D EINVAL) { + ksft_test_result_skip("PR_SET_MEMORY_MERGE not supported\n"); + return; + } else if (ret) { + ksft_test_result_fail("PR_SET_MEMORY_MERGE=3D1 failed\n"); + return; + } + + child_pid =3D fork(); + if (child_pid =3D=3D -1) { + ksft_test_result_skip("fork() failed\n"); + return; + } else if (child_pid =3D=3D 0) { + char *prg_name =3D "./ksm_functional_tests"; + char *argv_for_program[] =3D { prg_name, FORK_EXEC_CHILD_PRG_NAME }; + + execv(prg_name, argv_for_program); + return; + } + + if (waitpid(child_pid, &status, 0) > 0) { + if (WIFEXITED(status)) { + status =3D WEXITSTATUS(status); + if (status) { + ksft_test_result_fail("KSM not enabled\n"); + return; + } + } else { + ksft_test_result_fail("program didn't terminate normally\n"); + return; + } + } else { + ksft_test_result_fail("waitpid() failed\n"); + return; + } + + if (prctl(PR_SET_MEMORY_MERGE, 0, 0, 0, 0)) { + ksft_test_result_fail("PR_SET_MEMORY_MERGE=3D0 failed\n"); + return; + } + + ksft_test_result_pass("PR_SET_MEMORY_MERGE value is inherited\n"); +} + static void test_prctl_unmerge(void) { const unsigned int size =3D 2 * MiB; @@ -536,9 +596,13 @@ static void test_prot_none(void) =20 int main(int argc, char **argv) { - unsigned int tests =3D 7; + unsigned int tests =3D 8; int err; =20 + if (argc > 1 && !strcmp(argv[1], FORK_EXEC_CHILD_PRG_NAME)) { + exit(ksm_fork_exec_child() =3D=3D 1 ? 0 : 1); + } + #ifdef __NR_userfaultfd tests++; #endif @@ -576,6 +640,7 @@ int main(int argc, char **argv) =20 test_prctl(); test_prctl_fork(); + test_prctl_fork_exec(); test_prctl_unmerge(); =20 err =3D ksft_get_fail_cnt(); --=20 2.39.3