Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Date:   Wed, 20 Sep 2023 11:44:24 -0500
From:   Nishanth Menon <nm@ti.com>
To:     Roger Quadros <rogerq@kernel.org>
CC:     <vigneshr@ti.com>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
        <srk@ti.com>, <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] arm64: dts: ti: am642-evm: Add overlay for NAND
 expansion card
Message-ID: <20230920164424.rrjvm6nvtv4ysyrw@unreal>
References: <20230920133450.54226-1-rogerq@kernel.org>
 <20230920133450.54226-3-rogerq@kernel.org>
 <20230920135802.3ej2wcuaruqjidel@uncouth>
 <e8f26137-1284-4f45-a74d-a0a5f2aa2f93@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <e8f26137-1284-4f45-a74d-a0a5f2aa2f93@kernel.org>
Precedence: bulk

On 18:18-20230920, Roger Quadros wrote:
> 
> 
> On 20/09/2023 16:58, Nishanth Menon wrote:
> > On 16:34-20230920, Roger Quadros wrote:
> >> The NAND expansion card plugs in over the HSE (High Speed Expansion)
> >> connector. Add support for it.
> >>
> >> Signed-off-by: Roger Quadros <rogerq@kernel.org>
> >> ---
> >>  arch/arm64/boot/dts/ti/Makefile               |   1 +
> >>  arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso | 140 ++++++++++++++++++
> >>  2 files changed, 141 insertions(+)
> >>  create mode 100644 arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso
> >>
> >> diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile
> >> index 06d6f264f292..ece74085a6be 100644
> >> --- a/arch/arm64/boot/dts/ti/Makefile
> >> +++ b/arch/arm64/boot/dts/ti/Makefile
> >> @@ -29,6 +29,7 @@ dtb-$(CONFIG_ARCH_K3) += k3-am62p5-sk.dtb
> >>  
> >>  # Boards with AM64x SoC
> >>  dtb-$(CONFIG_ARCH_K3) += k3-am642-evm.dtb
> >> +dtb-$(CONFIG_ARCH_K3) += k3-am642-evm-nand.dtbo
> >>  dtb-$(CONFIG_ARCH_K3) += k3-am642-phyboard-electra-rdk.dtb
> >>  dtb-$(CONFIG_ARCH_K3) += k3-am642-sk.dtb
> >>  dtb-$(CONFIG_ARCH_K3) += k3-am642-tqma64xxl-mbax4xxl.dtb
> > 
> > Also see https://lore.kernel.org/all/20230911165610.GA1362932-robh@kernel.org/
> > 
> > you may not get the dtbo installed when doing make dtbs_install
> > 
> > [...]
> > 
> 
> $ v8make dtbs_install INSTALL_DTBS_PATH=/tmp
>   INSTALL /tmp/ti/k3-am625-beagleplay.dtb
>   INSTALL /tmp/ti/k3-am625-phyboard-lyra-rdk.dtb
>   INSTALL /tmp/ti/k3-am625-sk.dtb
>   INSTALL /tmp/ti/k3-am625-verdin-nonwifi-dahlia.dtb
>   INSTALL /tmp/ti/k3-am625-verdin-nonwifi-dev.dtb
>   INSTALL /tmp/ti/k3-am625-verdin-nonwifi-yavia.dtb
>   INSTALL /tmp/ti/k3-am625-verdin-wifi-dahlia.dtb
>   INSTALL /tmp/ti/k3-am625-verdin-wifi-dev.dtb
>   INSTALL /tmp/ti/k3-am625-verdin-wifi-yavia.dtb
>   INSTALL /tmp/ti/k3-am62-lp-sk.dtb
>   INSTALL /tmp/ti/k3-am62x-sk-hdmi-audio.dtbo
>   INSTALL /tmp/ti/k3-am62a7-sk.dtb
>   INSTALL /tmp/ti/k3-am62p5-sk.dtb
>   INSTALL /tmp/ti/k3-am642-evm.dtb
>   INSTALL /tmp/ti/k3-am642-evm-nand.dtbo
> ^^^^
>   INSTALL /tmp/ti/k3-am642-phyboard-electra-rdk.dtb
>   INSTALL /tmp/ti/k3-am642-sk.dtb
> 
> 
> What did I miss?

I missed it, actually. See Rob's comment:
https://lore.kernel.org/all/CAL_Jsq+GR3hP6hFvFn2z5aXvSXnh9butD3aKZ-y_XJgx0_YPTw@mail.gmail.com/

Having orphan dtbo is apparently frowned upon

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D