Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Date:   Wed, 20 Sep 2023 21:11:40 +0800
From:   Feng Tang <feng.tang@intel.com>
To:     Vlastimil Babka <vbabka@suse.cz>
CC:     David Rientjes <rientjes@google.com>,
        Christoph Lameter <cl@linux.com>,
        Hyeonggon Yoo <42.hyeyoo@gmail.com>,
        Jay Patel <jaypatel@linux.ibm.com>,
        Roman Gushchin <roman.gushchin@linux.dev>,
        Pekka Enberg <penberg@kernel.org>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "patches@lists.linux.dev" <patches@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] mm/slub: attempt to find layouts up to 1/2 waste in
 calculate_order()
Message-ID: <ZQrvjFuSAO6DHhQ0@feng-clx>
References: <20230908145302.30320-6-vbabka@suse.cz>
 <20230908145302.30320-9-vbabka@suse.cz>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230908145302.30320-9-vbabka@suse.cz>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dv3TYCcX+eepzv6+IXT35ktV+UQQdOj1cRSNqqIeZrEPqZWSDjTTQdsc61cp?=
 =?us-ascii?Q?t212cfKmt3syEU4pWfk1bBqjvCVptqTST/qhcFTs6CrPkEQ3XOmyWWdlE18I?=
 =?us-ascii?Q?kT+Un9v1yopAVlRojzXGvKYYpQD/gB84EKQEHCAHhe9tF19KB5tlINxqP1RZ?=
 =?us-ascii?Q?IWhP2xvyhcLEb1U8L7NhIs7J3IoR0oeW2t5rqPh78t31qnLXsq3MqSUDTPog?=
 =?us-ascii?Q?SiDudbh/FnTZ9C7OpbdFgn4vKaDXo0BJNMEfgWC6jVwZcNneXH2IY2ch+oyB?=
 =?us-ascii?Q?T2kzVYVACO6sqHVMYYRKRVeovI7peE75BsTz4wfKsh0xrMgcCytBf032wjeK?=
 =?us-ascii?Q?DbePwLyG+5BuY7BXaGnyUyi0O5O4fAIKHqOUEg2w1JUujheYiTlL/QBVetRq?=
 =?us-ascii?Q?cwBVh2vTHkmhu+B9egQQXXXlk/SzmKA1nErvT+Fm6f5DnhDNbuJ4fm2IpG4d?=
 =?us-ascii?Q?FgQZzxfHVntWylWQfXYw7Xz1DimFGPvr+d0chCJ3RqbMn9t8WVrXiQYF6R8E?=
 =?us-ascii?Q?xqgwGfL4bWNV9hP9KpDsrV8xeaDs21loTwkhtQt+lFTdo55DElnSiPEcDdi0?=
 =?us-ascii?Q?eqvpcA0BnTbX8exYrdPSqpMrqvU4CorDPAw8I4XjoxDbqZrbXTamThh4FTLa?=
 =?us-ascii?Q?78HTOO9td01kwjh/jyz/LbylL5phF6tE+Zv/EiCntBLjL3LhBDCFCtMHzLZe?=
 =?us-ascii?Q?RADIdGBOdAvkvdHFLDwKQPrgozVOm8i+ioLQ48LQl+edO6GZZoia4tlSLm6P?=
 =?us-ascii?Q?ROqIW88omr95a83WpGPUBVLOeEpS+tHYnp1jvDQrC3vRwPklil3aTEUr3kgS?=
 =?us-ascii?Q?I4fvSwBtJpMQ1TFWZj/lU4M7hP2FYpHR6ujHEdtfTNKOYC0v2vqo8WXBaYi5?=
 =?us-ascii?Q?8Fdxuq5CyncOE7fPCVw1THRirDMJkftCti8iUT3Xgj/JzyJK0dAq5sLKN6Cm?=
 =?us-ascii?Q?ISh1TQeDmawp1RUYHQRI1i+ZO7igtMCcZXd49xo8/0Oi2iHHCa/N8O8n8403?=
 =?us-ascii?Q?/I2mSVZ2arB/m3GNxGAGVPyGd7HC7dIT83bw1yAeGXrYbKu87f/L42DLLOQ9?=
 =?us-ascii?Q?EiUGOiu+e9iQSD/xY8UtgHsaGZaCaKklbXJQQi2/b7bpVfRl9BMtRaKK1rDt?=
 =?us-ascii?Q?0R5efaUx9cr9Gg08TSQtJvllQciK0nnJLi8Bampj2lBQNWI2qwKaXgSSjCxH?=
 =?us-ascii?Q?HQ4QdctLhv80wcANSGRe5vMt2lYabXoP+lhQusEvCC9bbfdF2rEH3RLAMKcf?=
 =?us-ascii?Q?GH6nbgS7OIAQm+fR62JUZJ8sEfuwjI+yWicGE6aRZMW8KoFM85h4VRCN6znd?=
 =?us-ascii?Q?A8uAaFUKS0HyQ+yWRvvz9iLVdDqy0ZJSgPQUlElnGn4w8tVykWJ1dwMQkQE4?=
 =?us-ascii?Q?EEHIzvebsMjhP9gN+SqiuuLqw982z6W9gxTfQPPZApyn3J8ZrOW2iXx4r9qJ?=
 =?us-ascii?Q?wd8+PeplGxxf5znuqPIlg4ZqwLCFjfGXSEiE0Dmv1Bg2harWS1H0OxemTw40?=
 =?us-ascii?Q?/eNISUKDCaKchBhoEYqsR8gLws3VgWhElfwUTRKuVHihtfYvM4AKUQVXrwO2?=
 =?us-ascii?Q?WTvvZ//v40FXtFqve4ewYkt2qMgQY0BZJgW/pEjM?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6adf5664-8d1e-4f1c-c766-08dbb9dc72df
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2023 13:21:07.7775
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: J6yaTP/24i0VYcGQZmAxU4Q5+eQdY2Sb7X1u+8WuwhTBWrqt4tp7J8eYO33y5pK5s5wuhZ8Tsqmc3VQde1H5VQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5225
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 20 Sep 2023 06:21:25 -0700 (PDT)

On Fri, Sep 08, 2023 at 10:53:06PM +0800, Vlastimil Babka wrote:
> The main loop in calculate_order() currently tries to find an order with
> at most 1/4 waste. If that's impossible (for particular large object
> sizes), there's a fallback that will try to place one object within
> slab_max_order.
> 
> If we expand the loop boundary to also allow up to 1/2 waste as the last
> resort, we can remove the fallback and simplify the code, as the loop
> will find an order for such sizes as well. Note we don't need to allow
> more than 1/2 waste as that will never happen - calc_slab_order() would
> calculate more objects to fit, reducing waste below 1/2.
> 
> Sucessfully finding an order in the loop (compared to the fallback) will
> also have the benefit in trying to satisfy min_objects, because the
> fallback was passing 1. Thus the resulting slab orders might be larger
> (not because it would improve waste, but to reduce pressure on shared
> locks), which is one of the goals of calculate_order().
> 
> For example, with nr_cpus=1 and 4kB PAGE_SIZE, slub_max_order=3, before
> the patch we would get the following orders for these object sizes:
> 
>  2056 to 10920 - order-3 as selected by the loop
> 10928 to 12280 - order-2 due to fallback, as <1/4 waste is not possible
> 12288 to 32768 - order-3 as <1/4 waste is again possible
> 
> After the patch:
> 
> 2056 to 32768 - order-3, because even in the range of 10928 to 12280 we
>                 try to satisfy the calculated min_objects.
> 
> As a result the code is simpler and gives more consistent results.
 
Current code already tries the fraction "1" in the follwing 2 fallback
calls of calc_slab_order(), so trying fraction "2" makes sense to me.

Reviewed-by: Feng Tang <feng.tang@intel.com>

Thanks,
Feng

> Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
> ---
>  mm/slub.c | 14 ++++----------
>  1 file changed, 4 insertions(+), 10 deletions(-)
> 
> diff --git a/mm/slub.c b/mm/slub.c
> index 5c287d96b212..f04eb029d85a 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -4171,23 +4171,17 @@ static inline int calculate_order(unsigned int size)
>  	 * the order can only result in same or less fractional waste, not more.
>  	 *
>  	 * If that fails, we increase the acceptable fraction of waste and try
> -	 * again.
> +	 * again. The last iteration with fraction of 1/2 would effectively
> +	 * accept any waste and give us the order determined by min_objects, as
> +	 * long as at least single object fits within slub_max_order.
>  	 */
> -	for (unsigned int fraction = 16; fraction >= 4; fraction /= 2) {
> +	for (unsigned int fraction = 16; fraction > 1; fraction /= 2) {
>  		order = calc_slab_order(size, min_objects, slub_max_order,
>  					fraction);
>  		if (order <= slub_max_order)
>  			return order;
>  	}
>  
> -	/*
> -	 * We were unable to place multiple objects in a slab. Now
> -	 * lets see if we can place a single object there.
> -	 */
> -	order = calc_slab_order(size, 1, slub_max_order, 1);
> -	if (order <= slub_max_order)
> -		return order;
> -
>  	/*
>  	 * Doh this slab cannot be placed using slub_max_order.
>  	 */
> -- 
> 2.42.0
> 
>