Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
MIME-Version: 1.0
References: <20230920052139.10570-1-rdunlap@infradead.org> <20230920052139.10570-17-rdunlap@infradead.org>
In-Reply-To: <20230920052139.10570-17-rdunlap@infradead.org>
From:   Max Filippov <jcmvbkbc@gmail.com>
Date:   Wed, 20 Sep 2023 04:54:42 -0700
Message-ID: <CAMo8Bf+UpPzHd_Dc-236sMRcGZ6ynwG3mY-7NCtApbLdzvjsNw@mail.gmail.com>
Subject: Re: [PATCH 16/16] xtensa: boot/lib: add missing prototypes for functions
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     linux-kernel@vger.kernel.org, Chris Zankel <chris@zankel.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Sep 19, 2023 at 10:21=E2=80=AFPM Randy Dunlap <rdunlap@infradead.or=
g> wrote:
>
> Add function prototypes for exit(), zalloc(), and gunzip() to the
> boot library code.

exit() and zalloc() don't need to be public. I've posted a different fix th=
at
makes these two functions static.


> arch/xtensa/boot/lib/zmem.c:8:6: warning: no previous prototype for 'exit=
' [-Wmissing-prototypes]
>     8 | void exit (void)
> arch/xtensa/boot/lib/zmem.c:13:7: warning: no previous prototype for 'zal=
loc' [-Wmissing-prototypes]
>    13 | void *zalloc(unsigned size)
> arch/xtensa/boot/lib/zmem.c:35:6: warning: no previous prototype for 'gun=
zip' [-Wmissing-prototypes]
>    35 | void gunzip (void *dst, int dstlen, unsigned char *src, int *lenp=
)
>
> Fixes: 4bedea945451 ("xtensa: Architecture support for Tensilica Xtensa P=
art 2")
> Fixes: e7d163f76665 ("xtensa: Removed local copy of zlib and fixed O=3D s=
upport")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Chris Zankel <chris@zankel.net>
> Cc: Max Filippov <jcmvbkbc@gmail.com>
> ---
>  arch/xtensa/boot/lib/zmem.c |    4 ++++
>  1 file changed, 4 insertions(+)

--=20
Thanks.
-- Max