Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp1629084rdb; Wed, 20 Sep 2023 15:02:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE9eGTVBrK2jVdVer/SUNSFyq7oVtZVbV2HqowkD0711m0c6w6Mzgk5G84EGNNhdRi7YPbT X-Received: by 2002:a05:6a00:10c7:b0:682:4ef7:9b17 with SMTP id d7-20020a056a0010c700b006824ef79b17mr3735622pfu.32.1695247359238; Wed, 20 Sep 2023 15:02:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695247359; cv=none; d=google.com; s=arc-20160816; b=h42d/maWyhqEuN4tP6kuL5urC0lvaiJtBn+NQfeqhy2FZFIM5k6dAHjnX2iGTi3vAx J5Pqfx4NkbD8KVMlgWgvAuvCt7MoIRF5yHLgWl3FQdB9a8MeXpL7owDPtNRFN1vo28cO eZAb0/Rneia4M7lnFtDyZa57aaKOpp8EXjx+AgEyRCM0t7dkrjkJmJ57x2Dw/aQcRdJK v+0MonUQASVBue19Yjk9z37Zwg3WgPnVjI5rMltex7H8XStRg8SQeU7ol8mphDMMKMBn ThYyinnYO2VIgaXmAu8Dit238PqVBsnz2qXHwXv7ROSzMVK6kND7CxVuDponKD+o7Udp JGBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=lJfsBldziK0+y1gZd9MVBY3xzM0ZT8qirDWA/gZ7Zm4=; fh=yxXK3nAeBcoAbbxgMpl2g08b07I+IvjZRGTnAVItXLc=; b=Iu7tLNTXgE6ZoJ/mmI4W/ASu+3qSG1qVHIBTHWGBwpYaL6nNk+C3tWYI2COpt6nN5+ eg+S+88MvWIqrUiplSXqRdwh9mHJvfsm3HNJiaC2EgKHuxPQObF+QTOTwqw2P/RFFySz yLiLORNaDaBeW5QRx7fs1/0if+QE12Bm2Wjj6jwTgi7pP/MvhX7ttWtga67yYNYmviQ4 SoW1fqi+zPOqZyfLX37E9RaJvhaMHnJnhpx30FWr5KXxiSmYGTKITxlTOINJF9Yvnyf1 m1Aoe4Y8uiukGFqFt6/VUIEoABD0PAeEhqrN7ZdHAldhrJto6lFQs7mznLxvnnrI4BSu sxfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=X8zECv28; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id y11-20020a62ce0b000000b0069100e4252csi68465pfg.105.2023.09.20.15.02.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Sep 2023 15:02:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=X8zECv28; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id D5B7F8031AF1; Wed, 20 Sep 2023 06:57:29 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236783AbjITN53 (ORCPT + 99 others); Wed, 20 Sep 2023 09:57:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236703AbjITN4u (ORCPT ); Wed, 20 Sep 2023 09:56:50 -0400 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 773D6F9 for ; Wed, 20 Sep 2023 06:56:44 -0700 (PDT) Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.17.1.22/8.17.1.22) with ESMTP id 38KD9sDC008065; Wed, 20 Sep 2023 08:56:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=PODMain02222019; bh=lJfsBldziK0+y1g Zd9MVBY3xzM0ZT8qirDWA/gZ7Zm4=; b=X8zECv28oHQ5bGY8PM8vMmpx03QOrNB TeBHMmJi43hL3Vde3mIqe8AeE0DbVnH5QnnlrLZK4ba2dVPsWvbn4gcoyJibJ3ll DBfgYcNT4RudtDjJTpPsFvu7xVaoDQPwBOn9d4FN9G836F8nFqZrNpyPAFmO/0Ul 6iIkTf1JRujs1NnIKlVHBpuXzYqjvQVPze5kPY6N/rq7UCIWqTJEy3/WibwV//YY VqfLD+1O0s9M2eKLQ1+W7vmT+tCZvDCz77rCMME2FCaG1OUlQ8RvBAKs1E3cc4+C RVMyr/qNLcJMJJmshZCOYkiGBSGz/niXCawG4s9l5b6d7xpfQ7aNiuw== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3t58shvex9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 20 Sep 2023 08:56:17 -0500 (CDT) Received: from ediex02.ad.cirrus.com (198.61.84.81) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.37; Wed, 20 Sep 2023 14:56:15 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by anon-ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server id 15.2.1118.37 via Frontend Transport; Wed, 20 Sep 2023 14:56:15 +0100 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 78124458; Wed, 20 Sep 2023 13:56:15 +0000 (UTC) Date: Wed, 20 Sep 2023 13:56:15 +0000 From: Charles Keepax To: Vinod Koul CC: , , , , , Subject: Re: [PATCH] soundwire: bus: Make IRQ handling conditionally built Message-ID: <20230920135615.GG103419@ediswmail.ad.cirrus.com> References: <20230918161026.472405-1-ckeepax@opensource.cirrus.com> <20230920085133.GE103419@ediswmail.ad.cirrus.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-GUID: 0FQlsJktRyIHuK9SDNJuiiRy6BUDZkyc X-Proofpoint-ORIG-GUID: 0FQlsJktRyIHuK9SDNJuiiRy6BUDZkyc X-Proofpoint-Spam-Reason: safe X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 20 Sep 2023 06:57:30 -0700 (PDT) On Wed, Sep 20, 2023 at 03:50:01PM +0200, Vinod Koul wrote: > On 20-09-23, 08:51, Charles Keepax wrote: > > On Wed, Sep 20, 2023 at 09:05:13AM +0200, Vinod Koul wrote: > > > On 18-09-23, 17:10, Charles Keepax wrote: > > > > SoundWire has provisions for a simple callback for the IRQ handling so > > > > has no hard dependency on IRQ_DOMAIN, but the recent addition of IRQ > > > > handling was causing builds without IRQ_DOMAIN to fail. Resolve this by > > > > moving the IRQ handling into its own file and only add it to the build > > > > when IRQ_DOMAIN is included in the kernel. > > > > > > > > Fixes: 12a95123bfe1 ("soundwire: bus: Allow SoundWire peripherals to register IRQ handlers") > > > > Reported-by: kernel test robot > > > > Closes: https://lore.kernel.org/oe-kbuild-all/202309150522.MoKeF4jx-lkp@intel.com/ > > > > Signed-off-by: Charles Keepax > > > > --- > > > > drivers/soundwire/Makefile | 4 +++ > > > > drivers/soundwire/bus.c | 31 +++---------------- > > > > drivers/soundwire/bus_type.c | 11 +++---- > > > > drivers/soundwire/irq.c | 59 ++++++++++++++++++++++++++++++++++++ > > > > drivers/soundwire/irq.h | 43 ++++++++++++++++++++++++++ > > > > 5 files changed, 115 insertions(+), 33 deletions(-) > > > > create mode 100644 drivers/soundwire/irq.c > > > > create mode 100644 drivers/soundwire/irq.h > > > > > > > > diff --git a/drivers/soundwire/Makefile b/drivers/soundwire/Makefile > > > > index c3d3ab3262d3a..657f5888a77b0 100644 > > > > --- a/drivers/soundwire/Makefile > > > > +++ b/drivers/soundwire/Makefile > > > > @@ -15,6 +15,10 @@ ifdef CONFIG_DEBUG_FS > > > > soundwire-bus-y += debugfs.o > > > > endif > > > > > > > > +ifdef CONFIG_IRQ_DOMAIN > > > > +soundwire-bus-y += irq.o > > > > +endif > > > > > > Any reason why we cant use depends for this? > > > > > > > No reason we can't, but my thinking was really that SoundWire doesn't > > really have a dependency on IRQ_DOMAIN, as you can use the original > > callback mechanism. It seemed a shame to force it as a dependency, > > when the whole subsystem can function happily without it. > > > > That said, I am happy to switch to a simple dependency if you prefer? > > It would certainly be a much simpler change. > > That is very valid point, not every user needs it... I guess lets go > with this change now, can you fix the comment style and we can merge > this > Cool will send a v2 either later today or tomorrow morning. Thanks, Charles