Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <c7818967-1fea-45da-9713-20de4bcb1c44@suse.de>
Date:   Wed, 20 Sep 2023 16:06:56 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] dm-zoned: free dmz->ddev array in dmz_put_zoned_device
Content-Language: en-US
To:     Fedor Pchelkin <pchelkin@ispras.ru>,
        Mike Snitzer <snitzer@kernel.org>
Cc:     Alasdair Kergon <agk@redhat.com>, dm-devel@redhat.com,
        linux-kernel@vger.kernel.org,
        Alexey Khoroshilov <khoroshilov@ispras.ru>,
        lvc-project@linuxtesting.org, stable@vger.kernel.org
References: <20230920105119.21276-1-pchelkin@ispras.ru>
From:   Hannes Reinecke <hare@suse.de>
In-Reply-To: <20230920105119.21276-1-pchelkin@ispras.ru>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 9/20/23 12:51, Fedor Pchelkin wrote:
> Commit 4dba12881f88 ("dm zoned: support arbitrary number of devices")
> made the pointers to additional zoned devices to be stored in a
> dynamically allocated dmz->ddev array. However, this array is not freed.
> 
> Free it when cleaning up zoned device information inside
> dmz_put_zoned_device(). Assigning NULL to dmz->ddev elements doesn't make
> sense there as they are not supposed to be reused later and the whole dmz
> target structure is being cleaned anyway.
> 
> Found by Linux Verification Center (linuxtesting.org).
> 
> Fixes: 4dba12881f88 ("dm zoned: support arbitrary number of devices")
> Cc: stable@vger.kernel.org
> Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru>
> ---
>   drivers/md/dm-zoned-target.c | 8 +++-----
>   1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/md/dm-zoned-target.c b/drivers/md/dm-zoned-target.c
> index ad8e670a2f9b..e25cd9db6275 100644
> --- a/drivers/md/dm-zoned-target.c
> +++ b/drivers/md/dm-zoned-target.c
> @@ -753,12 +753,10 @@ static void dmz_put_zoned_device(struct dm_target *ti)
>   	struct dmz_target *dmz = ti->private;
>   	int i;
>   
> -	for (i = 0; i < dmz->nr_ddevs; i++) {
> -		if (dmz->ddev[i]) {
> +	for (i = 0; i < dmz->nr_ddevs; i++)
> +		if (dmz->ddev[i])
>   			dm_put_device(ti, dmz->ddev[i]);
> -			dmz->ddev[i] = NULL;
> -		}
> -	}
> +	kfree(dmz->ddev);
>   }
>   
>   static int dmz_fixup_devices(struct dm_target *ti)

Hmm. I'm not that happy with it; dmz_put_zoned_device() is using 
dm_target as an argument, whereas all of the functions surrounding the 
call sites is using the dmz_target directly.

Mind to modify the function to use 'struct dmz_target' as an argument?

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew
Myers, Andrew McDonald, Martje Boudien Moerman