Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp1632776rdb; Wed, 20 Sep 2023 15:08:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEspMZovhcQ5a++lcX9INoaRTFZh+beiiNk3UEqgiLUR9MFvqJAYPpUwrxuxdnce2fq6tD0 X-Received: by 2002:a05:6871:60c:b0:1d4:d017:e315 with SMTP id w12-20020a056871060c00b001d4d017e315mr4169616oan.52.1695247723083; Wed, 20 Sep 2023 15:08:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695247723; cv=none; d=google.com; s=arc-20160816; b=T90OFlIIzq6tR6D/OXkB4Itjvr3AeEOqcTgpjEYIV0scXetqLjaej9IF/IGbm0v+wR udwDzCYxcXP34Zvc7S2yriX2AY3SDLAbvaXeKdTX9CCZ69ZK9eevWTjGr+tVBzlD4Fet Le5T3s8uiHNcud3y+Pb2LL5zjY9tpzdNeMEyNxyu24WdGSVorxpjPBJsUESZEoODKYCd MdekOP1mfY7O4Ea6ZKJiEadVe8uty59ekW3w+jx+E+F9ob+MBOjaAg5hAuLs+wBcUDSe zaPKRYt/CcUehljP9Kk9Et1yqhPjgbnhHRlafdRhvd23KEWlQANIa6GQf8XWcuqkBuvW kxcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=Jn2Ngd3ukFjoHjH9W9ENbDDoYAtr6LLLpGel78I6ZB0=; fh=4wYJbJY5xpFE8eSr1/mdOUkPjze6X3lVSyNE3IKTPH0=; b=Yk/y84qHRX3DsrxV84YeHwZV/1196ezbW03mCv7Xi4h9JuFbmLkmYFERwjKRna5jkq ipHxYuFq66gjQrrweeha6JlIWw0Ag5IgjhVylwDgKERuQBlBJJ59ucsdWTi76aREjCgI INSex4jDHu8Knnz0f7WcA0lUKaY6HdOGljW3/S+2MkbAlM0mZAcBdaf1kp0Rhs5RZLHa v9BMrdJ3t3uobW4F4Hi7JX19g0eAhLk/07qENj/dm1Ndf6b32H2n8iVs1fmrh4J/997N WcHpXHFH0CJaK42ZDaPfMy3mepHFiZAZXIh88kV3JX8toFKDZHAPV06DgVwu5+2kp9kR vHDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=RGi5AzZp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id l63-20020a638842000000b00578a9529cfasi24310pgd.87.2023.09.20.15.08.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Sep 2023 15:08:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=RGi5AzZp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 8C7088450846; Wed, 20 Sep 2023 10:02:29 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235024AbjITRC1 (ORCPT + 99 others); Wed, 20 Sep 2023 13:02:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234588AbjITRCZ (ORCPT ); Wed, 20 Sep 2023 13:02:25 -0400 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2EE399 for ; Wed, 20 Sep 2023 10:02:19 -0700 (PDT) Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-404314388ceso303495e9.2 for ; Wed, 20 Sep 2023 10:02:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1695229338; x=1695834138; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Jn2Ngd3ukFjoHjH9W9ENbDDoYAtr6LLLpGel78I6ZB0=; b=RGi5AzZpWffU/qw5uYI5RpPeQL/3JEYiUG24PK5yhJIuE85ltNp7jBV778Hm1NE0gD twkRve7nMeRvY8IjSOrD7I/J9cYbO8PZSL7AQ8KOZ45euHN4jXEk5Ey2Xo20MBtj1+h3 UX7tSQFJFfv1AoDnMblpmMe1nnui4Puy+x++THvhdQMAIpPHUHNUn/asg21wlxaqorn/ vdVfQ2aq00baZRSZzh+IZldAYFnSyEzI7vTWbB5CQ55029UuMmGjDzQj+x/YIBRuzlan WzocklUMQeN1BBUXRtch5C1YPHooLdTTmPOxEx8nmTqf1tiuhPYGl8xHjOfAlHC1Lvjx oacw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695229338; x=1695834138; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Jn2Ngd3ukFjoHjH9W9ENbDDoYAtr6LLLpGel78I6ZB0=; b=CC0fVFVYkdbsqmvcxH/I8MebdULyCwUhFD8efXD9omw+szqikwiiDU8dK2ENvAxhy8 8CoIksbfSBwMFx+aIWQpXuxVonYyXGZqqijlbLghs1xBQxVmT6Jf50lHzld8fZf6Z1DI ecNv0T7RSUazElhtucHi7hO+s8G7FkZvBu6oc89Px/G6qA9WS7VVdO/yhUkb1X/1N3bi 4T9gPM7h3JKaI1vhIvlSWIUFme/yZcdzWWvqzBVk7S3aSrEnU1XyqNHh0NRTe7KhuSNa PahA107MfIUUxspsKyoxmSJ7RCQuuuaJtAOYKba43GC2RpFpYNj/EJaa4qaRVcCKtMk3 lQrQ== X-Gm-Message-State: AOJu0YxSkOyNso8nVD0MULzKJclSTkJDKKn9wsrBanSnlpFuyo4TGKN9 EqE/Kdo8YRvYdCwfcA53oexuqA== X-Received: by 2002:a7b:cbc5:0:b0:402:ee72:2314 with SMTP id n5-20020a7bcbc5000000b00402ee722314mr2918067wmi.3.1695229338096; Wed, 20 Sep 2023 10:02:18 -0700 (PDT) Received: from arrakeen.starnux.net ([2a01:e0a:982:cbb0:8261:5fff:fe11:bdda]) by smtp.gmail.com with ESMTPSA id 9-20020a05600c248900b003fee849df23sm2441693wms.22.2023.09.20.10.02.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Sep 2023 10:02:17 -0700 (PDT) From: Neil Armstrong To: andrzej.hajda@intel.com, AngeloGioacchino Del Regno Cc: rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@gmail.com, daniel@ffwll.ch, ulf.hansson@linaro.org, victor.liu@nxp.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel@collabora.com, ehristev@collabora.com, wenst@chromium.org In-Reply-To: <20230920082727.57729-1-angelogioacchino.delregno@collabora.com> References: <20230920082727.57729-1-angelogioacchino.delregno@collabora.com> Subject: Re: [PATCH v2] drm/bridge: panel: Fix device link for DRM_BRIDGE_ATTACH_NO_CONNECTOR Message-Id: <169522933708.2429100.2452577965890146025.b4-ty@linaro.org> Date: Wed, 20 Sep 2023 19:02:17 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12.3 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 20 Sep 2023 10:02:29 -0700 (PDT) Hi, On Wed, 20 Sep 2023 10:27:27 +0200, AngeloGioacchino Del Regno wrote: > When external bridges are attached with DRM_BRIDGE_ATTACH_NO_CONNECTOR, > the panel bridge may also get the same flag, but in the .attach() > callback for the panel bridge a device link is added only when this > flag is not present; To make things worse, the .detach() callback > tries to delete the device link unconditionally and without checking > if it was created in the first place, crashing the kernel with a NULL > pointer kernel panic upon calling panel_bridge_detach(). > > [...] Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/1] drm/bridge: panel: Fix device link for DRM_BRIDGE_ATTACH_NO_CONNECTOR https://cgit.freedesktop.org/drm/drm-misc/commit/?id=887878014534186cc50dbd16a62e744ad217b4b1 -- Neil