Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Wed, 20 Sep 2023 16:54:45 -0400
From:   Rodrigo Vivi <rodrigo.vivi@intel.com>
To:     Justin Stitt <justinstitt@google.com>
CC:     Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        David Airlie <airlied@gmail.com>,
        "Daniel Vetter" <daniel@ffwll.ch>,
        <intel-gfx@lists.freedesktop.org>,
        <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        <linux-hardening@vger.kernel.org>
Subject: Re: [PATCH v2] drm/i915: refactor deprecated strncpy
Message-ID: <ZQtcFQuPkiO6aS3O@intel.com>
References: <20230919-strncpy-drivers-gpu-drm-i915-gem-selftests-mock_context-c-v2-1-0b5778423bd7@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230919-strncpy-drivers-gpu-drm-i915-gem-selftests-mock_context-c-v2-1-0b5778423bd7@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5z0jZ7gI3FWlNBieUXjc4OmvSqfin59zpZndfhNcJ3/iplE0twvWoFT34qXk?=
 =?us-ascii?Q?0SjHkgMcLOjZyYxy9lJVeGhZkGGoUoMj+GUi9OHomltKkU7Aw9lrraiTAOGZ?=
 =?us-ascii?Q?dSy5PxqAciXFaAtVyAYbAz1bXWyO6la5PCwOPEyGMIa4G0KykhzFIBSsJr0g?=
 =?us-ascii?Q?wDVvaicDwLEKwVPW6NegTEpcS0zIJqoLEECwciZrMWONkHRIaNgcmszRBTxW?=
 =?us-ascii?Q?L/+BDWsND/QJOZxiVCTNE+Y9c/h9CGgosr+H9FRey4pAaaU0W/z3kAl1N9o/?=
 =?us-ascii?Q?0M0t3x85sMvuzwMt6ZmnB5FLMlJs6WfTfpJCxkhi2Yux9AMjNElLMAHU5sUU?=
 =?us-ascii?Q?Fp7/YNdLrRvIfPN0eZyQdnKyUENHu7+K1E1i5Kus9wnpFa9iPKEFumn7txcB?=
 =?us-ascii?Q?4JmgyIQ5XrMCupDF9LzSHiOu5uG+1oKOtpBWQEvUzyG3OqK6roqkK+Se+dVR?=
 =?us-ascii?Q?FpUcy7goBv1vE7INcbJIJ08RdgNwGGoRQFZDolO1Q0wrwuSs7NG/gbdQWN4g?=
 =?us-ascii?Q?WUpmkeHqlpfJU6VxhWqAJ7Mwz7ebiyZ9+Yae1mJo9h9DtkRSuwZGGZbZieux?=
 =?us-ascii?Q?w8ftneVsJxs+/VwTsxTcV04hWG+aLVI8/EH0yRShGPpOpEuFhTt+lzbcvrtk?=
 =?us-ascii?Q?tR7yqD4Cv1/Bid2oSAwbFoC8u6J/Nj3oFOoeLiL1+h1P2Z2nGnzYdubmaoex?=
 =?us-ascii?Q?NU9te6l2SgmwhEepYOZJwpWbMif8bqUNjZPWjbUS4SOeWb8SF0nagRPcdYYb?=
 =?us-ascii?Q?T/K6cRVm60GUC/YMaIxFmkK8HKQGcez6c2XgxfVu+NX9DKAh4sK27wMHIzrZ?=
 =?us-ascii?Q?wMpGxl6hz3FrXf046lj9mmsxovcCKU4+x0dxdN2l0Ec8jFYon38RDxzSHOCs?=
 =?us-ascii?Q?SRdyZXLxfhHTImChcogaap7m/0n9R6mTQlejZCZbrZJnlt3vnbKKoWSN5UO1?=
 =?us-ascii?Q?bHb9hU3vX8hU2F45e0owdeyLu1PVsMoD5Z5YaDlnQyai1I3u7osgidywhXNw?=
 =?us-ascii?Q?X1KgRnzdhs7KSJj+zbn+xOgwxCJmj6aqQKOUQtLx3REJVIvMQ0w0tKcrbLnB?=
 =?us-ascii?Q?SPJA47rhQs4o+Q6zh5KWimzwZ7ilk8EyiphdFYBnkeqyNMijDuNlnDJFaomQ?=
 =?us-ascii?Q?kVo4o/AJpMu1tenMKpyAoxVyEW2T90iYSJNpaTl9R7pqE7PVBIcTXB5+kg2O?=
 =?us-ascii?Q?BxMcoMnDm3CXKlkNX0GBVsVqk4TVOknzSlsavIKF4tvrBSFj9WMZO6GzZBwf?=
 =?us-ascii?Q?XMZylPDveEme+ui2B8nxtlkrdrKpfPi3BupouB12waZZ1n/jk8o25fjBJ+Gn?=
 =?us-ascii?Q?SDZnYdJkeBXdpVyvuHAk0ISwtww3R3h3Rv1DcEfikrJSzDKL0GAcI9OD44VU?=
 =?us-ascii?Q?4L5Wn+QaMLgWMx7dlmuauObSOHyVsV8rY/FTQNM9eGil7oUErD0N19Hx9z+E?=
 =?us-ascii?Q?JpktTPKWQ/asMXE7aGC98NpWJRVKEEw8LW0efRnoMin53PqDCBgjWYVz4TMx?=
 =?us-ascii?Q?dlwnsqk/I6TtpHvFrK7benzz8nImQcr0yVP1AGsdLlDyCHN9MQ8b1smCQbtD?=
 =?us-ascii?Q?lCJAQCXMzGblJzwD5YqlsLryK/J5JUpK1iqH99hQX9JtjLqMWlAvxEBD7b0Q?=
 =?us-ascii?Q?Tw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ba73884b-9608-47e8-1c45-08dbba1bd50b
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6059.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2023 20:54:50.6406
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gGl9zqIFsWnG1qNAXPonUfbdEttP+uuTy9BbKlpz2yKA+5Alo82W1H8RVrG1PmS743AOIW54lnw0w3nnskKWpg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7491
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 20 Sep 2023 14:09:53 -0700 (PDT)

On Tue, Sep 19, 2023 at 04:45:31AM +0000, Justin Stitt wrote:
> `strncpy` is deprecated for use on NUL-terminated destination strings [1].
> 
> We should prefer more robust and less ambiguous string interfaces.
> 
> A suitable replacement is `strscpy` [2] due to the fact that it
> guarantees NUL-termination on the destination buffer without
> unnecessarily NUL-padding. `ctx` is zero allocated and as such strncpy's
> NUL-padding behavior was strictly a performance hit which is now
> resolved.
> 
> Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1]
> Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2]
> Link: https://github.com/KSPP/linux/issues/90
> Cc: linux-hardening@vger.kernel.org
> Signed-off-by: Justin Stitt <justinstitt@google.com>
> ---
> Changes in v2:
> - drop the `... - 1` (thanks Kees)
> - Link to v1: https://lore.kernel.org/r/20230914-strncpy-drivers-gpu-drm-i915-gem-selftests-mock_context-c-v1-1-c3f92df942e0@google.com
> ---


Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

and pushing it right now to drm-intel-gt-next

>  drivers/gpu/drm/i915/gem/selftests/mock_context.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/gem/selftests/mock_context.c b/drivers/gpu/drm/i915/gem/selftests/mock_context.c
> index 8ac6726ec16b..e199d7dbb876 100644
> --- a/drivers/gpu/drm/i915/gem/selftests/mock_context.c
> +++ b/drivers/gpu/drm/i915/gem/selftests/mock_context.c
> @@ -36,7 +36,7 @@ mock_context(struct drm_i915_private *i915,
>  	if (name) {
>  		struct i915_ppgtt *ppgtt;
>  
> -		strncpy(ctx->name, name, sizeof(ctx->name) - 1);
> +		strscpy(ctx->name, name, sizeof(ctx->name));
>  
>  		ppgtt = mock_ppgtt(i915, name);
>  		if (!ppgtt)
> 
> ---
> base-commit: 3669558bdf354cd352be955ef2764cde6a9bf5ec
> change-id: 20230914-strncpy-drivers-gpu-drm-i915-gem-selftests-mock_context-c-980c8ecc9142
> 
> Best regards,
> --
> Justin Stitt <justinstitt@google.com>
>