Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp1658812rdb; Wed, 20 Sep 2023 16:06:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IESd9HoxWI8dUU6tslde4dtu5AMGBdBNBbZ+Ktz9y8J+9s6hBTkZBby2vWoizM+k7BEy85q X-Received: by 2002:a05:6358:783:b0:133:428:35dc with SMTP id n3-20020a056358078300b00133042835dcmr4098144rwj.11.1695251181249; Wed, 20 Sep 2023 16:06:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695251181; cv=none; d=google.com; s=arc-20160816; b=BbRHWRVBVTf2J3Znvlb/FUcmnU+Rb6AxvjWQSbXBxYNuAH92NQVk5Q6BJHfELhWq35 tCvv0ek9DNjVr85OkeRcIYNBemytBxJKeLELbv2HiX665DCJ13yVnq+hPzx9gKTOi9wq NHbU7nlYLlhlL2cpOF1+YIaJrIwEPbjxw4kNXBWn3PO3UOnFlUW+LTd8d1oXzJQgRFlk QQvRbJP38j7feiliM/Gry+VycfwN0GaMMK8+r71lnazYNfARDvd75T5ZPSD61f37oWEN gOtOLAxzjj3YAvwxKoTWy33F2eb0nJsHjIH2XlaXaLrL7rwInvi8xbCzdQVXWEsD30qM zmyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=YRuJsY73C8doQ4cNf1LjL+UhEmqmPUGsnMHO5Imx8so=; fh=OD+En00ZpISzDwkWN3URDywNyrUks6oiJLa2I0hfgJQ=; b=WNcN47phpsea4bq4Q/F6bo3ghbtHhZLhyRbR0C34C7gDVZjL9AKEorGbpNTwCcXJCC 2HFFXQvudqIb1wm7XUbPqcRmnlo36vEB7ks/z6VR7Td/okNmxAKrGcUDrTJmP377DXWN Qv/ZBJAc5WtD24Q/tOkQFz03cf71kNDMIhCMhAoaVhnr171evHhAtenGqxz3xH4g55Gx EioO2zz5tPSA1kPGNG4HPnxliLT7ns9YlT/+SO2XCcNw/TRWw+4HFfsZoIVBUilYyrgk san3sly6dlRKj9l+PhJVJ6qMWOT4AaT4twc8lHkYEyEjqbpDcnJ4pq3Sv7hEXRUX1YFx +uSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=dKI2cRha; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id a18-20020a63d412000000b00569561773a6si78587pgh.549.2023.09.20.16.06.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Sep 2023 16:06:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=dKI2cRha; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id B244A80AFEB7; Wed, 20 Sep 2023 09:56:02 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234588AbjITQ4B (ORCPT + 99 others); Wed, 20 Sep 2023 12:56:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234174AbjITQ4A (ORCPT ); Wed, 20 Sep 2023 12:56:00 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 772ED9F; Wed, 20 Sep 2023 09:55:54 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 209A121E17; Wed, 20 Sep 2023 16:55:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1695228953; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YRuJsY73C8doQ4cNf1LjL+UhEmqmPUGsnMHO5Imx8so=; b=dKI2cRhasOtnaSBCgHjLyUopF0KNuF+cPl+ufz4nGgCod/Sl8Ub2LjKkQ0FAvxJdjnvDmg loN3fdV7iY3W0HfKtQ7/3pa0ZqYapkZuE1Akp8EzbDWK39Heez0rwJ3Xg9iHYJwzuTCz4H 64/c3qT/xH5HCj7WJ3OK6gSwbOE1Hek= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E8EDA1333E; Wed, 20 Sep 2023 16:55:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id KbyzNBgkC2V7dQAAMHmgww (envelope-from ); Wed, 20 Sep 2023 16:55:52 +0000 Date: Wed, 20 Sep 2023 18:55:52 +0200 From: Michal Hocko To: Shakeel Butt Cc: Jeremi Piotrowski , Johannes Weiner , Roman Gushchin , Muchun Song , Greg Kroah-Hartman , stable@vger.kernel.org, patches@lists.linux.dev, Tejun Heo , Andrew Morton , linux-kernel@vger.kernel.org, regressions@lists.linux.dev, mathieu.tortuyaux@gmail.com Subject: Re: [REGRESSION] Re: [PATCH 6.1 033/219] memcg: drop kmem.limit_in_bytes Message-ID: References: <20230917191040.964416434@linuxfoundation.org> <20230917191042.204185566@linuxfoundation.org> <20230920081101.GA12096@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <101987a1-b1ab-429d-af03-b6bdf6216474@linux.microsoft.com> <4eb47d6a-b127-4aad-af30-896c3b9505b4@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 20 Sep 2023 09:56:02 -0700 (PDT) On Wed 20-09-23 08:32:42, Shakeel Butt wrote: > Also I don't think reverting 58056f77502f would give any benefit. Not reverting 58056f77502f would re-introduce the regression in some non-patched versions of Docker runtimes which cannot handle ENOTSUPP. So I think we need to revert both or none of them. I would prefer the later (option 1) as the fix is trivial but I do understand headache of chasing all those outdated deployments or vendor code forks. -- Michal Hocko SUSE Labs