Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Wed, 20 Sep 2023 17:39:48 -0400
From:   Frank Li <Frank.li@nxp.com>
To:     manivannan.sadhasivam@linaro.org
Cc:     aisheng.dong@nxp.com, bhelgaas@google.com,
        devicetree@vger.kernel.org, festevam@gmail.com,
        imx@lists.linux.dev, jdmason@kudzu.us, kernel@pengutronix.de,
        kishon@kernel.org, kw@linux.com,
        linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
        linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
        lorenzo.pieralisi@arm.com, lpieralisi@kernel.org, maz@kernel.org,
        s.hauer@pengutronix.de, shawnguo@kernel.org, tglx@linutronix.de
Subject: Re: [PATCH v2 0/5] Add RC-to-EP doorbell with platform MSI controller
Message-ID: <ZQtmpL2vCMgR+Upu@lizhi-Precision-Tower-5810>
References: <20230911220920.1817033-1-Frank.Li@nxp.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230911220920.1817033-1-Frank.Li@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K2FtaHpEdjRYWVZ4TjZxeVlYMUdaRjkxdG40RC9KUEJxMDhyeUhSVCtrSlYz?=
 =?utf-8?B?OXdHR1BINlhUM3RpR1Zna0lLOUUwa1c0RlZ6V25Kay9zalBJR2ZTaXhlUVdB?=
 =?utf-8?B?MVlYTUQ5K0RmRlMrbEYySXZhQmQzZmJCME8xZTlPSlJJdU9BSDFRVzlJdTZC?=
 =?utf-8?B?M0QxNUtraldTK2JVWkFPcExwVzlmV3VTVkNCdTVmUDF4N3RUV01nR3B2dHE2?=
 =?utf-8?B?VnN3Q1JQV0hHS29iNFdIYXVpRGRPMUtSUnlEZEZFSHNpWll3MzVpRkNVdlV4?=
 =?utf-8?B?TWJpbGRUT2FhTVJmT1VhU2pySmJtOWVBMHBDcTR6MTd3bW01a2duWGNmMlZQ?=
 =?utf-8?B?WUtZZldvaGU5NmpIYVBidUQ4SkszYm9HWnNYOHpEV2lCOGhrbjZJOXlHcVZo?=
 =?utf-8?B?UE1NLzB5MmVLZ0lsNWNHK1NPbXd4WXdkK1pVRXZ1aW84VnlvRXB5WEc5U0pk?=
 =?utf-8?B?T1NvczVYbGRhSm4za2RPb2FPTEdXK1VQNjkxSDNYWWQ2ZjVIWm5rNXNuTHB2?=
 =?utf-8?B?eTZEaExVNEFyNC9TUWJxbVNtVVZZUFRFNXFmbXdJUDBTL0ZxSkNSc2JTbk9n?=
 =?utf-8?B?L0QvbkFZZkZDU2NUNTRRek9xempLZlRuKzYyZjBHN1QrUjV4SGZuZm9OTmQ1?=
 =?utf-8?B?NlJwZHVlRW9ycnNWRlc4QWpsN09MSHE1UDlhbzZ3SmV3TDlicGY1K2pSVkdI?=
 =?utf-8?B?dUtUYXo1NDQxOFBHTlY0UXZ3eVdyU2pFMkFxU1FSYVRUTkxMNW1YdHlxY3l4?=
 =?utf-8?B?UThJeTdXa2hEQkZ5cWVhYllGVDNQTFRldWxlYmd1VG4xdmVaU0JIK0s5V1dG?=
 =?utf-8?B?dDJhaEZ6NFgrTG02cWVialNyOHhxSlpLc3Z2OEpJMFEyS0lIaFFvUklaMlc2?=
 =?utf-8?B?UnozWlJUemJzZy9vc0hZckg4UU5LV3hvZHUrTVh6aiszTnZya1ZtNjBrdmpl?=
 =?utf-8?B?WXRDR2xoOUNuVWNqM2c4VmVKdE1xb0hLODkwNHRGbSs4endvaVhnaHQ4Wkhz?=
 =?utf-8?B?YTVSWkFpN0JnTXJhcmRzSUhVTGZ0S2prK1R1ckE1WkpHZmlDK1RwbEExQ1Z2?=
 =?utf-8?B?dWMrd0VSWEFyaHc4dnlVc0ZDSXF3NTlUZWpDRVBBOE11a25wa1NyQXlQUGZ1?=
 =?utf-8?B?TUQ2VkRxTVlJVGQ1dW5VMlNjaUsxdVl6L0dtOEg0R2NFeGh2bENrSGhlUEVj?=
 =?utf-8?B?VjJOcm01REN5NysrWkVYcWhTOHFPMjVnRFpnWUdhdTNMSHVKenJGMnp4dXhV?=
 =?utf-8?B?T1NiOGJoUngrSlRHQmYycGRTYnZ4L0F3RGUwQkoxNFJyU1VrekdMMk1QK0My?=
 =?utf-8?B?TzNQSjdnVFZCNW1oMVJ5Q0t4TFpSeFV3UzZXL1lvVHF6WllyNFo0bGpmMmdH?=
 =?utf-8?B?cFl4ZmpMNktmWCtJR2lzT3cwSEs1YXdlNGYrUmErOURocHZIZzdldFNRSUJi?=
 =?utf-8?B?MmhtZ0ZYSjBoVzBZeVNxamF0bDI3RlJMNEVCRDhJY2lIS0FZbkJCN0ltZFIv?=
 =?utf-8?B?YVZTemhtK3U4TFhHSWVnMlNQUmMxdjRta25UTjZLR2pOd1djVGJ4cXJweHNJ?=
 =?utf-8?B?YlkxQ1NiNlV6ZGhvN2IyODBUNForOWttYnlMckthdkdZU1lZRU9SSVNnRDZV?=
 =?utf-8?B?M0dmZ1ZNdVFKL3AvNFJsWDEvL2NWTUhYMm9ETFBySStQZmNaZnRPYWRrcnlF?=
 =?utf-8?B?di9GZExjRHFVWDlhbkErYmJ1emNwSENXZ01iREkvMlBJYnoyUmNXTFBtcFlo?=
 =?utf-8?B?VUxmbmZ3d2dQWDJZNlBxQ1U4SlFldHNMS01xaFBnZGpNWnNHQTAzN2U2QVBX?=
 =?utf-8?B?U051R3NmT3F4ZlVZUWl2NlF0U2NyMTZDeWNCaU9QTmdSd3FqaGpvdDBnbkNa?=
 =?utf-8?B?Q1BONEVsSHBQQndEbTdES0o5aHBOQXRmYmxnZFFFWHk2ajJXWll0K0UzMlk2?=
 =?utf-8?B?dmJqVDQ1dUJzOFpWNW9pWHRzQ3JCWjBsbzk1L2NEQ2RSYlQ0dVZLN3ZpbUxS?=
 =?utf-8?B?VHordFFDWG16Q3ppS3kxMTlMZm1GRVNTVTJsQXU3SEErZlZMUWd4V05tTERk?=
 =?utf-8?B?d1gvcVFOcUpoVVVpd0psN3ZtZmpKeXRHRzcxT0R5SDgvSHNsaGxtSFVXQi9v?=
 =?utf-8?Q?ieAPog6kYVOrELXZgXlAk5zhT?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a0919d92-ae04-4342-15be-08dbba2223f3
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2023 21:39:59.9282
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kIpEl9sd4DYMFSr/kvSHIs/5sA73Gr1yXHUBPVUbBOaqPA6oetlOr6yzB0BPBhH86VJLM0k+izstLqgOaFl3FQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7158
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 20 Sep 2023 14:40:15 -0700 (PDT)

On Mon, Sep 11, 2023 at 06:09:15PM -0400, Frank Li wrote:
> ┌────────────┐   ┌───────────────────────────────────┐   ┌────────────────┐
> │            │   │                                   │   │                │
> │            │   │ PCI Endpoint                      │   │ PCI Host       │
> │            │   │                                   │   │                │
> │            │◄──┤ 1.platform_msi_domain_alloc_irqs()│   │                │
> │            │   │                                   │   │                │
> │ MSI        ├──►│ 2.write_msi_msg()                 ├──►├─BAR<n>         │
> │ Controller │   │   update doorbell register address│   │                │
> │            │   │   for BAR                         │   │                │
> │            │   │                                   │   │ 3. Write BAR<n>│
> │            │◄──┼───────────────────────────────────┼───┤                │
> │            │   │                                   │   │                │
> │            ├──►│ 4.Irq Handle                      │   │                │
> │            │   │                                   │   │                │
> │            │   │                                   │   │                │
> └────────────┘   └───────────────────────────────────┘   └────────────────┘

@mani:
	Do you have chance to review this patch again?

Frank

> 
> This patches based on old https://lore.kernel.org/imx/20221124055036.1630573-1-Frank.Li@nxp.com/
> 
> Original patch only target to vntb driver. But actually it is common
> method.
> 
> This patches add new API to pci-epf-core, so any EP driver can use it.
> 
> The key point is comments from Thomas Gleixner, who suggest use new
> PCI/IMS. But arm platform change still not be merged yet.
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git devmsi-v2-arm
> 
> So I still use existed method implement RC to EP doorbell.
> 
> If Thomas Gleixner want to continue work on devmsi-v2-arm, I can help test
> and update this patch.
> 
> Change from v1 to v2
> - Add missed patch for endpont/pci-epf-test.c
> - Move alloc and free to epc driver from epf.
> - Provide general help function for EPC driver to alloc platform msi irq.
> - Fixed manivannan's comments.
> 
> Frank Li (5):
>   PCI: endpoint: Add RC-to-EP doorbell support using platform MSI
>     controller
>   PCI: dwc: add doorbell support by use MSI controller
>   PCI: endpoint: pci-epf-test: add doorbell test
>   misc: pci_endpoint_test: Add doorbell test case
>   tools: PCI: Add 'B' option for test doorbell
> 
>  drivers/misc/pci_endpoint_test.c              |  48 +++++
>  .../pci/controller/dwc/pcie-designware-ep.c   |   2 +
>  drivers/pci/endpoint/functions/pci-epf-test.c |  59 +++++-
>  drivers/pci/endpoint/pci-epc-core.c           | 192 ++++++++++++++++++
>  drivers/pci/endpoint/pci-epf-core.c           |  44 ++++
>  include/linux/pci-epc.h                       |   6 +
>  include/linux/pci-epf.h                       |   7 +
>  include/uapi/linux/pcitest.h                  |   1 +
>  tools/pci/pcitest.c                           |  16 +-
>  9 files changed, 373 insertions(+), 2 deletions(-)
> 
> -- 
> 2.34.1
>