Date: Fri, 9 Nov 2007 13:01:56 -0500
From: Chris Mason <chris.mason@oracle.com>
To: Zach Brown <zach.brown@oracle.com>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>,
       Peter Zijlstra <peterz@infradead.org>,
       Jens Axboe <jens.axboe@oracle.com>, linux-kernel@vger.kernel.org,
       akpm@linux-foundation.org, linux-aio@kvack.org
Subject: Re: dio_get_page() lockdep complaints
Message-ID: <20071109130156.4b05a652@think.oraclecorp.com>
In-Reply-To: <47349D66.2040109@oracle.com>
References: <20070419073828.GB20928@kernel.dk>
	<1194627742.6289.175.camel@twins>
	<4734992C.7000408@oracle.com>
	<1194630300.7459.65.camel@heimdal.trondhjem.org>
	<47349D66.2040109@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 911
Lines: 25

On Fri, 09 Nov 2007 09:48:22 -0800
Zach Brown <zach.brown@oracle.com> wrote:

> 
> >> So reiser and NFS need to be fixed.  No?
> > 
> > Actually, it is rather mmap() needs to be fixed.
> 
> Sure, I'm willing to have that demonstrated.  My point was that DIO
> getting the mmap_sem inside i_mutex is currently correct.
> 
> reiserfs, though, seems to be out on a more precarious limb ;).

reiserfs is doing tail packing during the file_release call, which has
lots of advantages for removing complexity in file_write.

Without getting into a huge patch, the best fix would just be switching
to try lock.  If the tail doesn't get packed, the world doesn't end.

-chris
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/