Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
From:   Xiaolei Wang <xiaolei.wang@windriver.com>
To:     peter.chen@kernel.org, pawell@cadence.com, pavel@denx.de,
        rogerq@kernel.org, gregkh@linuxfoundation.org
Cc:     linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3] usb: cdns3: Modify the return value of cdns_set_active () to void when CONFIG_PM_SLEEP is disabled
Date:   Wed, 20 Sep 2023 22:40:45 +0800
Message-Id: <20230920144045.2165758-1-xiaolei.wang@windriver.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rhOPij7ZucAMQvHpiZJ5pXJCrMQ5ZR1jLrIF/c77V1lxW9MmxRtsYwHh2yGi?=
 =?us-ascii?Q?Ha9+9NWmZgQ865YgrOOHjw7g8EsPTA+4b2WpTjRc1FpTQWFhF+BSfeQPYTlF?=
 =?us-ascii?Q?anKXKdHBasz25rTo7haQ8LXsA04e2Dyb1JIhb4mkJIw3bAMLnSDHuqNGLRTL?=
 =?us-ascii?Q?8QBWO2gzQsoa/xmKWwelzZfwkmJPL5RAS5DKrjc4J5+ErZ35DYOIW/huH82O?=
 =?us-ascii?Q?D4uuUjLx78Mp4qXJ1hXE/iKZbynu2QJ+mLSUEWsmFQiImlgCrWNlqysUrfsd?=
 =?us-ascii?Q?0Ad/EbcKoa9GgzFrQvIOU8DMqccCUJUztdCXDAIZoKeShbqxNvry4Xb6so+M?=
 =?us-ascii?Q?4BnUWfPuO1HfdgUINiIZJ0XpJHoTv4FD2SObmSiqtpOT7RVYZYZMSTINfRYR?=
 =?us-ascii?Q?cVbznGls6VtWtYdBCAyonNWkoM63YPqbbmSkFjFNMs13+A++BjwfB9hsrzWG?=
 =?us-ascii?Q?ID5Ygzyf6hJmniSrsf9rN6UhDrwvrWqaUMtCfUVwhV2O4wdELk1TTHupUDhl?=
 =?us-ascii?Q?fTSdLheJpTFW9n0SbIPuoDN9m2Vk0iEW8pWE4nNwlf+DfmULsJe4dmNlRC7o?=
 =?us-ascii?Q?guHXWogQ4BWI4VWnFBEegob8Y0Xr20IuWfqvQyCzWt2/ICT8yzaC8eaFwEZO?=
 =?us-ascii?Q?3AoQyaXeRmnboy9936fy1XUfEFVBdz0zJuB7tPnlgjdOg0tPtgJbg+IaFgWU?=
 =?us-ascii?Q?5eH6ROl2HY40E6uD3OuSXygxgX1McHSFR1y+sCz+hcYfEDdQGRKvd5hVPa1M?=
 =?us-ascii?Q?RcxqcqoQxKN4xCJjQaYkvl/evOV+/guGTGunhiyz1mWVyUf382efYQs3BLrr?=
 =?us-ascii?Q?27xG9uhh/OBuihmPPtQk324nSNmdifX1GUPsz/Y7eQebl1sj5CYMSiDO0vLg?=
 =?us-ascii?Q?m70uJIIY2/0rF7mMAthJqTGX+t2QdKFeAkTywdMd4/9dOKufQYP4BGxBrijt?=
 =?us-ascii?Q?LKEyCf0Yw8/zIt/m1/mEKaP/P2ARngaFmlFUZjnK9Sn+vOOXhriV0xtp5b+a?=
 =?us-ascii?Q?tSSWMFHsId+cu6Qbct1vyAa6cubn8C+CGYZETZ0vCQAeSOCf++N7RHQ4qzJf?=
 =?us-ascii?Q?Z4nflEDsUf78LKsHAC7ftMbW9y7SfA+U0pj4iZLaN+Qmh/3Hb9CZO1rxl1q8?=
 =?us-ascii?Q?d+alQHIzG/XuDTQfH+bkGnqBl8pBdcyX3FyqKuQCiWVtzifZXFrswPB+q82X?=
 =?us-ascii?Q?KqSXv3RCb4clqRE4oXvyD/yXd6bOtCn3V49oXukIvaLJBy1WZJVM80l4hOmN?=
 =?us-ascii?Q?B6mgHOj3twbHQXlwdtrOGHx0GhxA+Eh9KJM8rtg8EMbA7XCRNqXatrihdIUn?=
 =?us-ascii?Q?ps3f1ZZWcoKkdDY72DLD23oPmfoX/R79rZJO0l4CK9ujR13q3zvmuFfULrLN?=
 =?us-ascii?Q?jjpgd66lZlcXas8xh94ViUr2rDqKIEKftkQMg15YYy3Z5Rq0g1xoeNcRjWN8?=
 =?us-ascii?Q?CW7bV8IOcAMQdCe53lGFFuUVZhtxV4eliCAC6Z/Hlhboy7dXD+Huj/c5H6gw?=
 =?us-ascii?Q?pGa1Ff2itOoh05mQI+u6eZKlGoPb10xnV6fbcAXKxac5vbBcjNT9BEONsUEI?=
 =?us-ascii?Q?KHDYADGri5DmBv9GyXGAi4bnoBV8/TagD8ir99RwGemTR3cjl9LnbgfBAhZd?=
 =?us-ascii?Q?lg=3D=3D?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ad71d8ab-2926-4a73-1711-08dbb9e7a392
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5764.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2023 14:41:13.8990
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UbR43QQcsLPGbsNwOpe4Nde6JS95qs+RYYU6itF3OxIc3WzzMo4eheos9uij6Or2IK8p+q05DUaT7nXk3oTBRvojhyvuKLpqrSvagOSspFI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6445
X-Proofpoint-GUID: 8N2KYWSfZbpgsNGN9-zLxniDc_zUEWNm
X-Proofpoint-ORIG-GUID: 8N2KYWSfZbpgsNGN9-zLxniDc_zUEWNm
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.601,FMLib:17.11.176.26
 definitions=2023-09-20_05,2023-09-20_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=666
 priorityscore=1501 lowpriorityscore=0 mlxscore=0 spamscore=0 adultscore=0
 suspectscore=0 impostorscore=0 bulkscore=0 clxscore=1015 phishscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.19.0-2308100000 definitions=main-2309200119
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 20 Sep 2023 07:42:47 -0700 (PDT)

The return type of cdns_set_active () is inconsistent
depending on whether CONFIG_PM_SLEEP is enabled, so the
return value is modified to void type.

Reported-by: Pavel Machek <pavel@denx.de>
Closes: https://lore.kernel.org/all/ZP7lIKUzD68XA91j@duo.ucw.cz/
Fixes: 2319b9c87fe2 ("usb: cdns3: Put the cdns set active part outside the spin lock")
Cc: stable@vger.kernel.org
Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
Reviewed-by: Pavel Machek <pavel@denx.de>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
---

Changes in v3:
- Add Cc: stable@vger.kernel.org

---
 drivers/usb/cdns3/core.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/usb/cdns3/core.h b/drivers/usb/cdns3/core.h
index 4a4dbc2c1561..81a9c9d6be08 100644
--- a/drivers/usb/cdns3/core.h
+++ b/drivers/usb/cdns3/core.h
@@ -131,8 +131,7 @@ void cdns_set_active(struct cdns *cdns, u8 set_active);
 #else /* CONFIG_PM_SLEEP */
 static inline int cdns_resume(struct cdns *cdns)
 { return 0; }
-static inline int cdns_set_active(struct cdns *cdns, u8 set_active)
-{ return 0; }
+static inline void cdns_set_active(struct cdns *cdns, u8 set_active) { }
 static inline int cdns_suspend(struct cdns *cdns)
 { return 0; }
 #endif /* CONFIG_PM_SLEEP */
-- 
2.25.1