Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Wed, 20 Sep 2023 09:36:50 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Rik van Riel <riel@surriel.com>
Cc:     Matthew Wilcox <willy@infradead.org>, linux-kernel@vger.kernel.org,
        kernel-team@meta.com, linux-mm@kvack.org,
        akpm@linux-foundation.org, muchun.song@linux.dev, leit@meta.com
Subject: Re: [PATCH 1/2] hugetlbfs: extend hugetlb_vma_lock to private VMAs
Message-ID: <20230920163650.GA4065@monkey>
References: <20230920021811.3095089-1-riel@surriel.com>
 <20230920021811.3095089-2-riel@surriel.com>
 <ZQptrdK69wvJ2NXP@casper.infradead.org>
 <7ddc6ba18b3fef3ed637dcd9a85e90cf4ca6ca7d.camel@surriel.com>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <7ddc6ba18b3fef3ed637dcd9a85e90cf4ca6ca7d.camel@surriel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?/uthZ2Lh4WhcUGS+YwVx2N/UQcjBuuQ6QOQP9jOo9md1IrlMA6OgADWKG9?=
 =?iso-8859-1?Q?HXcal6eFhmj3awxQRCIg39B4sR/Emg7MHl/Uhobw5hCdr105AAi6dL1iqA?=
 =?iso-8859-1?Q?KS2tqUpKb1ZtUjHSslC9eWvJexFJFuPGFSIaNBH+7JdIJrDGv9ucG6vHUz?=
 =?iso-8859-1?Q?Y68T0etlsA/ef6i4VZQ2c3kiD9o0iZV+5LJIi4mYF41tLookbLbHo1wnOO?=
 =?iso-8859-1?Q?6jS13ruMRgcW5UJAWg9RTrYNIdauFRdN4u9dTclFWOIwEL/8O2q5w01YFV?=
 =?iso-8859-1?Q?/25XE6G2JNLz/ZU3uBaxGd8q/W1IrZGtWgcHry6YfvKOD+NtcpAf3nA6lG?=
 =?iso-8859-1?Q?bp9KGX+cKuPOF/fSJhy84a5Qwr6vLTWOCQFwlTx+Ac3VH/s/qo0G7lLfym?=
 =?iso-8859-1?Q?xN2Lk0H4IEtc2bt1Htns0jEi1LqE4uHjbKXvtOIOwBUSajoRmGUE/Zw2c5?=
 =?iso-8859-1?Q?9yjdk4CQs9XYpAqGE3B0PK1TGgtvj1ZSzpS2VrPWLINeQBdC+B+lJHaqLe?=
 =?iso-8859-1?Q?U1Y1QBy+cr0IFUVZEjp+j4e30bG5jdNgry1TnaAUBwtZd5abFHoiL/hUmg?=
 =?iso-8859-1?Q?Cp6b12EDQDojjNfdVSBjZy13kv7ZGQ4qD7CA05L1ijk+TUH2fTLah2nZ7b?=
 =?iso-8859-1?Q?+SOnJBXL/Pg8kPtCwqX4iBvGUV1wO7vSQQJWtMHrnTmInaXSOf8Ue9l9UF?=
 =?iso-8859-1?Q?j301cIuUpn3meXOMJ8jd054V6a6Bym0PuUZCj1osMcw+s3JHw/5u1NdpLE?=
 =?iso-8859-1?Q?0fJRf+o2E35Mr4N2J3XcgPWlhGJpGc3e/cRnZrtlfeLQ+ihmuQmSyUGQTX?=
 =?iso-8859-1?Q?PY+YP5MZ6Murf4pbJbJZLeMp60Cdqctm3U3H4dA1Gn5K9SgjCI2MSD7RfM?=
 =?iso-8859-1?Q?c6lFFZf4gc/mgJL7+eB7IGCqVZh1HjCUViHU9XuAckz8knrCJgaPPy7ZfO?=
 =?iso-8859-1?Q?6g0RAz7DME4ruL/e8DIKdR2Sbg4NFpudyBbKAaTg/DsKZVZnCquKh/j7Gy?=
 =?iso-8859-1?Q?pkRAjCwij9HgEotZXZfMbUB0KZg4bdq67BcULkkuxgmXOPbsPHbANwGr3d?=
 =?iso-8859-1?Q?zjvNrCtQGbiJ+bshNc3OONrlTYirGXfmo/Qw9LlQjPCz54feyMPKyEpXfZ?=
 =?iso-8859-1?Q?c3GYAoOF2Ca6B5ItQ6VXYB3iqCIC+ucGefncrFSvLxAOktWFk+XgdLj6Bz?=
 =?iso-8859-1?Q?0mzX1pU7lpdf9Dwib3xk+OABv31FIKNwU1zNfpgxdELCMyQZ0VILrblZkA?=
 =?iso-8859-1?Q?KbhqgpvVnaief86Z1ETqYFe2tx9dL21Mp95pKtFblW9XR4jq6la6G4UN+O?=
 =?iso-8859-1?Q?9vbEm4WALJFkaTHJTang/UfEa3IFTCW23cjMIDAZ/flg+8U6SRUvenWssb?=
 =?iso-8859-1?Q?wjFkU/Dv6hV+GyWTLQ2t2bGO6AOTnGt5CkBBqDRmqqAa9NWZ1BSsPDSFB6?=
 =?iso-8859-1?Q?LoeQIVtSWmXoa2A5DeXi45PpwPcmFU49ZGTxsdaePkcxRHBRnusa6r0HAe?=
 =?iso-8859-1?Q?ZlwspR/sa38AL675DqERr0+V0ay7+PNR/Imdr9XKvBp+9aeNE9KvMwJpjp?=
 =?iso-8859-1?Q?lmkcZanRy6CFMkLnugkEyX9qjfAsLU7pRAViseSK5a85pWUxwb86wvPRsr?=
 =?iso-8859-1?Q?DXrTjPXjC+b5br2zijGhfYm7x2Ri+kWOuX?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?iso-8859-1?Q?ZEKLuCixqjHVMhohxrvaxA1oYUZ+WcYGc6v1GHl7dUy6ZkQFgi78zMwVem?=
 =?iso-8859-1?Q?WdpMb4Itt0+HBjG7nSIp0c+aVhQnEySZjAtLZ/So+A2CmqPpvoMJunNlrA?=
 =?iso-8859-1?Q?AckuhHTAvzTBwvmswcvC0OxNq81E23zcQi/+aB9o56IvxTsBai4dgefYTE?=
 =?iso-8859-1?Q?ddEhMwwEf27MLsQ7p07jNsuVf+2l6ORPIRYFntQHGVybFLYu5geF+K92ro?=
 =?iso-8859-1?Q?fgSsei4bSYw4eLmEBre6a/ZfADVQu8BnUL8dgUZr7AeUJ4ZLtGTcYPh+Gt?=
 =?iso-8859-1?Q?QiYFj+3etMoMQ2VpCAgLN1BjKPlif2cfYRCqIeY4qEVfc/6pcOtg85Mf9m?=
 =?iso-8859-1?Q?zvazjyBikEXcuM8G/1j2sR4OiE+YhNrQd/QbPjI73UQyA4c4cIYbY77Ygl?=
 =?iso-8859-1?Q?Tzf3g2J/hgoTkHzdIWRl+I7N1qJX2cvCwXJEJf1r2Wk6CEF2qsmWe2Omjb?=
 =?iso-8859-1?Q?5c0UNf1+aALlVXI4UPvW6IcsQodI+xy/DWNJ83CqBLcu06yD0SOCelcA+C?=
 =?iso-8859-1?Q?t5Vke2DlUehzqsxAB+GgeUJdt8CcPBEeeNfPGQVogzi4idT2s9VpZnYS8C?=
 =?iso-8859-1?Q?Y9O5mUknAgmVe/QCgl1iGo7Kz/ifMKOwskrsnJnDLVjZffIYesN9uCtKZn?=
 =?iso-8859-1?Q?OKLKTPXaf0bBfJi5lhFRx0HthyDx4jIoPk1s1+HRRBUCT7U1+3ov1lWX7W?=
 =?iso-8859-1?Q?lnJInGZ9L/0dqy0/XRd7dR0OsheiLdU9aOR9mP1sQT0oNMeAPYUDOkQZl1?=
 =?iso-8859-1?Q?GcApDzkDA7wFL9xvxOIOk4sh0SHttwfiBLyY1s0Sx2554re0blE60o4CLD?=
 =?iso-8859-1?Q?N1dN5omvTVphC/2q3BnjHb+abQ+YF6nqUIJU0SeNBuIcw91Txy04do3AL1?=
 =?iso-8859-1?Q?uPEVbP2jimHdmpBRF+JQ5AnKmu83T3mP1qPjoCcCpI/d0C++rmRMQa2+Jr?=
 =?iso-8859-1?Q?CNiKm1Skk7SRhT7SfgO9g8Y+IId5pQhVeeaDQ8vSeL2ne/0testWdg=3D?=
 =?iso-8859-1?Q?=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9e0307a7-03f6-4128-3683-08dbb9f7cc3f
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2023 16:36:53.9711
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TIWecJ5tp8qU5cA8Ss+OD1tzATklC/D0Ys9TtbuHT5CBgxNfoXg9VGfDNR89BnL0Dyibnv1zSWlxxbOVPNL3Fg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR10MB7918
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.601,FMLib:17.11.176.26
 definitions=2023-09-20_06,2023-09-20_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0
 malwarescore=0 adultscore=0 phishscore=0 bulkscore=0 mlxscore=0
 mlxlogscore=813 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2308100000 definitions=main-2309200136
X-Proofpoint-ORIG-GUID: c7mwLSQzor3fgLot-z3nQap64LOPSrEU
X-Proofpoint-GUID: c7mwLSQzor3fgLot-z3nQap64LOPSrEU
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 20 Sep 2023 09:37:39 -0700 (PDT)

On 09/20/23 00:09, Rik van Riel wrote:
> On Wed, 2023-09-20 at 04:57 +0100, Matthew Wilcox wrote:
> > On Tue, Sep 19, 2023 at 10:16:09PM -0400, riel@surriel.com?wrote:
> > > From: Rik van Riel <riel@surriel.com>
> > > 
> > > Extend the locking scheme used to protect shared hugetlb mappings
> > > from truncate vs page fault races, in order to protect private
> > > hugetlb mappings (with resv_map) against MADV_DONTNEED.
> > > 
> > > Add a read-write semaphore to the resv_map data structure, and
> > > use that from the hugetlb_vma_(un)lock_* functions, in preparation
> > > for closing the race between MADV_DONTNEED and page faults.
> > 
> > This feels an awful lot like the invalidate_lock in struct
> > address_space
> > which was recently added by Jan Kara.
> > 
> Indeed it does.
> 
> It might be even nicer if we could replace the hugetlb_vma_lock
> special logic with the invalidate_lock for hugetlbfs.
> 
> Mike, can you think of any reason why the hugetlb_vma_lock logic
> should not be replaced with the invalidate_lock?
> 
> If not, I'd be happy to implement that.
> 

Sorry Rik,

I have some other things that need immediate attention and have not had a
chance to take a close look here.  I'll take a closer look later (my) today
or tomorrow.
-- 
Mike Kravetz