Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp1835742rdb; Thu, 21 Sep 2023 00:20:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEgj4l9c+u/I50+Y1QMvVvWBhIG1CbdwjJ5KdfZh02NtrgZ7DsSbFy9ELQfSMD9Hm6l6dSn X-Received: by 2002:a05:6a21:616:b0:14c:40d1:e911 with SMTP id ll22-20020a056a21061600b0014c40d1e911mr3763190pzb.42.1695280839933; Thu, 21 Sep 2023 00:20:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695280839; cv=none; d=google.com; s=arc-20160816; b=twGzh4BN9Eat+MO91+zfui+oerOxUcknqUMer0JfOlKMw9yw9R2sJm6iNrJMidvYj/ 0lQxTnS43nU0X0ftUSQo8gee/3PqoZQuM0M/lxJ5DaieOcfCjorXHOP/aanG+hU7VHbc tpYwoQ+FPijyFZxDBJLNoLPtWGl69Q9ehnKck+rhtBZHpL4X256R4igU0oTCouOdi5VY KpCAWPaYNvAHltK9ifr+AGSqc1S3Vdx7bpbhlLyTcb2jy2Fl6YormkeGkELGgq1fUxsP 3n7zSiRQJnWGQDhZwwxqfBaHTA/SI5MrkZPj6WrQICMyeAhsw/3S/EFxE3EGrClErQIN pAOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:dkim-signature:date; bh=dUzytAnhwgObCiX8I6ziFJCuYWaJ7gTxd1shipbnUp0=; fh=Qn19E/cEraIDMDKozue/IGbaYHowBP6tN+SrNfXOJjk=; b=WrgQTS1tuAd5btqkJyB5Sb0o7cWg0q41nTGzeGJrwcT7mVZglvzeTftq+Ghne6lr9y yY923Ll84r8fzQSuSgQkbGp91rliEWaDXP8TzIlzMO+u4KsRi4xAdnslliou1vYMH3Ty drToox+C3htWED21viLROenFDtZJpQ5MKftY3pbBVRWD2fxidUS8dffy3Tou/8qxGNAi sKLHy8iN/aWMGumMZufzwf5P6ggGp74FV0eBFTvEIpp1N1jU4MjbjdgQGOLBBKe/ooyd FOTaXtOdwISAwepUOm2RtrhhwJrSuugWOK6o+zr2rRsDeJ5preaw6WuG6MU6uJ1jjcEL d80g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=JS1ejar3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id kt5-20020a170903088500b001bc63c38e17si802035plb.244.2023.09.21.00.20.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Sep 2023 00:20:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=JS1ejar3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 4F73081C4AA2; Tue, 19 Sep 2023 13:57:52 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233279AbjISU5x (ORCPT + 99 others); Tue, 19 Sep 2023 16:57:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232805AbjISU5v (ORCPT ); Tue, 19 Sep 2023 16:57:51 -0400 Received: from out-226.mta1.migadu.com (out-226.mta1.migadu.com [95.215.58.226]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF642BD for ; Tue, 19 Sep 2023 13:57:45 -0700 (PDT) Date: Tue, 19 Sep 2023 16:57:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1695157064; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dUzytAnhwgObCiX8I6ziFJCuYWaJ7gTxd1shipbnUp0=; b=JS1ejar30W8c9Fqx1SK6dbp8sGZVX2b3gVWBUe9dgu0FC9HP9e4D1ozUP6gKCcW25iupn1 mb1PJf0ACY4751ApXrL4zlLOtODucGIKhXMYS2RGJGH+SOJ3X0vhbfq33SdZB4pbZJc4uG iBJlhRZPVb9Bcf+MxMy5y2mjCMItG6E= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Dan Carpenter Cc: Kent Overstreet , Brian Foster , linux-bcachefs@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 1/2] bcachefs: acl: Uninitialized variable in bch2_acl_chmod() Message-ID: <20230919205741.j2ttqwksk5ipumjc@moria.home.lan> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 19 Sep 2023 13:57:52 -0700 (PDT) On Fri, Sep 15, 2023 at 03:55:40PM +0300, Dan Carpenter wrote: > The clean up code at the end of the function uses "acl" so it needs > to be initialized to NULL. > > Fixes: 53306e096d91 ("bcachefs: Always check for transaction restarts") > Signed-off-by: Dan Carpenter Thanks, applied