Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756567AbXKIS65 (ORCPT ); Fri, 9 Nov 2007 13:58:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751435AbXKIS6t (ORCPT ); Fri, 9 Nov 2007 13:58:49 -0500 Received: from agminet01.oracle.com ([141.146.126.228]:17122 "EHLO agminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750869AbXKIS6s (ORCPT ); Fri, 9 Nov 2007 13:58:48 -0500 Date: Fri, 9 Nov 2007 13:57:36 -0500 From: Chris Mason To: Chris Mason Cc: Zach Brown , Trond Myklebust , Peter Zijlstra , Jens Axboe , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-aio@kvack.org Subject: Re: dio_get_page() lockdep complaints Message-ID: <20071109135736.04a4346a@think.oraclecorp.com> In-Reply-To: <20071109135327.01bca1d9@think.oraclecorp.com> References: <20070419073828.GB20928@kernel.dk> <1194627742.6289.175.camel@twins> <4734992C.7000408@oracle.com> <1194630300.7459.65.camel@heimdal.trondhjem.org> <47349D66.2040109@oracle.com> <20071109130156.4b05a652@think.oraclecorp.com> <4734A858.2010307@oracle.com> <20071109135327.01bca1d9@think.oraclecorp.com> X-Mailer: Claws Mail 3.0.2 (GTK+ 2.12.0; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 810 Lines: 25 On Fri, 9 Nov 2007 13:53:27 -0500 Chris Mason wrote: > On Fri, 09 Nov 2007 10:35:04 -0800 > Zach Brown wrote: > > > > Without getting into a huge patch, the best fix would just be > > > switching to try lock. If the tail doesn't get packed, the world > > > doesn't end. > > > > So, something like this? > > Reviewed-by: Chris Mason > Ugh, I thought the preallocation was getting freed elsewhere, but it looks like I was wrong. We can't just skip the i_mutex after all, sorry. -chris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/