Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp2017901rdb; Thu, 21 Sep 2023 06:31:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGEnV6twf1A6lVNGjhv/7I+af19F+/4omuwa7PeCn+aOg+fA5uP3PdQ3fQ5yKVHT4GhmI/h X-Received: by 2002:a05:6358:618c:b0:134:ed9b:15a7 with SMTP id w12-20020a056358618c00b00134ed9b15a7mr5560914rww.30.1695303075132; Thu, 21 Sep 2023 06:31:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695303075; cv=none; d=google.com; s=arc-20160816; b=MogCeNVLoLPntfedYa1NAqwUrVrUwfxSz95EJpyRbniagTwUGOmgGjMC8FGEtHBnr/ S1jHSF0hrDy3jkC0KEJyj4wLaiXCgkhDW/hPFqLJjbDfevWtc5cMXk5wFyj/mSU/j+jP YFwOGQcpTiDFg47R4fs1cy+H5K1+tUpErQeN+/raIiD4A/8MDLveSuFlkAEGQoqWSnKH XqyfGcsGvQ+Y2YXYaz4VQHdu0qAYmG0CyVPWHgrgIkcGhl06gYPLboI9kC4+VV2imoKD SCKwiTNrCW7TqseAq/uaLDXcjq9Nck9DJeog+quGBs5xSAqXsqt3CK2u5jmljjBgj+nS gP5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=YLE/ocZi0x861oQuFVNwlX4NFF2oFei3Xl9PzOSuTg0=; fh=5R2ProQr8+UwdsInUiW4VQy+Pzc7BBWtc8/C//aKcgc=; b=l3NFZqGSFk/w5gbkEd7f/90NIYvmhPBIm0SaWfNKjHJZ2/Box00DIu7tsJaGp1eCiC 1ZLXwtSW+GPfsIF8cvTyp78XSjoTzOj0qdF7wLtTwdi9NKLkj2fZo2pALh2RsgJmGcH+ LbUkPIG6bjDVLCN2uXsz2sNYfXJ6qA2vlI8oiixOHmGHjR+9sVGj890ZbQGT6Puab8jH TIWQ8WiMO3bbpBapwY0M8lzOIiZM5opRdmZJBOFQ21/EwC29kPdv6o6RjGG8odwPvOw9 iu0RwBooe4XicW0aHDOHtsRIz7CKMkBA9fvg/rjHELqyWsjbK2mY6I/E0SC2i4dceFs+ rcQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="1lJizZJ/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id r9-20020a634409000000b00563e9d3d78csi1415364pga.422.2023.09.21.06.31.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Sep 2023 06:31:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="1lJizZJ/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 754CD81B4552; Wed, 20 Sep 2023 17:34:00 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229579AbjIUAdB (ORCPT + 99 others); Wed, 20 Sep 2023 20:33:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229478AbjIUAdA (ORCPT ); Wed, 20 Sep 2023 20:33:00 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9127EA3 for ; Wed, 20 Sep 2023 17:32:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=YLE/ocZi0x861oQuFVNwlX4NFF2oFei3Xl9PzOSuTg0=; b=1lJizZJ/Q44dgn1TRWzFFyGV9T Px5r0aDdLdmHdKceo8ZisIHvvw4nSy9OCAd1V6BTtn132d6pQVcnV+tOD2HuArODvA2lhM/cs0z2N jJGHMJW1efGWYnzfW9lZZGLCVUn8PJYXcikux3SkGGpKJ+JmjdDi60b7Skw67bP9MwKsRR04PLiFA /SxiuLWOVrHGjN1xTOVYcn+M5LwkzVgXHy5t+Co6ArEN4fn+dEfvOefuZhjWkf6DGPm6dxfJV6Ozd 3hUfejlcYXHCB/kjjykP22cRGruX6XWByQnxE2xfLdNq4calx6bsK3pg6nb+v6yx6euCgj/1WaVp3 sBUzq/YA==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qj7cl-004Y3z-1H; Thu, 21 Sep 2023 00:32:55 +0000 Date: Wed, 20 Sep 2023 17:32:55 -0700 From: Luis Chamberlain To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/6] params: Use sysfs_emit() to instead of scnprintf() Message-ID: References: <20230912150551.401537-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Luis Chamberlain X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 20 Sep 2023 17:34:00 -0700 (PDT) On Mon, Sep 18, 2023 at 07:57:41PM +0300, Andy Shevchenko wrote: > On Tue, Sep 12, 2023 at 06:05:46PM +0300, Andy Shevchenko wrote: > > Follow the advice of the Documentation/filesystems/sysfs.rst and show() > > should only use sysfs_emit() or sysfs_emit_at() when formatting the > > value to be returned to user space. > > Any comments? What tree were you taretting, looks sane to me. Luis