Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp2160517rdb; Thu, 21 Sep 2023 10:05:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFl249xoCG8a7L7Peu2xefmnnSkxy55zv46HZmfmG/Y6tYYwxWkiBs8QNT/k18BzukzThqk X-Received: by 2002:a17:903:32c4:b0:1c3:f764:8428 with SMTP id i4-20020a17090332c400b001c3f7648428mr7469799plr.0.1695315954723; Thu, 21 Sep 2023 10:05:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695315954; cv=none; d=google.com; s=arc-20160816; b=zb+M+cm922kq4hN7STccQlRjYhTdhQkhGiE39k73cmjjanpgRxj/Sx7J2F1E5Bo7PH IhFC2aCFes60KGlX29S6UdN0EEqbTuKGgjc1bFcGz/eb6aDl/4ORssMk96oHe4hx4j6P HomGDaD6uRfllZAPG+PAe4Jk2+71wVSuxfMNPGW7yaFvsz4/s2NKlZ0cYnzTccI0DyV6 q1Kl7r2Mp6ygcPe//ceoOjWEhk1kO8qtd38NfoP/Xvak2oi4dnfqeeBUNfPPPOQ3/EGI oHy8H2smT0C50F6ArVtsNerj7ApxNwhOKaqHqgLfW2MNn+i3afQGY3Pk//doFvq/aB33 ptOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=kWj1FhXdi/Y0f0UF+VfQSJ5yEqnj91ecs//KLvPtWJg=; fh=1J0y7tkmwg3Lnx9ITiOOCR2nR10e35Q+z4xuTN3MVsw=; b=T6091/h1lHqyPUuclRZHm5G2lRyhgtEIIK+uVKEZj9NGWEzYCPtbw9jFlowgaWFt9G fZMbOwHvinlCnKz9i1IPWIr+D/fO/UY6ngTWlmvqu5nLKo1VB5hOtxzpF1NvLPvPYe28 l6hishpnu/b0o+deAVe6+B3irWovAgpatV7Vyvqe+wxLZWlxowbB59EyBInQfVAO1/9m RK1NFHoinc5iND1GKHFCrabkKgyRo3feSFKr2c53VJthq1SHMbP5WGddCu6dkgAzkZzm BqOZ0nUTVTZYsILNlupbQEsmX9EoQCf/vi91Loz8qKl/OMCmd8up6j4zovHQa+1RrcX0 vhGw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id p18-20020a170902e75200b001c07bac13d0si1959350plf.383.2023.09.21.10.05.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Sep 2023 10:05:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id AE77C8325FF0; Thu, 21 Sep 2023 10:02:09 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229616AbjIURBx (ORCPT + 99 others); Thu, 21 Sep 2023 13:01:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229913AbjIURBT (ORCPT ); Thu, 21 Sep 2023 13:01:19 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5834F4 for ; Thu, 21 Sep 2023 10:00:42 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 01FDBC61187; Thu, 21 Sep 2023 16:22:06 +0000 (UTC) Date: Thu, 21 Sep 2023 12:22:44 -0400 From: Steven Rostedt To: "T.J. Mercier" Cc: Jaewon Kim , yuzhao@google.com, kaleshsingh@google.com, akpm@linux-foundation.org, vbabka@suse.cz, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, jaewon31.kim@gmail.com Subject: Re: [PATCH v2] vmscan: add trace events for lru_gen Message-ID: <20230921122244.1cbf2d57@gandalf.local.home> In-Reply-To: References: <20230921062206.14429-1-jaewon31.kim@samsung.com> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 21 Sep 2023 10:02:09 -0700 (PDT) On Thu, 21 Sep 2023 09:12:30 -0700 "T.J. Mercier" wrote: > > + TP_fast_assign( > > + __entry->nid = nid; > > + __entry->nr_reclaimed = nr_reclaimed; > > + __entry->nr_dirty = stat->nr_dirty; > > + __entry->nr_writeback = stat->nr_writeback; > > + __entry->nr_congested = stat->nr_congested; > > + __entry->nr_immediate = stat->nr_immediate; > > + __entry->nr_activate0 = stat->nr_activate[0]; > > + __entry->nr_activate1 = stat->nr_activate[1]; > > + __entry->nr_ref_keep = stat->nr_ref_keep; > > + __entry->nr_unmap_fail = stat->nr_unmap_fail; > > + __entry->priority = priority; > > + __entry->reclaim_flags = trace_reclaim_flags(file); > > + ), > > + > > + TP_printk("nid=%d nr_reclaimed=%ld nr_dirty=%ld nr_writeback=%ld nr_congested=%ld nr_immediate=%ld nr_activate_anon=%d nr_activate_file=%d nr_ref_keep=%ld nr_unmap_fail=%ld priority=%d flags=%s", > > Many of these values are unsigned so I think many of these format > specifiers should be %lu instead of %ld. Other than this, from the tracing POV: Reviewed-by: Steven Rostedt (Google) -- Steve