Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
MIME-Version: 1.0
References: <20230920184647.84316-1-festevam@gmail.com>
In-Reply-To: <20230920184647.84316-1-festevam@gmail.com>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Thu, 21 Sep 2023 09:58:47 -0300
Message-ID: <CAOMZO5AjMGA5TtTJH2b7Fs_C3bj84UZr378FVsp5S+ver8_WpQ@mail.gmail.com>
Subject: Re: [PATCH v2 net] net: dsa: mv88e6xxx: Avoid EEPROM timeout when
 EEPROM is absent
To:     kuba@kernel.org
Cc:     andrew@lunn.ch, f.fainelli@gmail.com, olteanv@gmail.com,
        davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
        l00g33k@gmail.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Fabio Estevam <festevam@denx.de>,
        Florian Fainelli <florian.fainelli@broadcom.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Sep 20, 2023 at 3:47=E2=80=AFPM Fabio Estevam <festevam@gmail.com> =
wrote:

> --- a/drivers/net/dsa/mv88e6xxx/chip.c
> +++ b/drivers/net/dsa/mv88e6xxx/chip.c
> @@ -3012,14 +3012,16 @@ static void mv88e6xxx_hardware_reset(struct mv88e=
6xxx_chip *chip)
>                  * from the wrong location resulting in the switch bootin=
g
>                  * to wrong mode and inoperable.
>                  */
> -               mv88e6xxx_g1_wait_eeprom_done(chip);
> +               if (chip->info->ops->get_eeprom)
> +                       mv88e6xxx_g2_eeprom_wait(chip);

Just realized that I should also remove the
mv88e6xxx_g1_wait_eeprom_done() definition, as it becomes unused now.

I will send a v3 with such a change, but will wait for more comments first.