Date: Fri, 9 Nov 2007 12:16:34 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: "Akinobu Mita" <akinobu.mita@gmail.com>
Cc: andreas.herrmann3@amd.com, ak@suse.de, tglx@linutronix.de,
       mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: fix cpu-hotplug regression
Message-Id: <20071109121634.c7812697.akpm@linux-foundation.org>
In-Reply-To: <961aa3350711070615m4a165546k4fa888cb546846f6@mail.gmail.com>
References: <20071107011258.GA31607@alberich.amd.com>
	<200711070335.44416.ak@suse.de>
	<20071107131836.GB31607@alberich.amd.com>
	<961aa3350711070615m4a165546k4fa888cb546846f6@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1591
Lines: 40

On Wed, 7 Nov 2007 23:15:38 +0900
"Akinobu Mita" <akinobu.mita@gmail.com> wrote:

> > [PATCH] x86: fix cpu hotplug regression (don't call mce_create_device on CPU_UP_PREPARE)
> >
> > Fix regression introduced with d435d862baca3e25e5eec236762a43251b1e7ffc
> > ("cpu hotplug: mce: fix cpu hotplug error handling").
> >
> > For CPUs not brought up during boot (using maxcpus and additional_cpus
> > parameters) we don't know whether mce is supported or not at "CPU_UP_PREPARE"-time.
> > Thus mce_cpu_callback should be called after the CPU is online.
> 
> Thank you for finding and fixing the problem.
> I added two fixes to your patch:
> 
> - Avoid mce_remove_device() for the CPU that is not correctly initialized
>   by mce_create_device() failure.
> 
> - make CPU_ONLINE callback always return NOTIFY_OK.
>   Because CPU_ONLINE callback return value is always ignored.
> 
> > Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
> 
> [akinobu.mita@gmail.com: make CPU_ONLINE callback always return NOTIFY_OK]
> [akinobu.mita@gmail.com: avoid mce_remove_device() for not initialized device]
> 
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>

Andreas, could you please review and preferably runtime-test this new
version?

Assuming that all goes well could one of you please prepare a final patch
with a complete changelog?

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/