Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Thu, 21 Sep 2023 09:33:13 +0200
Message-ID: <87sf78t1za.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Abelardo Ricart <aricart@gmail.com>
Cc:     linux-kernel@vger.kernel.org, perex@perex.cz, tiwai@suse.com,
        alsa-devel@alsa-project.org
Subject: Re: [PATCHv3] ALSA: hda/realtek: Add quirk for ASUS ROG G533Q
In-Reply-To: <2436e7f2-b986-4dda-9d4d-0f73845c1ffc@gmail.com>
References: <2436e7f2-b986-4dda-9d4d-0f73845c1ffc@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Thu, 21 Sep 2023 09:22:57 +0200,
Abelardo Ricart wrote:
> 
> The same quirk applied to the ASUS G533Z is also applicable to the ASUS
> G533Q (of which I am an owner and have thus tested).
> 
> Signed-off-by: Abelardo Ricart <aricart@gmail.com>

Unfortunately it's still a problem; tabs are converted to 4 spaces.

I recommend you to try sending to yourself locally and verify whether
it works before resubmitting v4.


thanks,

Takashi

> ---
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index dc7b7a407638..fdc3560ad951 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -9649,6 +9649,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> ???? SND_PCI_QUIRK(0x1043, 0x1493, "ASUS GV601V", ALC285_FIXUP_ASUS_HEADSET_MIC),
> ???? SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A),
> ???? SND_PCI_QUIRK(0x1043, 0x1573, "ASUS GZ301V", ALC285_FIXUP_ASUS_HEADSET_MIC),
> +??? SND_PCI_QUIRK(0x1043, 0x1602, "ASUS ROG Strix G15 (G533Q)", ALC285_FIXUP_ASUS_G533Z_PINS),
> ???? SND_PCI_QUIRK(0x1043, 0x1662, "ASUS GV301QH", ALC294_FIXUP_ASUS_DUAL_SPK),
> ???? SND_PCI_QUIRK(0x1043, 0x1683, "ASUS UM3402YAR", ALC287_FIXUP_CS35L41_I2C_2),
> ???? SND_PCI_QUIRK(0x1043, 0x16b2, "ASUS GU603", ALC289_FIXUP_ASUS_GA401),
>