Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Date:   Thu, 21 Sep 2023 09:44:25 +0200
From:   Maxime Ripard <mripard@kernel.org>
To:     Javier Martinez Canillas <javierm@redhat.com>
Cc:     Thomas Zimmermann <tzimmermann@suse.de>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH] drm/ssd130x: Drop _helper prefix from struct
 drm_*_helper_funcs callbacks
Message-ID: <552hpgr7qzbjxuyei3n5m7rsn7ekwbdgzv25oe5vy6qb35gf23@q4etussk5jwl>
References: <20230914195138.1518065-1-javierm@redhat.com>
 <f5620d32-2705-498b-a65c-7dc663340a6d@suse.de>
 <87wmwo3q50.fsf@minerva.mail-host-address-is-not-set>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="2ociu33dmyngsoqo"
Content-Disposition: inline
In-Reply-To: <87wmwo3q50.fsf@minerva.mail-host-address-is-not-set>
Precedence: bulk


--2ociu33dmyngsoqo
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Mon, Sep 18, 2023 at 09:19:07AM +0200, Javier Martinez Canillas wrote:
> Thomas Zimmermann <tzimmermann@suse.de> writes:
>=20
> > Hi
> >
> > Am 14.09.23 um 21:51 schrieb Javier Martinez Canillas:
> >> The driver uses a naming convention where functions for struct drm_*_f=
uncs
> >> callbacks are named ssd130x_$object_$operation, while the callbacks for
> >> struct drm_*_helper_funcs are named ssd130x_$object_helper_$operation.
> >>=20
> >> The idea is that this helper_ prefix in the function names denote that=
 are
> >> for struct drm_*_helper_funcs callbacks. This convention was copied fr=
om
> >> other drivers, when ssd130x was written but Maxime pointed out that is=
 the
> >> exception rather than the norm.
> >
> > I guess you found this in my code. I want to point out that I use the=
=20
> > _helper infix to signal that these are callback for=20
> > drm_primary_plane_helper_funcs and *not* drm_primary_plane_funcs. The=
=20
> > naming is intentional.
> >
>=20
> Yes, that's what tried to say in the commit message and indeed I got the
> convention from drivers in drivers/gpu/drm/tiny. In fact I believe these
> function names are since first iteration of the driver, when was meant to
> be a tiny driver.
>=20
> According to Maxime it's the exception rather than the rule and suggested
> to change it, I don't really have a strong opinion on either naming TBH.

Maybe that's just me, but the helper in the name indeed throws me off. In my
mind, it's supposed to be used only for helpers, not functions implementing=
 the
helpers hooks.

Maxime

--2ociu33dmyngsoqo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZQv0WQAKCRDj7w1vZxhR
xQqfAP92TE+LyR9XfDnY8TOYQ2btb0vi9F8eVCt96OBDOKAmwwD9GadGgQONJhi2
9eLzxM9+iTWsgK3rnNX7P7WK0mfI/w0=
=v3YY
-----END PGP SIGNATURE-----

--2ociu33dmyngsoqo--