Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp2287154rdb; Thu, 21 Sep 2023 14:08:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFgdumrOQK1DnSDrsJMDcM5ghxmxe2Xick8N7s4Aw9T4YXoDAyCX2IabiyCpXQLQWJJR+1t X-Received: by 2002:a05:6a21:78a4:b0:152:4615:cb9e with SMTP id bf36-20020a056a2178a400b001524615cb9emr1063418pzc.13.1695330539149; Thu, 21 Sep 2023 14:08:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695330539; cv=none; d=google.com; s=arc-20160816; b=WzwGOkVaO1K4MusPZQYu0engMCW6N6orFgwUP8fKYUoGdFYqDF85Yx50LGsg6c8PAA UAHy1DjMWCt6nMBCfaPqUVmohNNIRa2pYFaJgfjkdQVzASlRanfwWGhw8INkNuzFBOS+ /LKnIeYFkACD8AF7uOgC2pV7DWyQYmCfU6OfWsi8LcG/YycMFvb20TUarIcjlwUHXYsp mcdFJVaz9dfAjnyC6xZqYnCE0911WX+IP/MJ71go4O6qoRXbS8lO0luFhkzutGcBTBRA iCRQKX+F7CD2VTowSW1cMCTPOPWbwGBWa8meSKaqxBx1wtZavEzGX+zCape2RNeUZlAJ L4ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:references :in-reply-to:subject:to:from:date:message-id:dkim-signature; bh=3omRRAuhKLx3rUlF+M0I38XRTMiyOqLO113BPuaeJPE=; fh=MPXPqH4JOmNwYtLE2NKgdKAPusxLgN/+eprT1Gtcth0=; b=UEmNilXM/eXnMUu7xZbfkVgPEky7k3S3hjc7VnqYJc2t7O1f8Jdpvn1CTO5CKuTQiD NsuBp+BsRWU1n/HZya1UoivubLkY6u0qS3dKNLD3G1H/v502vThD0+Al3Fxqh8Nsr7x6 2C0ArZYl+KzOipyceYXqQYHOzbD42I1Ead9hdIgnbXhAy+phlNYfTnN6Mwc3dAHMYwYG ITeNazO6650YfhHB673AF+psdRxPKGMOLjASA5CzIt4Yn1zEACk2h27UaQ4x+4Kb5sjo v4d4oUobKtrZvXSOf6PruT2Zr3xspW5hEyYPNvfRSaxP0UAv6GrBoEE3LGpyZRBg3z6S 9CTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NarvtlMJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id s26-20020a056a00179a00b0068ffeb6a949si2454773pfg.73.2023.09.21.14.08.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Sep 2023 14:08:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NarvtlMJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 1A24580DE638; Thu, 21 Sep 2023 13:57:10 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232031AbjIUU4m (ORCPT + 99 others); Thu, 21 Sep 2023 16:56:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232269AbjIUUex (ORCPT ); Thu, 21 Sep 2023 16:34:53 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5349C86112 for ; Thu, 21 Sep 2023 10:37:55 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4B855C4E681; Thu, 21 Sep 2023 14:19:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695305987; bh=3omRRAuhKLx3rUlF+M0I38XRTMiyOqLO113BPuaeJPE=; h=Date:From:To:Subject:In-Reply-To:References:Cc:From; b=NarvtlMJI4dC25o33cGWYbiFUCmh6m5wCn6RhAcs1t4sHSKg+gQYLRIib4349DV56 T2KFKBerigcI6jOyzdS970PrTgy6l9Z79H6RKet7hOkbTP5TK5bHV7hDQGBvpazmC0 R+8fGTRFcN44d/smo48T/hkRZ8DM+sjKzqBvwHkoMhicoF5YqATOc2rTwuC4kvFdKc r6bSlPfgbasVYD291yp21mtRIqmcjbDfICi+Iq+0Mv8SWie85dFlmKpAegqkbkgCk8 36N4vbfs4TNFq5wpPiygyjqQM7WizXDFgr7tGoyHqiVnWqBBUYwuOwQkdP+Fzuqa/9 bxEFLDCo148HA== Message-ID: Date: Thu, 21 Sep 2023 14:19:44 +0000 From: "Maxime Ripard" To: "Javier Martinez Canillas" Subject: Re: [PATCH] drm/ssd130x: Drop _helper prefix from struct drm_*_helper_funcs callbacks In-Reply-To: <20230914195138.1518065-1-javierm@redhat.com> References: <20230914195138.1518065-1-javierm@redhat.com> Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, "Daniel Vetter" , "David Airlie" , "Geert Uytterhoeven" , "Maxime Ripard" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 21 Sep 2023 13:57:10 -0700 (PDT) On Thu, 14 Sep 2023 21:51:24 +0200, Javier Martinez Canillas wrote: > The driver uses a naming convention where functions for struct drm_*_funcs > callbacks are named ssd130x_$object_$operation, while the callbacks for > struct drm_*_helper_funcs are named ssd130x_$object_helper_$operation. >=20 > The idea is that this helper_ prefix in the function names denote that are >=20 > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime