Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Date:   Thu, 21 Sep 2023 14:53:30 -0400
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     maple-tree@lists.infradead.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, pedro.falcato@gmail.com,
        stable <stable@kernel.org>
Subject: Re: [PATCH 0/2] maple_tree: Fix mas_prev() state regression.
Message-ID: <20230921185330.j5jw3oms4tc6crkf@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        maple-tree@lists.infradead.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, pedro.falcato@gmail.com,
        stable <stable@kernel.org>
References: <20230921181236.509072-1-Liam.Howlett@oracle.com>
 <20230921112521.fc07c658804f4e188179da77@linux-foundation.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230921112521.fc07c658804f4e188179da77@linux-foundation.org>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?k3jDLGT3ldm+WNG9nlSjVmnCEDk/j1AWnvbbO3evtWwcDZe6Q4SSNqZU1pnP?=
 =?us-ascii?Q?ftnu1nb5GxIF+cqiHSRw2+2amBFXFyQJhLWCAoCkvbbCejZZFcAF54BeHRUT?=
 =?us-ascii?Q?LY7AwZRUVXIraAdf12mAG5tDoKJXd4lHk6rNIXSEbvRBqBa3EPAF5xoCvBGx?=
 =?us-ascii?Q?N+INxbIGQWlfCsyK7axZGxCrv0RxBSsX9BFe3cVt132szUqH3MsLHt7bRP4G?=
 =?us-ascii?Q?IHWtxBrncsTrjPPSeFT8HzUqwlbmnS0grcOgosT3zPjP+5rGOwv4zBLxo74W?=
 =?us-ascii?Q?KmjY43aWJXpfH5BQ9wfnUG/fCe0cWMh5KdTuYy3NwRgn43ado3BGoLMj8cSS?=
 =?us-ascii?Q?kbVhz3HHCoI2Y5TS80yTshdO4ci5w4lCfgkxYBUwQ5RduKfkc/H42fwpW+Pr?=
 =?us-ascii?Q?mDRpFOFp1zg4Z+OxOgBmLfTxCNQn6ItqFdVy7l1+gsJrs/1BrFndKnEemF4P?=
 =?us-ascii?Q?ZoLwgA0qayv7tXbL05zRLYQuX45d7CyKDrzYeeIAKbFb82l3y6qcVLb350/6?=
 =?us-ascii?Q?ZEd8qZEGTAH18Bof9OeoENiGLqXoyfNYyrDrKLW8nly4EdCR5/gksMrEr2W4?=
 =?us-ascii?Q?uAjBuFAckdy6gIJpchoL5RNj8Mdbx25necDco2L3GlRTWdyjYXbgc3UQTd+6?=
 =?us-ascii?Q?hBnRUW9Thr8eQDZghBIxCGiUvZC8ugGibq6IieViVNsln9wkNonOusrs3dr0?=
 =?us-ascii?Q?YPiCPf/c1jpkdhdm6I7J0PPoNuZzjmMjzS7JcpArEHEUUGBfniwIfR2m9PQB?=
 =?us-ascii?Q?D1xCYM/3ltAWNvgkMpA/bcQOuTrwPO4VZfmEFnBHMfjtAQnLwQNY2pQGOGEo?=
 =?us-ascii?Q?/MGY5FSu30+VcyjakaoOYXZde0GVTzLXO/g0bzUwfmyobtLyLVbgQCPxsSPa?=
 =?us-ascii?Q?+wUHl+d8wFXr8OOYI1czgDiSTmFB2b0VCen/HAVcvEIxTbBDNQ+BioZVYQrm?=
 =?us-ascii?Q?qp4li+2ta82qSynp/71yLAcMQozC2vHR47pQAq2HejQvHVCoGgoMrDiu0Ozl?=
 =?us-ascii?Q?ZFHT5zRBqX6D03grc2GdWKR9Bn/ADiI6hwy6L5EO4IqRMHGb6dPybSFC4f3Y?=
 =?us-ascii?Q?XvDpr/uo6SOKZPqVMK6bmPAvawmdnO3g1VimPey699wVYoa3rMI3msrA5xHH?=
 =?us-ascii?Q?4CzsrCVK9GdYVRx0n65Zm5wx0s8anXPSpbUhVNTSP2N6eF5vtxndC9Safcid?=
 =?us-ascii?Q?LYb4duz2iH4CsLbFmhRih9Vf70nuec4sWEmH4PCLRMzZ5qNN/UaQ2h5aQYEs?=
 =?us-ascii?Q?y9gkse+CRYJOlPl+EhQ77o44v1qMe/GlkDpMxcS8VQEFr2qARdPjCDw9Ei+R?=
 =?us-ascii?Q?Z0ieXHwu5xig75IYZr7P050PTx1WESWHj3ocTFjPzLTadAEwGu56fzCejsdh?=
 =?us-ascii?Q?OU9zs2U8Ra+y0zXdaM6gArP+bFrbfY4Vxl3TRBuofIyFqzo7EmAVk4Q6HfD8?=
 =?us-ascii?Q?ecwePdiKmKQ0mP9GpAaLlVDvSTopmam3nVjilU6SfNT4mW9OB1TCOzGEnm4c?=
 =?us-ascii?Q?FGQtiFQpNONedsBo8y1ANl3oDjXGB7ucxPw/belYhZtr0T6lRk0gp82seebg?=
 =?us-ascii?Q?JoJUbg+ARlULDMOCSnVjZ8m9/lmyNttdrCH/wN7z?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?zO8Wf5d8wU2kCi7AaGkF6woruFPs6jcoipis275IGsCoAuIJbFrAJ3g3unbu?=
 =?us-ascii?Q?UXtEmK0WaXUEm6uT1nGAzuvZimeUm2fLT543cZQKBUJd6PgpZGmUlG4PNdhH?=
 =?us-ascii?Q?R3CS0FRhSenI7XwjczkgEmS5XhE2ZPKHJ5Im5yfkMOISBGXincWoFpjn+P8k?=
 =?us-ascii?Q?wEdfS4YRe2z6IEVQDtzt3haEmW+9J3l8gU9Iv7Q8wdCF3QabYwh1s2sEZSmb?=
 =?us-ascii?Q?KxcQHrP1MJjJfAAk85TmLV7TesThBvauQTmuAnnYgZjhv1Nv016fXj+iwGSq?=
 =?us-ascii?Q?7L75pt4ZDLTqLWmr6YZKwedNdWzm2wwN98pgKnzaBgjMMM58oTouOGb+ZMsB?=
 =?us-ascii?Q?76uvUA+gB29aFkbhYXxLN3wXDy5IVF0ALssO/QmEPZCf0CEPlRMstqqI3CNN?=
 =?us-ascii?Q?mygGja0OQDsBP8bjhq2w3YCT375xvkRJfM7uL5RBlMrfwMDHAnD1CQF1JO4L?=
 =?us-ascii?Q?keIdYyU+NFlfOrmqIl9i884PrsWbfE1n+c+joOKrNj68yN0TWd2EM1EjK044?=
 =?us-ascii?Q?IPUVn+QdO1pixMF5dA9gKAOvu3rysCVWQGZ/P2Ij0vanIe3v5nEIXp9WAe07?=
 =?us-ascii?Q?/0VflTNpHW4IrYyDUp0OzuL/x3Hz8OUPr7ajn9DbaleHjnJ52/6/gSAQIBF/?=
 =?us-ascii?Q?gKPRIFi6XOKkD2vswljVf2OHeZJb57SG4VzgwL7A5S9pk+j8uyKrnt2K2m5T?=
 =?us-ascii?Q?6b/vyCMfVEklghpxEPrp/A/TjFcSAzvQMQnYTM5mxWWLhYlxuINjUJ2sIRnh?=
 =?us-ascii?Q?wB6j63kSIYdJsf3t7wwYy1IUCo2xp+KdAmSCYuQmZkl9ThNruNZtgUp+FDbY?=
 =?us-ascii?Q?X1Q/UZA0hYqQP6Fkp6smgQwL4yxY0ZY/+6yVmAWP++0xTNSzzMe32D5Mtzf7?=
 =?us-ascii?Q?Uj5kriCsiJKv1eIwR/IOB7/mN5x2Df2DVfXO+USGYPVbn9YWIAWGWurl8ORV?=
 =?us-ascii?Q?RL/IoM+rz0CRTF0RUBGf3g=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 24de1866-93b0-4fb1-aaaa-08dbbad40dd4
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2023 18:53:33.1958
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i9Cr02SWrK4DGko/JJTWLW7wTQSWp0oBkaZwhI/+x/v2wu34YzBRi3fpzhuc8wIH82Jy+zYEbPBpzIryL19amA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5343
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-09-21_16,2023-09-21_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 spamscore=0
 suspectscore=0 mlxlogscore=775 phishscore=0 bulkscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000
 definitions=main-2309210163
X-Proofpoint-ORIG-GUID: uPaoMghAA-_QHHzvk1nKaLZvbNydE_qO
X-Proofpoint-GUID: uPaoMghAA-_QHHzvk1nKaLZvbNydE_qO
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 21 Sep 2023 12:01:37 -0700 (PDT)

* Andrew Morton <akpm@linux-foundation.org> [230921 14:25]:
> On Thu, 21 Sep 2023 14:12:34 -0400 "Liam R. Howlett" <Liam.Howlett@oracle.com> wrote:
> 
> > Pedro Falcato contacted me on IRC with an mprotect regression which was
> > bisected back to the iterator changes for maple tree.  Root cause
> > analysis showed the mas_prev() running off the end of the VMA space
> > (previous from 0) followed by mas_find(), would skip the first value.
> > 
> > This patch set introduces maple state underflow/overflow so the sequence
> > of calls on the maple state will return what the user expects.
> 
> It isn't clear what are the user-visible effects of this flaw?  Please
> send this along and I'll paste it in.


User may notice that mas_prev() or mas_next() calls that result in going
outside of the limit passed to the call will cause incorrect returns on
subsequent calls using that maple state, such as mas_find() skipping an
entry.

> 
> Patch 1 should be titled "Add mas_is_active ...".

Oh yes, sorry.

> 
> And patch 1 should have had cc:stable in the changelog.

Ah, I sent the series to stable but didn't add that to the changelog.
I'll do that in v2 as it seems I need to update patch 2 anyways.

> 
> It's stable@vger.kernel.org, although stable@kernel.org works just fine.