Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
From:   Clark Wang <xiaoning.wang@nxp.com>
To:     alexandre.torgue@foss.st.com, joabreu@synopsys.com,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, mcoquelin.stm32@gmail.com,
        bartosz.golaszewski@linaro.org
Cc:     netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH net] net: stmmac: platform: fix the incorrect parameter
Date:   Thu, 21 Sep 2023 14:24:43 +0800
Message-Id: <20230921062443.1251292-1-xiaoning.wang@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZAFVEk8ZXaL6cMrIPwfD92k5aK+PjFlX1GPFXer52IpFxU8zKHf2/CDTDcEQ?=
 =?us-ascii?Q?XyLad4jeVvMJesvr1gIhRkNGePkKvgEOUPeamieBYdTp/zJTjEDE0pHKKNlp?=
 =?us-ascii?Q?zbLzSfBIaQ5cK031bmyIpltjZkY/UQXEuUxGdrVXCpUp/U9Llvw58FnWKsmw?=
 =?us-ascii?Q?nRRa4e1YAhjUS2MBtz9dJlhPn8KZ/p3bm5VFferaKgMDQeLGqJBo48ifBfGC?=
 =?us-ascii?Q?KvDE+xI4z1tSGBQmEtdzDGyzsf1EyehAaZJ0q0nkq3DoC6lhri8J8nmjqRqj?=
 =?us-ascii?Q?85qsmR0Tk+PZCqyomDpJh+qcupRYnfkx1xpbJmeDGeX38+52FALRGpo08UUe?=
 =?us-ascii?Q?7JTuv2a4AJMRdM7Bxn9lCZubgPbM6J7tl8lToJSG77Dbn4tiiok18wNnVBuB?=
 =?us-ascii?Q?4aLXNYjb/M9X9aI1kd0Wa8ZT4uCmSW5Y/lNKU1ITpoBuo007p+Cfq68u8WUn?=
 =?us-ascii?Q?GiR+TYICImC5izSwbv1zCtrKQ76YWNoJDwh7PkOkvy4EhY3BbUvWk7DK0Uiw?=
 =?us-ascii?Q?6SJjBasTbosr1BjIQS/aVigXiwyVjCpVQun7P/u5IvjqDMx+rUQOD9HdzCPG?=
 =?us-ascii?Q?j3FA78syhPV0vVURSnnY21VjCkYzL+tO0iIaIH8xDDnQmXTnZ72FU7BFWSPD?=
 =?us-ascii?Q?4thSRHAMGBkLBRby+fu4QW/th41AXBppRygItpVfDS2bF3L8jDwYxcMJyDiS?=
 =?us-ascii?Q?Yo+gsEGSBKyA3jxNshN10DDcOVQ+XySlDVLYsIpRQmfwctVvA7B7uZvs20bR?=
 =?us-ascii?Q?qsUUC61dPCT1ywZI4oeJxOAXsQALLNdDBWGvsmSXFnEvghmccrH0HaR8rweK?=
 =?us-ascii?Q?08beMQbk4akqa3OwvV1P2OPQ9bdRwF3T8MnpFADeomVuePo7IHl9CTVx6Abb?=
 =?us-ascii?Q?sdk2OWIs+xdrzW32khPKJSyIPsLD7AcjqMBTPy6f9aCclvQqm0V0sZf3dOek?=
 =?us-ascii?Q?6k1ab5R6KGGgFCAXbJnvE4f4u6lVHrGHwFYCi/Jfw6KUPAZ7E0tK5lo0C/wj?=
 =?us-ascii?Q?/zOHLJQe3s5FfZN5sInOr/W7j87DWg7ieifiJvor8qv2f7DcakgSQSIuyrjy?=
 =?us-ascii?Q?7TWGOTjTTQFOqeuK81H66EzPaykKxYqqb/x2lbG6nr7ZCiqyCWf4HStQjqDQ?=
 =?us-ascii?Q?RaAFY5iatJukKoR8xjb5nhHgY0gcss5W5jQXaKieQVlag4GnGsYaKf4r9Gwa?=
 =?us-ascii?Q?LQJtVwriWiyvEITq1CVdF2YBHy4ij9FsvjldkcSp2Af1hLIjfwH3RRQBVetV?=
 =?us-ascii?Q?TyuFJGkI1S5RoLOGmhrwgAwxHK0Meq/xlDBkieI6lIeI0sSuU2ums4rpEbAw?=
 =?us-ascii?Q?qx1yvHXeYVc3WWUUv+Pi2FPL/WEzaedmwrOsE4OQk+UM5d23/vkc+5RWu59I?=
 =?us-ascii?Q?mi4QPBYhQ1q+PVg1DHbOwjcybm6WF9wY96GjzwblYLJdHUEb82koDH3gqMsA?=
 =?us-ascii?Q?QNBteLUXQSRmVPaPjO5053YfsM3t52J7EHEiBWbXhb+gJFDlOofcZd0rRXV9?=
 =?us-ascii?Q?lTnhJD8p57n0vSxwRuIQNlX28+13RF5JvYyGJm8QdbR0OCWb08LQbrClq4vN?=
 =?us-ascii?Q?wQ5CmUXUtKmExem/XyWZV3G6oheGComAGRQ5dZzk?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7550869a-0c10-4812-adcd-08dbba6b785a
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5089.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2023 06:24:54.8405
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4IaFqajJ+Vlswm+GBBFLdVWWZBxxVjTXN0e017RrFIsUnJeWGlGGjmCA1QE7P79TPdKObu9WtPBcsU8ZcPKN1w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS5PR04MB9922
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 21 Sep 2023 10:03:00 -0700 (PDT)

The second parameter of stmmac_pltfr_init() needs the pointer of
"struct plat_stmmacenet_data". So, correct the parameter typo when calling the
function.

Otherwise, it may cause this alignment exception when doing suspend/resume.
[   49.067201] CPU1 is up
[   49.135258] Internal error: SP/PC alignment exception: 000000008a000000 [#1] PREEMPT SMP
[   49.143346] Modules linked in: soc_imx9 crct10dif_ce polyval_ce nvmem_imx_ocotp_fsb_s400 polyval_generic layerscape_edac_mod snd_soc_fsl_asoc_card snd_soc_imx_audmux snd_soc_imx_card snd_soc_wm8962 el_enclave snd_soc_fsl_micfil rtc_pcf2127 rtc_pcf2131 flexcan can_dev snd_soc_fsl_xcvr snd_soc_fsl_sai imx8_media_dev(C) snd_soc_fsl_utils fuse
[   49.173393] CPU: 0 PID: 565 Comm: sh Tainted: G         C         6.5.0-rc4-next-20230804-05047-g5781a6249dae #677
[   49.183721] Hardware name: NXP i.MX93 11X11 EVK board (DT)
[   49.189190] pstate: 60400009 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
[   49.196140] pc : 0x80800052
[   49.198931] lr : stmmac_pltfr_resume+0x34/0x50
[   49.203368] sp : ffff800082f8bab0
[   49.206670] x29: ffff800082f8bab0 x28: ffff0000047d0ec0 x27: ffff80008186c170
[   49.213794] x26: 0000000b5e4ff1ba x25: ffff800081e5fa74 x24: 0000000000000010
[   49.220918] x23: ffff800081fe0000 x22: 0000000000000000 x21: 0000000000000000
[   49.228042] x20: ffff0000001b4010 x19: ffff0000001b4010 x18: 0000000000000006
[   49.235166] x17: ffff7ffffe007000 x16: ffff800080000000 x15: 0000000000000000
[   49.242290] x14: 00000000000000fc x13: 0000000000000000 x12: 0000000000000000
[   49.249414] x11: 0000000000000001 x10: 0000000000000a60 x9 : ffff800082f8b8c0
[   49.256538] x8 : 0000000000000008 x7 : 0000000000000001 x6 : 000000005f54a200
[   49.263662] x5 : 0000000001000000 x4 : ffff800081b93680 x3 : ffff800081519be0
[   49.270786] x2 : 0000000080800052 x1 : 0000000000000000 x0 : ffff0000001b4000
[   49.277911] Call trace:
[   49.280346]  0x80800052
[   49.282781]  platform_pm_resume+0x2c/0x68
[   49.286785]  dpm_run_callback.constprop.0+0x74/0x134
[   49.291742]  device_resume+0x88/0x194
[   49.295391]  dpm_resume+0x10c/0x230
[   49.298866]  dpm_resume_end+0x18/0x30
[   49.302515]  suspend_devices_and_enter+0x2b8/0x624
[   49.307299]  pm_suspend+0x1fc/0x348
[   49.310774]  state_store+0x80/0x104
[   49.314258]  kobj_attr_store+0x18/0x2c
[   49.318002]  sysfs_kf_write+0x44/0x54
[   49.321659]  kernfs_fop_write_iter+0x120/0x1ec
[   49.326088]  vfs_write+0x1bc/0x300
[   49.329485]  ksys_write+0x70/0x104
[   49.332874]  __arm64_sys_write+0x1c/0x28
[   49.336783]  invoke_syscall+0x48/0x114
[   49.340527]  el0_svc_common.constprop.0+0xc4/0xe4
[   49.345224]  do_el0_svc+0x38/0x98
[   49.348526]  el0_svc+0x2c/0x84
[   49.351568]  el0t_64_sync_handler+0x100/0x12c
[   49.355910]  el0t_64_sync+0x190/0x194
[   49.359567] Code: ???????? ???????? ???????? ???????? (????????)
[   49.365644] ---[ end trace 0000000000000000 ]---

Fixes: 97117eb51ec8 ("net: stmmac: platform: provide stmmac_pltfr_init()")
Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
index 0d9b2138b60a..3c6fd9027934 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
@@ -900,7 +900,7 @@ static int __maybe_unused stmmac_pltfr_resume(struct device *dev)
 	struct platform_device *pdev = to_platform_device(dev);
 	int ret;
 
-	ret = stmmac_pltfr_init(pdev, priv->plat->bsp_priv);
+	ret = stmmac_pltfr_init(pdev, priv->plat);
 	if (ret)
 		return ret;
 
-- 
2.34.1