Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp2335230rdb; Thu, 21 Sep 2023 16:00:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGASfNzAd0zqb1Z1VpLeR9yG4nbTp0ORW/dy7jMdwZJ0JhHF+TKGpmd5530YFxDwLUdDAHL X-Received: by 2002:a05:6808:1815:b0:3ae:156f:d314 with SMTP id bh21-20020a056808181500b003ae156fd314mr873933oib.2.1695337216495; Thu, 21 Sep 2023 16:00:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695337216; cv=none; d=google.com; s=arc-20160816; b=aCdVisnT5ioIj3Fx1HH5R6uV8avTwbNRYkKUF0/lFXz5BykCRCCVWd/VWJKF7AOGYr a7m/O48yQ6/K7NVfm6ZRXdzP90JuBKgHkUCd4Z20aJpDjJME8axo7+U6yZwI1J31fGIM BKp9o+JMQU1BV+psMl+tTyqFNgrDXSU2vk0WuzJoUNwHRDbghx12Um9I7XUiIYKQ3Qip yV4EO4JDXB2gqNsw8oj1Z0y0IrCVMlnVwWKAjtJ+KEFmsDF6LtQk00ZlcRFEH3pbcSiy eQwraTWZFljcT/kwvqgtGbSFmQFNYUvO7cobL6HzFbfKAP+cyeV7O2aVg3CRxMGTlQkR WHUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=Ay7FozbEJfLQ5EcQgUmDHbRaQ/fgcjWcAzrltfzFFIE=; fh=ZqJ3xrq0DGyvWtPBQo5VWOM7gaftcxyjM72UWd4YoC8=; b=C4ROE67F+BJJeslmn/MxxSqpqoA69cOFONf6wOokU/IRlkvVp0q8d8INi8rfQktTrX gNh1HyubotKQtpCxByz/KfESLkoN4pBjfXu70x9+U/ggaARBCRNRZqASMp1bQXnzDl1W 1T/FMUe/HCW/CAxUB1EccZ/rAKxlTHfLszuOjb9EAKnomcvOrc17BquVmUq+YsTi/aGw m+wkESVPk9+u5ZuL5cQgibx2Rku5ql7SvlxgrV/oimVrlCpjM6tHFnRhxroadb0DpUAE QhbiKl/ln9f4GBKOnHer3PVzbvs8EQ1GqlYwxgXhUZJo0t9oWp83inonbMU6QdRgi7SA 8y1w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id v20-20020a056a00149400b006910e8e46e0si2621825pfu.371.2023.09.21.16.00.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Sep 2023 16:00:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id D3FFE80DD6AC; Thu, 21 Sep 2023 13:31:22 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231640AbjIUUas (ORCPT + 99 others); Thu, 21 Sep 2023 16:30:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231699AbjIUUTs (ORCPT ); Thu, 21 Sep 2023 16:19:48 -0400 Received: from SHSQR01.spreadtrum.com (mx1.unisoc.com [222.66.158.135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B83AE57B12; Thu, 21 Sep 2023 10:18:51 -0700 (PDT) Received: from SHSQR01.spreadtrum.com (localhost [127.0.0.2] (may be forged)) by SHSQR01.spreadtrum.com with ESMTP id 38L8vVZL048701; Thu, 21 Sep 2023 16:57:31 +0800 (+08) (envelope-from Huangzheng.Lai@unisoc.com) Received: from dlp.unisoc.com ([10.29.3.86]) by SHSQR01.spreadtrum.com with ESMTP id 38L8tYjo040875; Thu, 21 Sep 2023 16:55:34 +0800 (+08) (envelope-from Huangzheng.Lai@unisoc.com) Received: from SHDLP.spreadtrum.com (shmbx04.spreadtrum.com [10.0.1.214]) by dlp.unisoc.com (SkyGuard) with ESMTPS id 4Rrq0G2Ym1z2SZtbS; Thu, 21 Sep 2023 16:52:14 +0800 (CST) Received: from xm9614pcu.spreadtrum.com (10.13.2.29) by shmbx04.spreadtrum.com (10.0.1.214) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Thu, 21 Sep 2023 16:55:33 +0800 From: Huangzheng Lai To: Andi Shyti CC: Orson Zhai , Baolin Wang , Chunyan Zhang , , , huangzheng lai , Huangzheng Lai , Xiongpeng Wu Subject: [PATCH V2 7/7] i2c: sprd: Add I2C_NACK_EN and I2C_TRANS_EN control bits Date: Thu, 21 Sep 2023 16:54:57 +0800 Message-ID: <20230921085457.32446-8-Huangzheng.Lai@unisoc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230921085457.32446-1-Huangzheng.Lai@unisoc.com> References: <20230921085457.32446-1-Huangzheng.Lai@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.13.2.29] X-ClientProxiedBy: SHCAS03.spreadtrum.com (10.0.1.207) To shmbx04.spreadtrum.com (10.0.1.214) X-MAIL: SHSQR01.spreadtrum.com 38L8tYjo040875 X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 21 Sep 2023 13:31:23 -0700 (PDT) The new I2C IP version on the UNISOC platform has added I2C_NACK_EN and I2C_TRANS_EN control bits. To ensure that the I2C controller can initiate transmission smoothly, these two bits need to be configured. Signed-off-by: Huangzheng Lai --- drivers/i2c/busses/i2c-sprd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-sprd.c b/drivers/i2c/busses/i2c-sprd.c index dbdac89ad482..431c0db84d22 100644 --- a/drivers/i2c/busses/i2c-sprd.c +++ b/drivers/i2c/busses/i2c-sprd.c @@ -33,6 +33,8 @@ #define ADDR_RST 0x2c /* I2C_CTL */ +#define I2C_NACK_EN BIT(22) +#define I2C_TRANS_EN BIT(21) #define STP_EN BIT(20) #define FIFO_AF_LVL_MASK GENMASK(19, 16) #define FIFO_AF_LVL 16 @@ -366,7 +368,7 @@ static void sprd_i2c_enable(struct sprd_i2c *i2c_dev) sprd_i2c_clear_irq(i2c_dev); tmp = readl(i2c_dev->base + I2C_CTL); - writel(tmp | I2C_EN | I2C_INT_EN, i2c_dev->base + I2C_CTL); + writel(tmp | I2C_EN | I2C_INT_EN | I2C_NACK_EN | I2C_TRANS_EN, i2c_dev->base + I2C_CTL); } static int sprd_i2c_master_xfer(struct i2c_adapter *i2c_adap, -- 2.17.1