Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <7f575fc3-f4d7-4c79-a13e-1b125093d8f3@intel.com>
Date:   Thu, 21 Sep 2023 15:56:12 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Betterbird/102.13.0
Subject: Re: [PATCH 4/7] cxl: Fix a checkpatch error
To:     Jeongtae Park <jtp.park@samsung.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        Jonathan Cameron <jonathan.cameron@huawei.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Fan Ni <fan.ni@samsung.com>, <linux-cxl@vger.kernel.org>
CC:     <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Kyungsan Kim <ks0204.kim@samsung.com>,
        "Wonjae Lee" <wj28.lee@samsung.com>,
        Hojin Nam <hj96.nam@samsung.com>,
        Junhyeok Im <junhyeok.im@samsung.com>,
        Jehoon Park <jehoon.park@samsung.com>,
        "Jeongtae Park" <jeongtae.park@gmail.com>
References: <20230921025110.3717583-1-jtp.park@samsung.com>
 <CGME20230921024832epcas2p3677e522ed0175b83c1a56e36a730ce97@epcas2p3.samsung.com>
 <20230921025110.3717583-5-jtp.park@samsung.com>
Content-Language: en-US
From:   Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20230921025110.3717583-5-jtp.park@samsung.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K3M4VURZMVBJQnpXL1NXNnlLczhFRkMrOTcyTnRwR0xhQUJma2F4YmYyNXFt?=
 =?utf-8?B?NFNKWjBlM1pPWS9NazNURTVPZXVqVDRLVXdlNjdxM0Jvb2pORndhTVpneS9l?=
 =?utf-8?B?SFJVR3pZUGgwM2ZoVDdPcVFOMjlYK2FVWW5PK3BDbmNHNldFRm1mWWxhejNw?=
 =?utf-8?B?QzV0NmgxRTdUdFVoTEQzWS96TndTazRYVEQxc1RVM25RRHQ4Q3dCdy9KZ2Ns?=
 =?utf-8?B?YVY2Vm95WVRxb2xSaGV3TkpNWVFURDRoZHI0TEpvOFI5TjZEbUVtaVloNnpH?=
 =?utf-8?B?eTNPcFFNSWk1azV6WDg0dlNwcTluQkN5NkxUL1QyRkVnMXZlV2dkaGtmREx1?=
 =?utf-8?B?S1FEeUpEZ2lkVFgyUy96TG5ZbFYweTU5cktiK0pNVGJ4dVJOeXVWZkkzRzB2?=
 =?utf-8?B?YkNlY1ZNMEM2SFBYMDlYOW96SXFqVTdxZUVGdEJ5dmVYVmZKaHV0WEs1dWZx?=
 =?utf-8?B?UXJhbURXcFV2b1hoZjZORWFxeFR1MFE5MFpEUjNMd0F6U3g0aWlsblFZTmxC?=
 =?utf-8?B?RkU1eFYzcXVNUnRBRk51VU5wQWVFWmtodEZqYWpxUzQxUkZHS2loajdwcDVv?=
 =?utf-8?B?WHUreS9GNEhiUHhaYjBpSXExcVBzbjlRWkNLdC9rSTFIdmRteXRzYy9kYjhE?=
 =?utf-8?B?djZ1cXZZWTFTeU13c2hBOFExYjRKeVlZQ3BNWWRXOUJ0ZGJZaG9oem9nNldv?=
 =?utf-8?B?R3poeXlZVmJuaFVKVmoyM25FR3JBamtBTGhLd1Y3THFncWs1Uk1QN3IwczBo?=
 =?utf-8?B?RGFHTjEvWnpxeFYyTnhLS1h6Q3Z6NEtRU0RlbWdrVkdGTGRPaWZieFhBbVNB?=
 =?utf-8?B?QmFqV1BPRURhMUNoOEprK05DTUNqaGZDMk92ZVZmN1VaWGE3UWhWR28rV1kr?=
 =?utf-8?B?Rk1rUGQvWGxSZ21JbVlsN3FiY1h6VXc2OFR4OFUvclYwN2lFTzBqYmp1SElO?=
 =?utf-8?B?U3hhVFVHOGVIREt1TFY5OHBCZHUxbUhKbk5iZG1jd0xrY0ZINWYrUzAxQkpv?=
 =?utf-8?B?RTJzb202cm5sM01HdlM0YVdWUlA2RjA0YlZxWHh1QUcxcmpZQm04T29DZmhV?=
 =?utf-8?B?Yk5sdGRtRFhydGgwd0VrRG5qa1lYeTJwbDNCK0xtYUV3Ly9ReEY4a1c0cTZN?=
 =?utf-8?B?bkwxZXVqS05xdCt4OFFHSWJjWmd0eWFGcCtaNUhPdmZBMlU2TkRjK0RlWVdB?=
 =?utf-8?B?ZzNKVC83TUFrMHpNQ1dRYzRLRVNKOVBXc2g5ajhBUGwvOFhtaURkOWFrRm41?=
 =?utf-8?B?MUtza0FxZ2l2TThDVjlyeWlySzM3eU5mallHOUVFRi9GeGhJa1V4NzF3UVYr?=
 =?utf-8?B?R010bEROUzFPenIySXFzcVpQQW9NWUVPNFRrNk1EVGVJVmc5TEpLRUFQcDZC?=
 =?utf-8?B?dEVvSjlSNWZaYjdTWXFVT3ZGQU9MSnNkTXA4bHlRK3Zxb044YWsveFA5SEZN?=
 =?utf-8?B?aXJqM0ZSYjZSMUFpRVlKcTFjMlhKN0JaWXB2bmxoUGlnOUU5THoyMWNGNzRp?=
 =?utf-8?B?VEhJT3RJc3p0U1plRXlOQXVLRy9OeWhZT2RwdktkVzhreUNDV0RzVXZDZVIz?=
 =?utf-8?B?eFl1a1NFNkc5M3lyUHV6ZGdwRllCWjROdkgzT2NGbDYwUTNNN1NYcU9mODh3?=
 =?utf-8?B?cldQYUZSS1E4bVFiQUJkMUw4SFgvS0s2WGhzaXNtY056NFZkZ3RqWXBscFJD?=
 =?utf-8?B?M1hka1FtN3kyRXpoV2xGSUR3WXFZcEdJVzg2UUp2bFdQWDhjNUtWYmhiTW5q?=
 =?utf-8?B?MDlNeitpbjlqbVFuU2l0RndmUGdQUHRJNEFBUUc2bjZhVFB0b2ZJS0ljQjZv?=
 =?utf-8?B?MU5KRENOUDlrYzdQcW5SbFJVU3QvN0xvUjhaTjdVbERxcGpzZjk5dzFRUFBW?=
 =?utf-8?B?U0RVQ041UkxZZGl4K3d0bk00NWNLN25iT3FZSkxubHVHSmZIVDdIeis2c1VD?=
 =?utf-8?B?ODJ3STlyK29VRjhucktpdXZTOWtxTW1JQkYyQ3h3Ti9wV1hjVnVNaysxTkFI?=
 =?utf-8?B?WnIvYXl1S0ttb2hGWVpZTGE4OHloL1hJOUQvN1ptZm5CUm5JTE5ORk14TUx0?=
 =?utf-8?B?ejFxSWs0Q2pxbE5EaWZIVUoyd0VjSXFNVTJlVEVPcENOYnIwSVRZTHQvQ3hv?=
 =?utf-8?Q?O8tgqb7yGrJ0+RZhtiG+c1cSi?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 08185216-4569-4e6e-e0e7-08dbbaf5f5ae
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5984.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2023 22:56:15.6624
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: A0hr6/l6oMzdSPrgk3RIWGarECgucLkjf07JjELU8aCFyf16JqGcUAu3ZP9cSG7JLsuWfsEltGzZ7mnElF3E0w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB6988
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 21 Sep 2023 15:57:06 -0700 (PDT)


On 9/20/23 19:51, Jeongtae Park wrote:
> ERROR: Macros with complex values should be enclosed in parentheses
> 
> Signed-off-by: Jeongtae Park <jtp.park@samsung.com>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
>  drivers/cxl/cxl.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cxl/cxl.h b/drivers/cxl/cxl.h
> index 76d92561af29..545381355efb 100644
> --- a/drivers/cxl/cxl.h
> +++ b/drivers/cxl/cxl.h
> @@ -142,7 +142,7 @@ static inline int ways_to_eiw(unsigned int ways, u8 *eiw)
>  #define CXL_RAS_HEADER_LOG_OFFSET 0x18
>  #define CXL_RAS_CAPABILITY_LENGTH 0x58
>  #define CXL_HEADERLOG_SIZE SZ_512
> -#define CXL_HEADERLOG_SIZE_U32 SZ_512 / sizeof(u32)
> +#define CXL_HEADERLOG_SIZE_U32 (SZ_512 / sizeof(u32))
>  
>  /* CXL 2.0 8.2.8.1 Device Capabilities Array Register */
>  #define CXLDEV_CAP_ARRAY_OFFSET 0x0