Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Date:   Thu, 21 Sep 2023 09:37:02 -0400
From:   Hugo Villeneuve <hugo@hugovil.com>
To:     m.brock@vanmierlo.com
Cc:     gregkh@linuxfoundation.org, jirislaby@kernel.org,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        conor+dt@kernel.org, hvilleneuve@dimonoff.com,
        linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
        devicetree@vger.kernel.org
Message-Id: <20230921093702.fd28e0dfe06cb5ee61f43494@hugovil.com>
In-Reply-To: <35710516d0c7f41eebceb16ee51d9d4d@vanmierlo.com>
References: <20230920152015.1376838-1-hugo@hugovil.com>
        <20230920152015.1376838-4-hugo@hugovil.com>
        <35710516d0c7f41eebceb16ee51d9d4d@vanmierlo.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH 3/4] dt-bindings: sc16is7xx: add vendor prefix to
 irda-mode-ports property
Precedence: bulk

On Thu, 21 Sep 2023 12:29:13 +0200
m.brock@vanmierlo.com wrote:

> Hugo Villeneuve wrote on 2023-09-20 17:20:
> > --- a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt
> > +++ b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt
> > @@ -21,8 +21,8 @@ Optional properties:
> >    the second cell is used to specify the GPIO polarity:
> >      0 = active high,
> >      1 = active low.
> > -- irda-mode-ports: An array that lists the indices of the port that
> > -		   should operate in IrDA mode.
> > +- nxp,irda-mode-ports: An array that lists the indices of the port 
> > that
> > +		       should operate in IrDA mode.
> >  - nxp,modem-control-line-ports: An array that lists the indices of
> > the port that
> 
> Are you sure you want this line removed?

Hi Maarten,
the line "- nxp,modem-control-line-ports..." is not removed, but
because it starts with a dash in the source file, maybe it is confusing
when looking at the patch only?

Hugo.

> 
> >  				should have shared GPIO lines configured as
> >  				modem control lines.
> > @@ -80,8 +80,8 @@ Optional properties:
> >    the second cell is used to specify the GPIO polarity:
> >      0 = active high,
> >      1 = active low.
> > -- irda-mode-ports: An array that lists the indices of the port that
> > -		   should operate in IrDA mode.
> > +- nxp,irda-mode-ports: An array that lists the indices of the port 
> > that
> > +		       should operate in IrDA mode.
> >  - nxp,modem-control-line-ports: An array that lists the indices of
> > the port that
> 
> Same here.
> 
> >  				should have shared GPIO lines configured as
> >  				modem control lines.
> 
> Greets,
> Maarten
> 
>