Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <e14ac1d0-ef8e-74ab-0616-f3203580b371@intel.com>
Date:   Thu, 21 Sep 2023 15:57:25 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Betterbird/102.13.0
Subject: Re: [PATCH 6/7] cxl/memdev: Fix whitespace error/warnings
To:     Jeongtae Park <jtp.park@samsung.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        Jonathan Cameron <jonathan.cameron@huawei.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Fan Ni <fan.ni@samsung.com>, <linux-cxl@vger.kernel.org>
CC:     <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Kyungsan Kim <ks0204.kim@samsung.com>,
        "Wonjae Lee" <wj28.lee@samsung.com>,
        Hojin Nam <hj96.nam@samsung.com>,
        Junhyeok Im <junhyeok.im@samsung.com>,
        Jehoon Park <jehoon.park@samsung.com>,
        "Jeongtae Park" <jeongtae.park@gmail.com>
References: <20230921025110.3717583-1-jtp.park@samsung.com>
 <CGME20230921024832epcas2p24325cdfdb6fbbcf489ea3d442258e86b@epcas2p2.samsung.com>
 <20230921025110.3717583-7-jtp.park@samsung.com>
Content-Language: en-US
From:   Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20230921025110.3717583-7-jtp.park@samsung.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?czkzNlV2Qy9rRnROdFNWRzhoblpqcE55cERyWkxqRy9NYldmTUhJQnBka0tO?=
 =?utf-8?B?ZE1RaGJQR0RVWEs0SXRWRlErMzVxUy9SckhzdGk4SklaTU1WTi8wQStHK3NN?=
 =?utf-8?B?N2praktDWjU3TjhjaGVZdWNnZEtzeW8wZ0c2ZEpBY2l5K2pGeEdSd21WQU1z?=
 =?utf-8?B?bXlicnRLeVZiVzlIQkJ2dG4reWNFSTh4SnQvUm03cUMyVTE5M2ZwcytzWHA0?=
 =?utf-8?B?QnZyUG9oWWgramxRSWc5MnpMR0oyZFlRMjBTRS9weGlzTXJBVm9TRjdRcHow?=
 =?utf-8?B?ZUEwOUJFbHhhMExPeG9XWGFzYjhUMXpCaU5DRFpGNHlyRnRYYkdxcW9ZMmR2?=
 =?utf-8?B?d21jT1ZEdDBKdmNmUWF3VENIU041S05QVVRmbm1NVXRKU2VsK1FGQUhPdjBS?=
 =?utf-8?B?cHBNVEgwU3laMlBnVkcxUFNUdmtsRm1qeEdxVHRFRTF6V2w4MTJQdnlLUld1?=
 =?utf-8?B?NGZ0anFtbjFwcXBQeDVsaUxVNEovYU15Q1d4bmdQbDk4WElwQml0TmpKRXZ3?=
 =?utf-8?B?MTlNRHRRa2VHMXRrdlI1L1ZCeExLaFlQS1ZhL3VXMkpyUUFyZVNheVY1Mldw?=
 =?utf-8?B?ODh0bjhsZ3BZNjJlZ2hSaGxVWHBEUWtXdDIrUFVjNHhKYks4M2tVZ0FNbTE3?=
 =?utf-8?B?d1g0VEVUSlRaZDJMU1lsNDZTZzFia2tDZjFKZXkydGlhZGlwcXN0WStqemRq?=
 =?utf-8?B?cnE2RnhVUStkVGN1M09jbjRQdm1PamUzZTFVejVwTVJyMjNxVkNWS3FwanEy?=
 =?utf-8?B?S1MwMUg5S0d5TGc3bWJmbUovMHZGT1pMRWNVNFAvajdwVUhUZCtMcVJ2cnRW?=
 =?utf-8?B?YmhXSDFyMlhvQU03RksrL3d3aUcyS2orVlR3Z3ZHVENCc0xDNEdiQ2Q1UzNj?=
 =?utf-8?B?aFhYSnAxdVh4UENCMmZld1JjSlpHbGgvMDhKZlpEcU1HckVKR3ZWc0prYmlr?=
 =?utf-8?B?SG9yQ1hFN3A1TDJzQVNwZDlpNngvNUd6V1lFSHlFOEoxOEFDOU5HZFFoNGl6?=
 =?utf-8?B?Yk1oRDdXdkc0SkxzYjBEb05QdURiUTN0bkNRQ3UydXAzbFc1aW0rY1o2SmZn?=
 =?utf-8?B?TWc3Q2NqODdzdTQvbU9aZXFPZDdmaW9uVUsvQkJuOU1WMkxEbXhqY1hTMDdN?=
 =?utf-8?B?S3BKeFAyU3o5NURUd0dWZmxIWW4wQ2VIdDhEZ2Q3Uis4LzM2NTNwVWU2Vm5x?=
 =?utf-8?B?UXpHZWF2TDFQaUw4V2U1YXY4TTlvTExkbmIxcjNkZ3ZBUUV5eGMzNndrVWNY?=
 =?utf-8?B?KzNlbzlPRDBuYlFqdk5GcU1oMFpIQWRkRjZRYmhyZ3BRUUU1UkI4bkt4Zk1w?=
 =?utf-8?B?L2M1U053bUV2WDJnaXZGS1ErU2U3V2lCSnVrRHBQY1NkRm5HOTBQbkptM0NX?=
 =?utf-8?B?cnd2d0VUNTJON3dBazlYdVFpbmkxc1pFaU5xOEZLK1I2akdoZnBKMWNzWWpj?=
 =?utf-8?B?TElLQU9ITHgrc292UmhFanFFeUIzOVV4WGJDMU11RTFla0g1TkNCNzg3aFhZ?=
 =?utf-8?B?c3hmdFY3MjZjWnNYUCtLS1FySDJHVml6NmhndmpSMFZGRzNsL0FUY3dIMi9P?=
 =?utf-8?B?MTZVbmpvaHRsNWtDTlh3RnQ1OUZCbmpvRFNIL1lVU3FUQklaazVpOFljVnRO?=
 =?utf-8?B?cUZ4N0EyclhBVno2eWtqeEp4MGpvRkhnbUo0YWhOd1NHcnRlTEdTdjRzY0h6?=
 =?utf-8?B?QzB5UDJqSERJcm1HVkZ3UEhrZkJTMUN2cHI5dGJIWU5MMFFkUlhVSzJpRk1X?=
 =?utf-8?B?bTdVYmtMa25wZi9WenJOQUU1emhOVzR5R2pmMEh2dFBVLzNJWW5kajZJU0M4?=
 =?utf-8?B?bmJvc2c0RTB1Y1c5djducUV4ZmI0bkdoTWM2dlVRQ2xZT1lVd1U5dDI5S1B1?=
 =?utf-8?B?S29jTVgrSlRWbUk1VkNXRENxQVBMUWpOVCt1bEZQODhKbHZmSkFSeU41S1pL?=
 =?utf-8?B?MFFOZjduY080RWIwOTFtOE5ncGIvc2p6d2UvaUFyOVlaS0E1Sktza1pWVzI3?=
 =?utf-8?B?ajlyWk1tbFViZ1d5NWN6N1dlUGprMkU4cStST25PZ0U5MlhUUlUrWXF5MUpl?=
 =?utf-8?B?N2tMcHJVYWw5a05LakdXTGtLbEY2ZTc0NkZxUjBNQkZ3UnRQWThNY2NBNlJn?=
 =?utf-8?Q?ft2ue6+X0BmFija5ijoqH9SxL?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b5bb47a0-5346-4e8d-1b62-08dbbaf621f3
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5984.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2023 22:57:29.9616
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VTnQCsCjzpQoLDYPxKKzZYQyvKhD6ZPK42wX8/OhEpuxUQ/CU6GhUSYD+qQrNebOY1VCk1n7D5Y30gjywOH+Xw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB6988
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 21 Sep 2023 15:58:28 -0700 (PDT)


On 9/20/23 19:51, Jeongtae Park wrote:
> ERROR: code indent should use tabs where possible
> WARNING: please, no spaces at the start of a line
> 
> Signed-off-by: Jeongtae Park <jtp.park@samsung.com>

two different issues?

> ---
>  drivers/cxl/core/memdev.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c
> index f99e7ec3cc40..ce67df163452 100644
> --- a/drivers/cxl/core/memdev.c
> +++ b/drivers/cxl/core/memdev.c
> @@ -935,11 +935,11 @@ static void cxl_fw_cancel(struct fw_upload *fwl)
>  }
>  
>  static const struct fw_upload_ops cxl_memdev_fw_ops = {
> -        .prepare = cxl_fw_prepare,
> -        .write = cxl_fw_write,
> -        .poll_complete = cxl_fw_poll_complete,
> -        .cancel = cxl_fw_cancel,
> -        .cleanup = cxl_fw_cleanup,
> +	.prepare = cxl_fw_prepare,
> +	.write = cxl_fw_write,
> +	.poll_complete = cxl_fw_poll_complete,
> +	.cancel = cxl_fw_cancel,
> +	.cleanup = cxl_fw_cleanup,
>  };
>  
>  static void devm_cxl_remove_fw_upload(void *fwl)
> @@ -1010,7 +1010,7 @@ static int cxl_memdev_security_init(struct cxl_memdev *cxlmd)
>  	}
>  
>  	return devm_add_action_or_reset(cxlds->dev, put_sanitize, mds);
> - }
> +}
>  
>  struct cxl_memdev *devm_cxl_add_memdev(struct cxl_dev_state *cxlds)
>  {