Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <f20b9e78-3a63-ca3e-6c04-1d80ec857898@intel.com>
Date:   Thu, 21 Sep 2023 23:25:56 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH v5 09/12] iommu: Make iommu_queue_iopf() more generic
Content-Language: en-US
To:     Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        "Will Deacon" <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        "Jason Gunthorpe" <jgg@ziepe.ca>,
        Kevin Tian <kevin.tian@intel.com>,
        "Jean-Philippe Brucker" <jean-philippe@linaro.org>,
        Nicolin Chen <nicolinc@nvidia.com>
CC:     Yi Liu <yi.l.liu@intel.com>,
        Jacob Pan <jacob.jun.pan@linux.intel.com>,
        <iommu@lists.linux.dev>, <kvm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20230914085638.17307-1-baolu.lu@linux.intel.com>
 <20230914085638.17307-10-baolu.lu@linux.intel.com>
From:   "Liu, Jingqi" <jingqi.liu@intel.com>
In-Reply-To: <20230914085638.17307-10-baolu.lu@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cVM3YTdLazBPZlJpNEdXQWdZZ1MwTkloVjBodndkRlZQb1dvUnpnbHkybkxa?=
 =?utf-8?B?bzRkdG83YzNlSlN4ODYrMkl3NWxYZXRkb0ZLRUFHbk9WQTNxbXZQOHJuUzhl?=
 =?utf-8?B?cjBIN1dPUElGZVFpTWlKQ0NWVUpIY1RIZ1EwT0MxTkVCUFFLUjJQTE1ieUR6?=
 =?utf-8?B?TVVhbHNpTW4zZVlhek9pSDZjS1ZXWVh2TnNYN0RsSmMyOFhaMGFJMllJSzdS?=
 =?utf-8?B?UjMzVG80aEFJL2FDcTRRa3BIQk9BdDhIQkhGLy81aGZNdzNVazg1WjFkM3ZX?=
 =?utf-8?B?NGg3TW9ueEp0RXpVVkJuVG5LYVUweXBXSXQwNkJuV2NUbEtqSjBmK3UxRFNs?=
 =?utf-8?B?NWJaR09kclFvclZ4VVlySkhxQy80RE5XdG5PbXVaSHVlZDlyVlNIY3Q0RWFW?=
 =?utf-8?B?WG5ha2g3OXlaQlRkSEpJZVJrT2g2eUpEYmtrY1FsUnZ2QnB3ODZsZExicmZs?=
 =?utf-8?B?WEg4NzkyL2FjalNDeHpHdWR2S0dHaGpaRUR5S2IwbG9rTncvaGdNWFppRTQw?=
 =?utf-8?B?ZlI5bEdxTjNiNVRPeFB1THo2Y3IxWGlTbmJXREhhckdpQVR1TlV1eUV5VTdk?=
 =?utf-8?B?N2RieW4va3FMenpWUHo4OVZKdEhoVlhkcFZ0N2c4UnVoMWIxdmswTFlGZjlI?=
 =?utf-8?B?cWc3VGN1NC9tZUp3WnVGUFZIdVFLWCtPUzE2UFFabzVNY2FZQm92MytENjht?=
 =?utf-8?B?aW9TZGFrZUpYOVI0Uit2QVFvcDAydU8yN0ZISjJpWnJ3NXR4UkxIeXROWU5n?=
 =?utf-8?B?aHc2TVNpeTBIbGJEV0FvUW8wVVNtc1R0elRkaDVTS2dScnRqY1BEajhmTGZO?=
 =?utf-8?B?Yk1BQ091Q0x5bmw0K1RkN2VRazIwZ1FMdDdlQmNhSlJsWFNUOUpNYXVuV2Qz?=
 =?utf-8?B?VDdHQUtKT3dzZ3ZSaE1vRXBFNlZZZWJmczhDOW1wMnd4M3JVcSsrRzFGMVd5?=
 =?utf-8?B?R0dHejBwQW90aEJMV0ZUSTA5b0srR2VnbVdrdzFIcTVzV3liUTV0OXpPY2p6?=
 =?utf-8?B?ck9FUy9DSU1XYXRFNm1CZWlMeW9aa3hmNm1HK1VjYlZtdEtDV0x6a0RobUxJ?=
 =?utf-8?B?RkNkMUtyZitDT1VsZTRqd2VTS0tyTWtHbk9QUDBoZVA2YlNjODNvTGtMYWdC?=
 =?utf-8?B?YTVLY3pGbC9VdU5QYUpva3ZjMnQwazQyWUVXV3NDb0hGb0tydU9NVisvN0Q4?=
 =?utf-8?B?K2RTbGR5K1hHSXI4UFN5a2hsVTZiR0NoUjk2NnRaVWdtV0grOG9tamVTdkRr?=
 =?utf-8?B?dTVwaVNIdlN2cWtQdzBCRThPYkwwZFJLZE1iR0p1ZC9rWC9MMVp6T3JLT2xJ?=
 =?utf-8?B?SFFVZVhJTmNLWjFnNU5ZaEVMOFpHYldjbHhXWWZOTW4rSjROd2gzNEhFeTBr?=
 =?utf-8?B?VnJQSExCYlpONktkUjZwRkFhcWQ4S0N3VysxS25tcWw3NXozOHVScTBIS0Rs?=
 =?utf-8?B?Z3JoQ0JwWWhKUzIxMk5mVzEzQURIaFFlMklESk1ZbWJSNERpaHpkY2kzMWNR?=
 =?utf-8?B?L01RYWk2TW10ZXB5MU1YdHpSdTd1RnM1Y3R3aXFIeDkxcU1HdjF5eHl3enBC?=
 =?utf-8?B?U0FiT211UXRQcmQ1dzRiQlRhRTlNV3pvVTNYYllIdjk5eklJYXRDdHNVUS9U?=
 =?utf-8?B?cGNCUlBEdGhzdkVuKzdMbm8wcnQ2eEp2ckpBWGxNTyszZDBpc2lKN3AvWXFH?=
 =?utf-8?B?YTdrZzlmU1AyM0R1ZlJVYWluNlBCaG53a3JxcmZvQWFlY2FvTHAxZHFnWU82?=
 =?utf-8?B?TXBwUHpySHBJaXFNNE9uK3o4SjZTRlk5Nk1CS3JVUkVFU0Y3VUFoQlQrdysz?=
 =?utf-8?B?bGVEZ0FQMEdrYVNYZ0RQVXZFZFcxbGdpSXRKWHBtWGMxeWZBNnpJbkV4QkZx?=
 =?utf-8?B?UE8vbEFnSk9xUmwwQksrWHdDMHY5QlhzS1FDU0d6cnJUY1pVeFU0SVlOV3Q3?=
 =?utf-8?B?VXZwUGxXcDMzKzhKSWZHWXYya2lhN1BmNU0wOWZtUFBWUmZudEtxQjI0dmw0?=
 =?utf-8?B?bnFSTHpXYi9rZitPU3E4ckVsTGxiNitQS051UXJxcGk3elU4c1E2cEhsUlpG?=
 =?utf-8?B?WGsrRmE0MGRlUXltMEYwUEdrMk45Q0ZKdjl5MVRkODU2RmZvbGZPeVNsc0lJ?=
 =?utf-8?Q?nrEaTGIoudLfPFRWWm/EeeMuX?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 82e18e2b-d6b5-4229-28de-08dbbab71445
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5469.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2023 15:26:08.8217
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SB6rDNucE+MLHzuSx9M2UQ14AYs45YsJT2tFDkQCuBLq7dKvD+SpscMX0onsnkXjCJEs6LTmrHL5Rx78BsINLg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4891
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 21 Sep 2023 13:47:35 -0700 (PDT)


On 9/14/2023 4:56 PM, Lu Baolu wrote:
> Make iommu_queue_iopf() more generic by making the iopf_group a minimal
> set of iopf's that an iopf handler of domain should handle and respond
> to. Add domain parameter to struct iopf_group so that the handler can
> retrieve and use it directly.
>
> Change iommu_queue_iopf() to forward groups of iopf's to the domain's
> iopf handler. This is also a necessary step to decouple the sva iopf
> handling code from this interface.
>
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> ---
>   include/linux/iommu.h      |  4 ++--
>   drivers/iommu/iommu-sva.h  |  6 ++---
>   drivers/iommu/io-pgfault.c | 49 ++++++++++++++++++++++++++++----------
>   drivers/iommu/iommu-sva.c  |  3 +--
>   4 files changed, 42 insertions(+), 20 deletions(-)
>
......

> @@ -112,6 +110,7 @@ int iommu_queue_iopf(struct iommu_fault *fault, struct device *dev)
>   {
>   	int ret;
>   	struct iopf_group *group;
> +	struct iommu_domain *domain;
>   	struct iopf_fault *iopf, *next;
>   	struct iommu_fault_param *iopf_param;
>   	struct dev_iommu *param = dev->iommu;
> @@ -143,6 +142,19 @@ int iommu_queue_iopf(struct iommu_fault *fault, struct device *dev)
>   		return 0;
>   	}
>   
> +	if (fault->prm.flags & IOMMU_FAULT_PAGE_REQUEST_PASID_VALID)
> +		domain = iommu_get_domain_for_dev_pasid(dev, fault->prm.pasid, 0);
> +	else
> +		domain = iommu_get_domain_for_dev(dev);
> +
> +	if (!domain || !domain->iopf_handler) {

Does it need to check if 'domain' is error ?  Like below:

          if (!domain || IS_ERR(domain) || !domain->iopf_handler)
Thanks,
Jingqi