Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Thu, 21 Sep 2023 13:44:47 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Baolu Lu <baolu.lu@linux.intel.com>
Cc:     Yi Liu <yi.l.liu@intel.com>, joro@8bytes.org,
        alex.williamson@redhat.com, kevin.tian@intel.com,
        robin.murphy@arm.com, cohuck@redhat.com, eric.auger@redhat.com,
        nicolinc@nvidia.com, kvm@vger.kernel.org, mjrosato@linux.ibm.com,
        chao.p.peng@linux.intel.com, yi.y.sun@linux.intel.com,
        peterx@redhat.com, jasowang@redhat.com,
        shameerali.kolothum.thodi@huawei.com, lulu@redhat.com,
        suravee.suthikulpanit@amd.com, iommu@lists.linux.dev,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        zhenzhong.duan@intel.com, joao.m.martins@oracle.com
Subject: Re: [PATCH v4 01/17] iommu: Add hwpt_type with user_data for
 domain_alloc_user op
Message-ID: <20230921164447.GQ13733@nvidia.com>
References: <20230921075138.124099-1-yi.l.liu@intel.com>
 <20230921075138.124099-2-yi.l.liu@intel.com>
 <0d37a1b1-e7ef-fa73-d17c-629cd254ae75@linux.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0d37a1b1-e7ef-fa73-d17c-629cd254ae75@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zzHJmDOEMyrwqJOXPnv0ojedd7N0bhyC5LHiRjcVks5mPmnS4dT/XtdLVknB?=
 =?us-ascii?Q?VrXBl1JlqJi5wCG5LdUJ7oeEe2bW5jZPKofaekNpwE1b+Smj9nASH4xeY9vi?=
 =?us-ascii?Q?zI15g7FVqGS5B3E3dpcyMKxkwOmz3YgMt8wWFtblJwrRmGISzcy3bfvgjyPR?=
 =?us-ascii?Q?IBDwANEbwHMIyEXWsREudBBqIYfOo3NRmr+e9ZWMj2li7zayW8WbcwZvM0a6?=
 =?us-ascii?Q?STld50oUKRrqzxTw6fWM4w0bj7DYS9heFrKwOGgQGNtShNXLsDXW1A0fiRqc?=
 =?us-ascii?Q?SyTM3cfY6OOYyE503Ccl8xWVuae1siGwGoBMXwWbaH6UL6OumFb/H3ApFgu1?=
 =?us-ascii?Q?77qiUWQbIsOqw7ntMTe9ehYAx0kykHfHgPc8CxNsxDP+MYOGqewNoXChSQcN?=
 =?us-ascii?Q?ZHH5FFio1lG/Q7X1aOrQEp5LmPg1p/VDDfFNe3j5FkPpUSzxw7Gikdn+7Bnv?=
 =?us-ascii?Q?vVgjyDyDi3t9oOW/8Jq+VEpHeZdrnQR2DGqAF8+YUf6epAFCtYpohniFFnum?=
 =?us-ascii?Q?rFSysKBz1GE6RyMUKt9bJ6zS32OvWF7DrWcIByvCzzqByyzQPzKzfIuyju7O?=
 =?us-ascii?Q?eMYVY4ZiIaTe7/bXQbek8XPAn2rhMI+59BnXvevoApoRA0f5hP42SUe7Znd9?=
 =?us-ascii?Q?GpXwisDNGIAViWWxoUlqtEdHR/CsX7aK1Yz/Tt3NneOpAL9sm1FxRGTTw4yY?=
 =?us-ascii?Q?SDUxnKOwftRXNb/LHYbsMx2//FxYf2DuR+JBDCDwxj7Ccr6H+S5Rhxm/niSc?=
 =?us-ascii?Q?YEWwBFEKw5ydUhh0JlecNGCYQ1m53bmpKFPuhKQenPWFais5hfoqqptScJwO?=
 =?us-ascii?Q?THJK3chCFFN1+yKbKJ8OhC3ZzF27qYhWjhQiRK3vO0z1vGbVoJbWhSthkaom?=
 =?us-ascii?Q?4d+sBGpcB7h/Rt3D4o+M1GczfKui9W+EzMl9A/aTeHSrhgRgYe2KLzOeUfnY?=
 =?us-ascii?Q?lawYcxXE1BteBjxc+ibzID4SVcom3CXVpEnmGVkH9Fs4+5t24a94XFboaHZy?=
 =?us-ascii?Q?M1rWFBSniv3zx5rt0+uq8/kqidHpdxPqOuqSw7ie64QCzabodCVROv+QZWq0?=
 =?us-ascii?Q?ew2sVphoGqbk+hPGqDYtZ3rMDq8nLqwZynn8ueRvNB+ar4PdrO+1ix/QC0Z9?=
 =?us-ascii?Q?0kkQ2mp1Twt0EGGEeegK8NIRgs79yvYOowNYwEnto9MaRjPhZT2mO0N2+Agm?=
 =?us-ascii?Q?pE9HkNL4ZUdES1X0k12nfsC3rEzu9EOWLoTze/H8hR9iF9a9zwK7jAwvoqiV?=
 =?us-ascii?Q?5PImkBXJ9DSL38duZdmLFavEjB0x15VWdEd0+74aVLnirLGK6gf96loSBsHF?=
 =?us-ascii?Q?DgrQZNKgRG+qWVqIjg5iKaxlmEqMGGisEK6CU3a744wqNMXME+X+8Xi3yudu?=
 =?us-ascii?Q?1/viMRmOyAZklY5aktvLC8RCWalXp/3C8gnKZDOKAylWkoDahv/TIgUiO11H?=
 =?us-ascii?Q?YWQqpu5omKYb4J1rJnWy5V11cl6v4yhIvxnsPdvS9/kXjGwRUNxoSVDjcO7j?=
 =?us-ascii?Q?sx8Vh6zvDTUa7AXl8zqglH/lK04DhyFludzWDKywA/oTuFwXPby8cK614123?=
 =?us-ascii?Q?oUckI8c8T35psDqiLWCyrLUpF2EeQkSF4B9fbMjW?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 250479ac-4ca1-42d5-8b63-08dbbac212bf
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2023 16:44:50.5818
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GpA8V5sFHJBBnjK23WLo50G7XeczJiV7cbYBTFIHMo/GoG891AmAF70AWUvaJhwq
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8840
X-Spam-Status: No, score=0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 21 Sep 2023 09:56:41 -0700 (PDT)

On Thu, Sep 21, 2023 at 08:12:03PM +0800, Baolu Lu wrote:
> On 2023/9/21 15:51, Yi Liu wrote:
> > diff --git a/include/uapi/linux/iommufd.h b/include/uapi/linux/iommufd.h
> > index 4a7c5c8fdbb4..3c8660fe9bb1 100644
> > --- a/include/uapi/linux/iommufd.h
> > +++ b/include/uapi/linux/iommufd.h
> > @@ -357,6 +357,14 @@ enum iommufd_hwpt_alloc_flags {
> >   	IOMMU_HWPT_ALLOC_NEST_PARENT = 1 << 0,
> >   };
> > +/**
> > + * enum iommu_hwpt_type - IOMMU HWPT Type
> > + * @IOMMU_HWPT_TYPE_DEFAULT: default
> 
> How about s/default/vendor agnostic/ ?

Please don't use the word vendor :)

IOMMU_HWPT_TYPE_GENERIC perhaps if we don't like default

Jason