Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <ed6eafdf-d788-5eec-1feb-ef7d56184715@intel.com>
Date:   Thu, 21 Sep 2023 15:04:35 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [Intel-wired-lan] [PATCH net-next 0/3] net/intel: fix link-time
 undefined reference errors
Content-Language: en-US
To:     Jacob Keller <jacob.e.keller@intel.com>
References: <20230920180745.1607563-1-aleksander.lobakin@intel.com>
 <f05c2a5b-d434-5edc-828f-4b87049d01fe@intel.com>
CC:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        "Richard Cochran" <richardcochran@gmail.com>,
        Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
        Michal Michalik <michal.michalik@intel.com>,
        Milena Olech <milena.olech@intel.com>,
        <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <f05c2a5b-d434-5edc-828f-4b87049d01fe@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NXpqOTV3enMwdWxNY05MeHFKQVVIbW5Ca3dDMVVsR1JNZGJIY0cySk85bHM3?=
 =?utf-8?B?T210VGtFdjVqenN4dlF2dDc0V2ppNWFHYzZVSE1ONEZkZ1JFQ1B1dlF2RXpQ?=
 =?utf-8?B?K0JZdFRaekx4ZmRqU2JHY2c2bHo0L3I4U29HWExVZkJWU0pWcVJpV0YyWXVG?=
 =?utf-8?B?T1Frak8rOXRBa2RhQ1dtejJsK20rTlk5Y0x5S0JCVEtaYkw1Wm1YTDZ3YURS?=
 =?utf-8?B?SzUxVVIrM3BObUlXNTg0aEY5dGVTQmhVNVVmQVBHMGxNYS9DYzlJa1FzUEZX?=
 =?utf-8?B?dnFzQkMyZmd6U3NyZHg2Z2pZS3lrUW9zVERoeVhualNyUEZESUNJYW8vZXRq?=
 =?utf-8?B?UTdjRjhmQVhQRnhsS0c2b0Q1WXlCMUtyUkU3VWVYRS9Ldnh4czZLcmFCSG9I?=
 =?utf-8?B?UEdmWkdRb1MwL0RhZ3dLTElpL0w4NmE5RE81T2FHM0QyZlZaSTFkMzZxVGxr?=
 =?utf-8?B?MmUxdGhnK3dyclUwcjJyOHNqcGIzVWQ4cnZMTlpwSlFjbUhlOGdPcnYyNFlw?=
 =?utf-8?B?V2lyNU1Ua2k2Tng5OWx1T3UwYkFLbFFxcndveWN6SXlTejdmbTc1ejlsNFRL?=
 =?utf-8?B?MitqcE05dWY5WGt3S3BsV1JvNFJUdVdDUldQUnBaVXZOc2IvdzVhQm9EaDgy?=
 =?utf-8?B?YXBXNFJ1ZlBWcnAyR1lnblZ4TlFoVTFkUVBHWEF1Wk5CUnhFL3JJU0g1ei9t?=
 =?utf-8?B?UEE3bXZuWGRVTHRNSG1iNm4yRGpEcTdZQWl3aEZ5aTBlaUtNaEkrcXVGSHAv?=
 =?utf-8?B?SU9mWWpvNTlDWk9udzlEZ0gxMUUrNHBSREZGV0ZZUTVYZktoOS94Mm80WnVL?=
 =?utf-8?B?MjFwNnAzdW9WaWpFN0tvbXpud1FOQUV1aUZoSk45VGdjN3VTcDBlazNuVjM1?=
 =?utf-8?B?a2tQU1ExTnl2ejJXSjk3TzF3YzlTNXNVMXpQQlIyenMxZWJ3NEJLL0Q4VmFh?=
 =?utf-8?B?MWVqcHdHRytoaDZjYVE2UVRlUDNxUWdCMGVHOURBa3YrK28yYnIwdnczNkkz?=
 =?utf-8?B?SXE5Z0xxaCtuUEt0elpKLytyaVUzVEhiV01MdEMxK01MRnpsT1lTOVFMTFVG?=
 =?utf-8?B?QlZlQVRYOTVvVUJJYUpOVEFXMWtpQ1hVaHJZa245T1JBaHVGS2g5MHczZkp5?=
 =?utf-8?B?T2tQUm5FNWpyU2Q1QlI0M3NLRXYrNGVuK0VHNlpMVUE2bFp3V0pTQUxFV3Zj?=
 =?utf-8?B?QmJSQlQ2WGpQNm95cCtxaDhKNGdSVUhBanIrdktJSC92Yy85OGpXYmxzeFYw?=
 =?utf-8?B?TUh5Y2ZaVWpHQmdqV2ZPQisyQlFDTUxkSGF1eW8wejlKZStTaG4xcExuTFpn?=
 =?utf-8?B?OWhpTTRaQ1ZGZ0Rpanhockp2T3FORDVrMXA5OUNsUGlkdzBQcGZ2ZlNpbHVx?=
 =?utf-8?B?bUJoNUtFQXFRSjFiVTFQZndBWk1kdklJZkdhckprNmEzT0pIaDBGbzh6elc0?=
 =?utf-8?B?N3hKQlRaelVVdXhBUWxBMlE3dGh2QkJxU3RpdFhBQnI5aTRGWkp3dUlPRTFn?=
 =?utf-8?B?YXFvZlovcmIvbUpDdlY3TXNKRzFSeHNla05XVFRjRkxsVzM3b1VIbWpoeXpo?=
 =?utf-8?B?TXhhb21YR3Q0V1B4NlFoVGhBNjcwSlNsdldjdGp5ZHc1MnM4RGhxbXU5MEt6?=
 =?utf-8?B?STBYZi9BQUM1MC9DZ0JRTDVJOTdqM1p0VUxCTFhzMm0vVHJ5aXdKMlkrSHR2?=
 =?utf-8?B?dlNVZUsvaXFvb2krN2RoMEVzb3p0NEk2eTJWVzg3K1U4VTFhaWtjTGtxY0hU?=
 =?utf-8?B?UFhleGUvZ0RMeFAwbVZMdForZE9OaTk4Z3ordGtFdC84dDhybWErUVhvOEZv?=
 =?utf-8?B?NGxuOEErZWRyZzFxVXFlRTFKalI4WER6Qk84V1gvVGt6N0pBUzI5NXljVk16?=
 =?utf-8?B?VktaK3piMWdBaS9TcStuMVFZSVNjZkR4UHBxWE9ZdlpqdjJ0Qm1oSkt4SGti?=
 =?utf-8?B?NXVhUEZBZmc0YjRVNmxVV3F2K0twakZTWjdKZWNnakIrTnJkOFFrTFpvbi9K?=
 =?utf-8?B?RGlxSFl5L1h5Q0sySmtNcWxzV3loNzZNWHZoMWhVMG9ualVGWW56YzVrVDBJ?=
 =?utf-8?B?ZlQvZWZLZVhEdDZ3RmtMTWtMaXdQQ3ZmWTYzTFNDd2NhVldpRldjQWVXWUly?=
 =?utf-8?B?ZUVyWHk5eHl6WHpYMUV4SUlodTJpV21pWDBUelhqZ0hZTHZURUNOVkovU3lp?=
 =?utf-8?B?THc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c355a32-96de-4323-c60c-08dbbaa36dea
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2023 13:05:29.1877
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: R+jYFNazd6Pg2SJChtvenEFIBf8V8LIAgP1LgFNqZmeqju3KrjVHeKhal00qR+D0sTeu1iG/ROMfiq+mRWWz2ZJcFnnOeRcJ5RfcbT4lZOc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8361
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 21 Sep 2023 13:50:24 -0700 (PDT)

From: Jacob Keller <jacob.e.keller@intel.com>
Date: Wed, 20 Sep 2023 16:31:27 -0700

> 
> 
> On 9/20/2023 11:07 AM, Alexander Lobakin wrote:
>> Recently, several link-time issues were spotted in the ethernet/intel/
>> folder thanks to Kbuild bots and linux-next.
>> The fixes are pretty straightforward, just some stubs and CONFIG_*
>> guards, so resolve all of them in one shot and unbreak randconfig
>> builds.
>>
>> Alexander Lobakin (3):
>>   ice: fix undefined references to ice_is_*() when
>>     !CONFIG_PTP_1588_CLOCK
>>   ice: fix undefined references from DPLL code when
>>     !CONFIG_PTP_1588_CLOCK
>>   idpf: fix undefined reference to tcp_gro_complete() when !CONFIG_INET
>>
>>  drivers/net/ethernet/intel/ice/Makefile     |  5 ++---
>>  drivers/net/ethernet/intel/ice/ice_main.c   |  8 ++++---
>>  drivers/net/ethernet/intel/ice/ice_ptp_hw.h | 25 ++++++++++++++++++++-
>>  drivers/net/ethernet/intel/idpf/idpf_txrx.c |  3 +++
>>  4 files changed, 34 insertions(+), 7 deletions(-)
>>
>> ---
>> Directly to netdev/net-next, build bots are not happy and the next
>> linux-next is approaching :s
> 
> I had alternative fixes for ice at:
> 
> https://lore.kernel.org/intel-wired-lan/20230919233435.518620-1-jacob.e.keller@intel.com/
> 
> that are slightly more invasive but bring things in line with changes I
> had proposed earlier before the DPLL code got merged. See:
> 
> https://lore.kernel.org/intel-wired-lan/20230919233435.518620-1-jacob.e.keller@intel.com/
> 
> I'd obviously prefer my version of the ice changes, but I understand if
> we prefer a simple more 'obvious' fix be merged now. I can spin my
> changes again to cleanup/refactor in a follow up if necessary.

Go forth with yours. You can take some of my pieces if you like them
more if you want. I just spotted both idpf and ice reports at the same
time and was ignorant enough to not look at our MLs (internal and IWL)
first.
I'm respinning IDPF solely.

> 
> Thanks,
> Jake

Thanks,
Olek