Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Thu, 21 Sep 2023 15:54:43 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     riel@surriel.com
Cc:     linux-kernel@vger.kernel.org, kernel-team@meta.com,
        linux-mm@kvack.org, akpm@linux-foundation.org,
        muchun.song@linux.dev, leit@meta.com
Subject: Re: [PATCH 0/2] hugetlbfs: close race between MADV_DONTNEED and page
 fault
Message-ID: <20230921225443.GC21193@monkey>
References: <20230920021811.3095089-1-riel@surriel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230920021811.3095089-1-riel@surriel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?u6vgYfw3Y+BiapElvZrY4k18myW7FciFeq6lK6eFDeWEnmwo/9LKjDHK/nRC?=
 =?us-ascii?Q?Ie7K8FdU22QsH1T3js/kOgRpCgUkx+kkTro5GE+Y5rhUlvIASOdHXmqFyNEh?=
 =?us-ascii?Q?WgJ9uDhKNUIh2Cw59gnGBEscrBNaTf8Y/+9kfKEjRQ9Au33R9JNMu8dfJ8j/?=
 =?us-ascii?Q?7dLRpER3rf1AVQaOZRfYOI8Kgurdcl67nxc18Ho4jop8fsBZtZTouYl/QSm/?=
 =?us-ascii?Q?leXenoTSkLhidm7En2Fhbd3hbnvpTE5iZbbF2lrQyT7+0R+Z9eDzcDV5ysu1?=
 =?us-ascii?Q?1ZjSW2I+SJdMJQuWyTwBpVh8kU3/HIPy+YXpdZwD4jtS9+Ct6HJAkBI9miF4?=
 =?us-ascii?Q?OsYGwB5igpbyrImaLYP4lwxPk7zY9Qx1YnUeprO1laOTURKZ9uVxQYjtizvI?=
 =?us-ascii?Q?HaQCSq7bZ2t6lpaDhrBM/lmuQiFEqhPJeXawuZZe4Ngffd9l7n6wOVbXMOfz?=
 =?us-ascii?Q?WJsH9UPetgwUcEi6djL/xA7NrCB+FVim/974JY0sBnWrZn2AWWE2/YiBBLma?=
 =?us-ascii?Q?VRv1ghFYBx03R+YAYyl9m+BF7oTx0Lvh5dyiPVqlUyBrzV3L9/7nNnYYyQJN?=
 =?us-ascii?Q?4yuIhY4Iugwm29ZkTdplX/dRrBQqyJCCv8QzM0yDb+VqYFfOJFzCkI80E4HF?=
 =?us-ascii?Q?ZuKZSiFFWFVwBVAckvlsJj88DvcoqlTmVV4ILjOAx/wnawxLTuXvyv78Op0D?=
 =?us-ascii?Q?fhp+g+UqqblMA9NU83RxY7g2ujTHH7l15ADIBIPjiYG4yIF0fKBjV16YLULN?=
 =?us-ascii?Q?4Nzw3HC1Rtqw6uI2dCJp2Es3RgIUFM02fiakVSI1EKr/nZnQFji2sfKMS0SH?=
 =?us-ascii?Q?rmNl68+LJ8NpIrkgBK+NqQVFw1Aw2T7pGHOMZCqxlEcEZn5qMMURXyY+3o0p?=
 =?us-ascii?Q?PyKSp0qs6sRSlYIZapLkb6aqBXskFKLIPTToLMzi6I+n+5hwWHaZZSgSWONu?=
 =?us-ascii?Q?Rqf6/FPy9vib8VQjhVtjS7mwyo+qmlfZ53B/S94OzjWgXPMa2jDt8IvYWPjf?=
 =?us-ascii?Q?NjpEIwbFBOgNAyztG21s68IDBTzCpUqi20Pv7wAm0g6tEk38PogzFK6vzA4g?=
 =?us-ascii?Q?YKlGfSJQ744gv1j/8MbEUGINX407LcfYVGLh1rSRKB/Q8+/dbBsoniSaKiS+?=
 =?us-ascii?Q?S10u+9lOLoG0+vMghLt4813OPhZ4w0IQP9tBuAVkFGByen2jNeaGBny82Vrh?=
 =?us-ascii?Q?EBvibDwvk+MSBzzUaZXX3RHMPaiiNYXNwJRfJm+RgVQIQsR0sZcYhEdVULa5?=
 =?us-ascii?Q?jG17r39DsdBzCW1eTxK5rr6FkPT+hhE4KZ+AsydrORQ0fLsCy4UpjS/rOQ3S?=
 =?us-ascii?Q?0yZZxrsGxCmYVm4YIu33Jw4dE7wkP59dwjnVHCvHvudQReinZ1h+6O/rtt4K?=
 =?us-ascii?Q?ytOMPOCbBNXvkIcgOvS5ZRrr0x+BfE2iXxnkT9l9fZ8GFib67ZDBAg8ztuIa?=
 =?us-ascii?Q?cT+9JKzsht8rxmRZ/cC6NEKf7UUWB4YmAxYK7N1fZahEqbowbFupk37Ascoz?=
 =?us-ascii?Q?WBGqy0uQpD4LNMFy5qLmaAcdA1Uua9Jb8imAHHgLtbd/oVKw0L6FMSZ+qbCz?=
 =?us-ascii?Q?8YyClKOaxD0sajDSQvaoJaHKP1ukdkjE7dgY/ogcRazGbtfwLLfsg7ANnXQo?=
 =?us-ascii?Q?Og=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 1svX8YJAZNSGDdh7PvUs0bcFYr92bCc2UqXhzBU6PSXqhaTx96d/UQjaZWsW5mF9Ll+rUpsO1g0WRvAEIB6sT7MnB9A0S7lJoHEN9Cc5w1T7tKb1ClzJfBM87kBj/6v2/UFodJNPjiiXtn9fybud7pUagRB71FAx2+KTSG7q4LULRf6R6vz7q04kUaPYeRuDyrX9LkygX50barTZcu+E1GB/G+Twc6FULMR8Mziv9/IffVMxYL+1vLaWAwXIStZP7jwg19DlEjwk7V/wmfLe2ZfwuqeKGt7u0GvX9kc+QEW5uFllmh/thfLlMObeha9zrJCqkFMY9DWt1KKnRuytMnHiWnp4Qts6/R0eYA2KiF1QODJE4OeuWvk+pVFN7aboKoWxIynVghavRfdtPzT6kDZgajG8J0LRxrCZ+5ich/y4ASPoDIHmBtr6qPMO81nCCDTX3mVBDg7AD4cvK4mVTUOL5B8alcDff8FGPyg0gNZu9CsFJe2E5H2sbwKQDAFknpEvOuf9enkewyxJjA+KsTBKeU9m3KNXyAAVCjyGysrAxoqFO1BD9zm5fhF+Q4gbjMoc4jJaveKjYWFYdcFWoqPPj1UrVZp/b2alXpZQsF6LFvyGczYghkgOMBBboRF42INs8sJML7Qg6bu7TKiQRmIE6VnNnfJ5tKp8bdgq53yVFSv/QDj3gCA9c+Xmsx/I5yK246FIFsdg1mJQ/fqzUPV7gK09drZfCvJOG/3X6/hirnG1GpU59N1uE1CrNt8XrNuKr0HktG+6dWJWbasFufCbmN1BhvgX9jaiYeUhGniUgGrFsLsF/H3qQ1GG7eb2ZBm3eEMP1PO1nvE9VApj15oCiTHW0KxIFRW0m05Fq0cW/9v8yovCe2dh/irlq8tKgaS76RTb1vgb1hFTbLtnpa0TiYn5OD636XRORdeACE4=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2762671d-a94f-4e9a-50ca-08dbbaf5c0b0
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2023 22:54:46.7508
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RQDPommWgONLfCCln5+RtAOKVAH5bKfnK9G2RH8hRaa8emgHqZ+kg2Y1RuBJVbe6pAyjG6PIObj7tA0LsCTJvw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4506
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-09-21_19,2023-09-21_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 spamscore=0
 suspectscore=0 mlxlogscore=633 phishscore=0 bulkscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000
 definitions=main-2309210199
X-Proofpoint-GUID: T4lF5wFqcz9aGWTtGD8kFK70CzSL1Hq2
X-Proofpoint-ORIG-GUID: T4lF5wFqcz9aGWTtGD8kFK70CzSL1Hq2
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 21 Sep 2023 15:56:36 -0700 (PDT)

On 09/19/23 22:16, riel@surriel.com wrote:
> Malloc libraries, like jemalloc and tcalloc, take decisions on when
> to call madvise independently from the code in the main application.
> 
> This sometimes results in the application page faulting on an address,
> right after the malloc library has shot down the backing memory with
> MADV_DONTNEED.
> 
> Usually this is harmless, because we always have some 4kB pages
> sitting around to satisfy a page fault. However, with hugetlbfs
> systems often allocate only the exact number of huge pages that
> the application wants.
> 
> Due to TLB batching, hugetlbfs MADV_DONTNEED will free pages outside of
> any lock taken on the page fault path, which can open up the following
> race condition:
> 
>        CPU 1                            CPU 2
> 
>        MADV_DONTNEED
>        unmap page
>        shoot down TLB entry
>                                        page fault
>                                        fail to allocate a huge page
>                                        killed with SIGBUS
>        free page

Hi Rik,

I think we discussed this before.  Even with your changes there is no
guarantee that the free'ed hugetlb page can not be stolen by another
application.  This is true even with hugetlb reservations as the
reservation is consumed by the first fault.  After the MADV_DONTNEED
no reservation will exist, which allows another application to steal
the page.

This is VERY unlikely to actually happen.  However, I do want to point
out that it is possible.  Of course, the way the code is today you will
always fail if there is only one hugetlb page in the above scenario.  So,
your changes will help tremendously and I support them moving forward.

I suspect you are already aware of this, but just want to make sure you
are aware there are no guarantees here.
-- 
Mike Kravetz

> 
> Fix that race by extending the hugetlb_vma_lock locking scheme to also
> cover private hugetlb mappings (with resv_map), and pulling the locking 
> from __unmap_hugepage_final_range into helper functions called from
> zap_page_range_single. This ensures page faults stay locked out of
> the MADV_DONTNEED VMA until the huge pages have actually been freed.