Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp2396817rdb; Thu, 21 Sep 2023 18:35:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGlIQvGkdBBacs9dkdYiiQSUkA2pVgfutUKTByEI13fn18Yltlpg5iZD2M5d+mqqQMzcl3G X-Received: by 2002:a17:90a:6c21:b0:269:6c5:11a7 with SMTP id x30-20020a17090a6c2100b0026906c511a7mr7004957pjj.17.1695346515271; Thu, 21 Sep 2023 18:35:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695346515; cv=none; d=google.com; s=arc-20160816; b=XBnm+5S4rODjR8PI3nqzbw5ccsiMC2BJzyvRY4HkWxjc0CA+bvsDD+j9QmE7rq2DjJ rEm4xT4mOIaxQvHzqgZNi1BKmXt4OZo/MU0k9otYcIwWteYo50WQQwVUAVjAhYXFuJkY 8B7RIHG06o7aaGZSnRL44eR2Yb0tYQCjtRx/owedpfcV1smxA4O0gvTKMBQ/Boa0Af7X jOv2tBP+s28vzYuBEWZiPzXfkzcvZL+Z0TuEDLlBLl5pU+6Z0UB11SaEc6pKg1sDvgQr hOLGfHGY89PN8MvmfzLhUDf2Z8l8QMzyGULNn1BrB3a0agw/VwMsgG3+YxXxzXqtVMih 7xOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=yfOa60jin+Cg2UGV5vWmkOgyjYutq/4P6GMhlzuMcDo=; fh=HKLVqhOuhrqPyBWmsKeG2yNFOUoK3I0Eye1fmm1AuTc=; b=OcM5lIQldfbDB2p8Yco35Nlnzf5XdOBMwBGtQHvrdSq1D8jZP0Jp+GsCVkZfCOOIfg MsS5ZxKVu1y1vxnFJnmBj08EumK5gLyf1QkIv97Mte6tOcX6Tmo+Rn0fL4Br0uW5yvgs 5+YzE3CKssPfCAaa167d8zYnCeIQ9PyGs4OoWH2579pwZEvt8W5FWrvEeOGWGJz8LE+J ErxIUokQCdKxpHGb60ePLSP3evqVUBc9REDkIrg9xTkQdsKF0rnW9hcyy5XuR9p913KV OwDsrHZ8/pia8M69rSwfZ0+AtzfjFZPHlhygrz2lvtuv/eIS7/epCf0om2kK8nMQT7+R METw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=PLJlxNIy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id gf3-20020a17090ac7c300b002748b96d88csi4803262pjb.179.2023.09.21.18.35.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Sep 2023 18:35:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=PLJlxNIy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id E6CDA83470EC; Thu, 21 Sep 2023 12:37:17 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230227AbjIUThQ (ORCPT + 99 others); Thu, 21 Sep 2023 15:37:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230375AbjIUThA (ORCPT ); Thu, 21 Sep 2023 15:37:00 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F8E3FBB35; Thu, 21 Sep 2023 12:12:33 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-5042bfb4fe9so1808573e87.1; Thu, 21 Sep 2023 12:12:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695323552; x=1695928352; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yfOa60jin+Cg2UGV5vWmkOgyjYutq/4P6GMhlzuMcDo=; b=PLJlxNIyWrNPIcQKpgONFau4S/DloaKpWyLed0pKo2Crv3KQpt0eFbXt4pLTZFCKdp 3OtYpe3k+rimHz1mnLNuyb6jWbYZKVk8M0be6iYW26inIwcbup/PcebGVY2GUFhpX2GM MfQ0ZyHe1j/V5UzdKsvsKy58Xf03MkgkZTUG/momHoa7bPC7VBfc+BP85Wa9dGbcpHaq dq13ub1Rq99sqMf2n3Rvz4yTNY9Kkr2Gz5UxScIav7B8ctLx6zGvZutR9bWAv6xe7V6e zE4c/lw9PhyR3eyFacTWFL/l1kfOTy50VGL7RfaUHkyHAbVgmmGwsvnRUzg4QNWCcSiZ ZYFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695323552; x=1695928352; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yfOa60jin+Cg2UGV5vWmkOgyjYutq/4P6GMhlzuMcDo=; b=wIpteHIdYcdmvOa2b3ZaA9H5LSkW6EVH5b/hqQ+7RLZAuqIZx41vSN1NiINb54Zuku aei9OILKIL4ZQR60OsetjnODoZtqp1rmlH6JxTkOdJIV2u2Lw2fD5LYTNkef/J70az6p jK0eMRJ3RKnOl7nxg/0FGvnWFJDYns4hCPQum8RHG2tXWp7X+kh1lN47Xt84z2WYS0+6 hrzAcwf0VW4NgCqbZIO16M9sAmVDrLTlwK5bCfvQ0sMaSZ1q9zrBwkbaILgl5fn7p4bf Sbaho/1fH+c9GlZr9uyXsIdPdq6j7vu68YWvYLi9ty7POWMk4j80//2kiQLQYjED6+FV o4bg== X-Gm-Message-State: AOJu0YxsxCgcKrNp/5piz3fZCGYm9/f/+1Y5dPAMSZN+B/r+WA5CUgcI 1h51DWAbQPbFKLRj3hPkpeM= X-Received: by 2002:a05:6512:3147:b0:500:c5df:1872 with SMTP id s7-20020a056512314700b00500c5df1872mr4619332lfi.44.1695323551612; Thu, 21 Sep 2023 12:12:31 -0700 (PDT) Received: from skbuf ([188.25.255.147]) by smtp.gmail.com with ESMTPSA id l24-20020aa7c318000000b00533349696f1sm1206729edq.16.2023.09.21.12.12.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Sep 2023 12:12:31 -0700 (PDT) Date: Thu, 21 Sep 2023 22:12:29 +0300 From: Vladimir Oltean To: Lukasz Majewski Cc: Tristram.Ha@microchip.com, Eric Dumazet , Andrew Lunn , davem@davemloft.net, Woojung Huh , Oleksij Rempel , Florian Fainelli , Jakub Kicinski , Paolo Abeni , UNGLinuxDriver@microchip.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 net-next 3/5] net: dsa: tag_ksz: Extend ksz9477_xmit() for HSR frame duplication Message-ID: <20230921191229.72v3ndgli66lyhdy@skbuf> References: <20230920114343.1979843-1-lukma@denx.de> <20230920114343.1979843-4-lukma@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230920114343.1979843-4-lukma@denx.de> X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 21 Sep 2023 12:37:18 -0700 (PDT) On Wed, Sep 20, 2023 at 01:43:41PM +0200, Lukasz Majewski wrote: > The KSZ9477 has support for HSR (High-Availability Seamless Redundancy). > One of its offloading (i.e. performed in the switch IC hardware) features > is to duplicate received frame to both HSR aware switch ports. > > To achieve this goal - the tail TAG needs to be modified. To be more > specific, both ports must be marked as destination (egress) ones. > > The NETIF_F_HW_HSR_DUP flag indicates that the device supports HSR and > assures (in HSR core code) that frame is sent only once from HOST to > switch with tail tag indicating both ports. > > Signed-off-by: Lukasz Majewski > > --- I'm not sure what in your process causes this, but there is an atypical extra new line between the last Signed-off-by: line and ---. Anyway. Reviewed-by: Vladimir Oltean