Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <50798cd4558299eb62e2c3a11e367a6dbe11f915.camel@linux.vnet.ibm.com>
Subject: Re: [RFC v3 1/2] powerpc/cpuidle: cpuidle wakeup latency based on
 IPI and timer events
From:   Aboorva Devarajan <aboorvad@linux.vnet.ibm.com>
Reply-To: 87a5trvw88.fsf@mail.lhotse
To:     Michael Ellerman <mpe@ellerman.id.au>
Cc:     sshegde@linux.vnet.ibm.com, srikar@linux.vnet.ibm.com,
        npiggin@gmail.com, rmclure@linux.ibm.com, arnd@arndb.de,
        joel@jms.id.au, shuah@kernel.org, linux-kselftest@vger.kernel.org,
        linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
        pratik.r.sampat@gmail.com
Date:   Thu, 21 Sep 2023 16:30:19 +0530
In-Reply-To: <87a5trvw88.fsf@mail.lhotse>
References: <20230911053620.87973-1-aboorvad@linux.vnet.ibm.com>
         <20230911053620.87973-2-aboorvad@linux.vnet.ibm.com>
         <87a5trvw88.fsf@mail.lhotse>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 2023-09-13 at 08:54 +1000, Michael Ellerman wrote:
> Aboorva Devarajan <aboorvad@linux.vnet.ibm.com> writes:
> > From: Pratik R. Sampat <psampat@linux.ibm.com>
> > 
> > Introduce a mechanism to fire directed IPIs from a source CPU to a
> > specified target CPU and measure the time incurred on waking up the
> > target CPU in response.
> > 
> > Also, introduce a mechanism to queue a hrtimer on a specified CPU
> > and
> > subsequently measure the time taken to wakeup the CPU.
> > 
> > Define a simple debugfs interface that allows for adjusting the
> > settings to trigger IPI and timer events on a designated CPU, and
> > to
> > observe the resulting cpuidle wakeup latencies.
> > 
> > Reviewed-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> > Signed-off-by: Pratik R. Sampat <psampat@linux.ibm.com>
> > Signed-off-by: Aboorva Devarajan <aboorvad@linux.vnet.ibm.com>
> > ---
> >  arch/powerpc/Kconfig.debug                 |  10 ++
> >  arch/powerpc/kernel/Makefile               |   1 +
> >  arch/powerpc/kernel/test_cpuidle_latency.c | 154
> > +++++++++++++++++++++
>   
> I don't see anything here that's powerpc specific?
> 
> Which makes me wonder 1) could this be done with some existing
> generic
> mechanism?, and 2) if not can this test code be made generic.
> 
> At the very least this should be Cc'ed to the cpuidle lists &
> maintainers given it's a test for cpuidle latency :)
> 
> cheers

Hi Michael,

Thanks a lot for taking a look at this.

Yes, this test-case can be used as a generic benchmark for evaluating
CPU idle latencies across different architectures, as it has thus far
been exclusively tested and used on PowerPC, so we thought it would be
more beneficial to incorporate it into a PowerPC specific self-test
suite. But I will work on making it a generic self-test and send across
a v4.