Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Date:   Thu, 21 Sep 2023 12:07:17 +0200
From:   Borislav Petkov <bp@alien8.de>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     LKML <linux-kernel@vger.kernel.org>, x86@kernel.org,
        "Chang S. Bae" <chang.seok.bae@intel.com>,
        Arjan van de Ven <arjan@linux.intel.com>,
        Nikolay Borisov <nik.borisov@suse.com>
Subject: Re: [patch V3 10/30] x86/microcode/intel: Unify microcode apply()
 functions
Message-ID: <20230921100717.GGZQwV1bIb+jHyXIwX@fat_crate.local>
References: <20230912065249.695681286@linutronix.de>
 <20230912065501.405080839@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20230912065501.405080839@linutronix.de>
Precedence: bulk

On Tue, Sep 12, 2023 at 09:57:59AM +0200, Thomas Gleixner wrote:
> Deduplicate the early and late apply() functions.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
>  arch/x86/kernel/cpu/microcode/intel.c |  105 +++++++++++-----------------------
>  1 file changed, 36 insertions(+), 69 deletions(-)
> 
> --- a/arch/x86/kernel/cpu/microcode/intel.c
> +++ b/arch/x86/kernel/cpu/microcode/intel.c
> @@ -294,12 +294,11 @@ static __init struct microcode_intel *sc
>  	return size ? NULL : patch;
>  }
>  
> -static enum ucode_state apply_microcode_early(struct ucode_cpu_info *uci, bool early)
> +static enum ucode_state apply_microcode(struct ucode_cpu_info *uci, struct microcode_intel *mc,

Err, we have

struct microcode_ops.apply_microcode()

already. Can we disambiguate those pls?

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette