Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Message-ID: <c0e2ec72-1b37-018e-5b5c-2d506b451db4@intel.com>
Date:   Thu, 21 Sep 2023 15:55:35 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Betterbird/102.13.0
Subject: Re: [PATCH 2/7] cxl/region: Fix a checkpatch warning
To:     Jeongtae Park <jtp.park@samsung.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        Jonathan Cameron <jonathan.cameron@huawei.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Fan Ni <fan.ni@samsung.com>, <linux-cxl@vger.kernel.org>
CC:     <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Kyungsan Kim <ks0204.kim@samsung.com>,
        "Wonjae Lee" <wj28.lee@samsung.com>,
        Hojin Nam <hj96.nam@samsung.com>,
        Junhyeok Im <junhyeok.im@samsung.com>,
        Jehoon Park <jehoon.park@samsung.com>,
        "Jeongtae Park" <jeongtae.park@gmail.com>
References: <20230921025110.3717583-1-jtp.park@samsung.com>
 <CGME20230921024831epcas2p36f222c434f41ce80ac2850374868da9a@epcas2p3.samsung.com>
 <20230921025110.3717583-3-jtp.park@samsung.com>
Content-Language: en-US
From:   Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20230921025110.3717583-3-jtp.park@samsung.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VGZlMit2QXBRajZ0SStEVy9lSkVMSFhaaEVOUE9ueVZsQVdwVGl5b0N0ZkVq?=
 =?utf-8?B?L29Wdk1BcHI1b1k4T0V6QWx1bkZ3T1FCeDFCUjg1TGNpR0lwZGJjUDFGSUV1?=
 =?utf-8?B?aEhQaEQ1dFEySTY2eGdhTjVjSmNWUm1iMVo1UXFadVJ1d1g2eGEwSkdCMDRo?=
 =?utf-8?B?d2hKcW02R3VjNTlpWFBWcmVsNkFuQXY2SjZBMW1MRmpTSzBqQ2NGNHNXeHBr?=
 =?utf-8?B?WUwyeFNNN3J6aEtKQmJrT0VmT1lzUC9va3Awb0V3MXZJZGVXZm9VUjRIUEVi?=
 =?utf-8?B?QldqUGUrSHNMckZQZjBWTDlKTVlPdGM2MnFsSFhlQ0ptRW9Ob0JUa1Fmc1FO?=
 =?utf-8?B?NHJHZ2ZpYnFGNXY4OXBSQkNxeWhtUTVoT0YxY0pvTXlQYVJuNGI5TlV1S29F?=
 =?utf-8?B?VWNwVThyR3l4RzRUWEZXd0RXZEFkci9oYWNyN1FxeTNDazNaa25XL1RCaVJO?=
 =?utf-8?B?NUlmYWt3Vlh2UVlpOG4wNEVJdmdtejlFVFhia1J6Q1hhU01GZExzZ3BKRlNh?=
 =?utf-8?B?cklzQmdTQzVqWTFuY3Z5SktaanhSeWNqbE5kNHoyQWJVV2h5VDEzSjFKYzFU?=
 =?utf-8?B?VW1tVll4cUpUV1FhNVRpOWJMNHp4VWZ5Nml1RnFIK0VmVVhQTGdWU1VEWXgv?=
 =?utf-8?B?QzhBRTZCeWxVWmRtYVJST1czNis2S1Z0RUZZd3Q0YXE5dU1lYUI4TTlRUGxB?=
 =?utf-8?B?c3Jpa09VUkh5TU00alR2a3FyWnFqZ1pWNXhIWFFzWmkrL0pQWk1hZ0RJOG1t?=
 =?utf-8?B?cmZxRWpaUTQyNldWRndhdm4zS2EzRHVEdUhJdTkxZG9sYlhSV01NYS9pK1dJ?=
 =?utf-8?B?Q2toM3lhd3FOUXN3UzNNZm43MXZzYVBvR2N1a0JkM3Zjb0NyaXNwdi9pZTla?=
 =?utf-8?B?eldJZmY1UDgzMmhVODZnYk5CK0lLbW93NElQK1Q0UjNZSTE3cmRWTnNzanc5?=
 =?utf-8?B?d2dpTFpDdk9NL3NqT1pwWUhVOXdLb3dQMnoxWGtZK29aOUdJYjJwWmNvVlgw?=
 =?utf-8?B?TzBNTWYyZzVydGdiU2xiSzFIKzZKWmNUeGRTQW55L0EvNW5FNHFldVRreUx4?=
 =?utf-8?B?QVNaUmxzTUxTMTJWbVhtbDIzYzJKUFM5YjZmV2YzSHRlRDJtN0JrYzZ2cDBh?=
 =?utf-8?B?cmRLTVp0d3RlS0ZOVWp5Nk9Ubzk4WFp6SUV0NStaQjY2VGVsOTNGV05ucXFF?=
 =?utf-8?B?V2RHMXl4QzJmQjlxdGxpd2t6Ky9uWlpDODRxbEtFTk5zQ0J6cVQ1RlRGN0tO?=
 =?utf-8?B?aVg5TkcxZTVsNGRRWVdzaCtNVXE5WXB1ZWUvOHdGR2lhanlHd2x5WmpPUjVr?=
 =?utf-8?B?YzlyYlV0SFAwV1RyUFJjRnFzOUp2Mnh2dkdUM2xBTzA5ZW1QZG4zelpaZnZH?=
 =?utf-8?B?ZFNLSXJEMHpJWE1PajRYUkRCNkZZZzBGaEd4dVlWSWErdDh5WEh3Q0lBY0E4?=
 =?utf-8?B?dzk0RmxyU2Vkc3hKRDc1dTdGcTBPV1lHQlpncVorSVAwbHlJcklKUzJXRUEy?=
 =?utf-8?B?dVlJTlNvdHMvZ3NZYmtFRFE3TzhObUJGSkdXaEcxalFyeldRd3FOS0hLSVRF?=
 =?utf-8?B?dmhQSks2bWdmZjFpM1BzTGRML1lWZGNlcVBnM3EzNTRJajR6aVptdVFyaHRD?=
 =?utf-8?B?SVhuL0tJMXc1NWJ0dU9TVjk0cHo2OUNFMm4rSG90ZlNhRDI1U29WcDYyYWh5?=
 =?utf-8?B?MllIWUR1UHZXc0I1YXlkeGwyRmcxQUdtWmhlYkRDTThvU1VjcjBBTkE3SVU1?=
 =?utf-8?B?VDZpMldScUVaTTh6anlaNS9NZVlIK0xzWEZNdmxOQnBNcDBqd3NSc1MxZE1z?=
 =?utf-8?B?K3Z2RGd0RENqakpieklOMUthcGJHREdDZjQ3SE5MaDJrcEoxWm8ya21UZW9q?=
 =?utf-8?B?NGJxdjBVS3ZzSk9rQWp1dGliMEtMOGp4S3diT0dqL1VSTGZnU25MZnc0QjVH?=
 =?utf-8?B?eXppOStOSFpSdWdmemw3OVBVRDFEQWZtWFp4aDFkY1NtVzVJdUtWZUlvRW1l?=
 =?utf-8?B?aFdJeUVYekU1dG1sdDRSWld3Q3RBa1JURjhlODRTMHl0eE1rYnhMOXZzRGh2?=
 =?utf-8?B?YXoxRDFwUG9FSW44T0xIdHFrYTF0NlhiQzg0N0xpY0RWaS9Kam9qYm1IcjUr?=
 =?utf-8?Q?Q7go4IZgRl+kDfhGUleJFM6Q3?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b610a55a-05ac-4bf9-e15c-08dbbaf5dff0
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5984.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2023 22:55:39.0985
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GL3OeKdPgGUSmUuCPoMPOZhYCJ7skpzQyOt2yw6CluLjxlfJ/cHpzS47S+6n+/bgBQgzfZpCi+pVN9tLe2QM8Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8325
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 21 Sep 2023 15:56:47 -0700 (PDT)


On 9/20/23 19:51, Jeongtae Park wrote:
> WARNING: else is not generally useful after a break or return
> 
> Signed-off-by: Jeongtae Park <jtp.park@samsung.com>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
>  drivers/cxl/core/region.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c
> index e115ba382e04..1fc9d01c1ac0 100644
> --- a/drivers/cxl/core/region.c
> +++ b/drivers/cxl/core/region.c
> @@ -133,11 +133,10 @@ static int cxl_region_invalidate_memregion(struct cxl_region *cxlr)
>  				&cxlr->dev,
>  				"Bypassing cpu_cache_invalidate_memregion() for testing!\n");
>  			return 0;
> -		} else {
> -			dev_err(&cxlr->dev,
> -				"Failed to synchronize CPU cache state\n");
> -			return -ENXIO;
>  		}
> +
> +		dev_err(&cxlr->dev, "Failed to synchronize CPU cache state\n");
> +		return -ENXIO;
>  	}
>  
>  	cpu_cache_invalidate_memregion(IORES_DESC_CXL);