Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp2463157rdb; Thu, 21 Sep 2023 21:55:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFASiEnZHA0/IoXDi/wgw5c5o9w9fBHStWOWotSLC7ZnLhH9PYAcLVj1beg1P0Ef/spz3Vf X-Received: by 2002:a05:6a00:3925:b0:68f:c7c5:a73a with SMTP id fh37-20020a056a00392500b0068fc7c5a73amr7490004pfb.16.1695358529015; Thu, 21 Sep 2023 21:55:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695358529; cv=none; d=google.com; s=arc-20160816; b=tYf4ecn9HD2CWLZQ/gu2F/VOqtbIhg8zhmrzi0WiH/Xae4bflZYnhmN90/A/uw7Z0S oDuK75iT3hp2xk8T02si82qaNXDri8MMKHVEyZ5DaiEIetAYGc9St3D3lmUZQtP/PsSb e99K3ujo10Y0/KdAl5x8wPVyBd6KsInaSFzB4uShprD75k6x6/OqQJmGA7ey/Y7Y+BIq DiEBEyIHwtHz8ahK7len+HI85aI6ovGSejwOywFlaJPrCN7mBd5/tbfpNvVGz25kUoAJ SzvKP6ORcLtuY9Z2626na89xTxiX9qFyS8vKOJU08Nh1Thm8tqPJGV3Q9t6eii9cgHwv A6Ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=PZoJibFgab/vN9GIaKJ3/1GHrki3dxSUD2jY1bTI4vI=; fh=n4hnQVgvk9EP0w7xyhODLlVi1fPlHJGGEmSERn9fuNs=; b=QazWp13EJJNeG/p3lhAVMBf4RcjhecfzqnvdvVTMPO1J+NxWoZTQ69zmgrGXUl0sv6 jBB4WEBdSOpTpMTokDRAxjOAJjciGpFUX3qle/iHwq3sikFcR427vmpOdJ99ziq1zvPn V46CosQWGex6N9yYyU9O5lsKR4gt+Uk9gtfjZBBHfz0VymkpkPXSXV8d2+SVTOegNbv9 EGmhUkdhHQK99WIZ5w+4rYfPgQ9RBd4yDxEgi8u4wWUThphoCc3HdSw/Mu73lbkEY3Rm ndTMehrsMFBOg3EazRsaabq2vwlC5M69NwvWUemvHtNHMs028pGWrbN2LU+SJxsAupw5 l1HQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=eRFcMdCA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id by13-20020a056a00400d00b0068e3e4f5b90si3023968pfb.10.2023.09.21.21.55.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Sep 2023 21:55:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=eRFcMdCA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 9AA94837CF19; Thu, 21 Sep 2023 15:16:07 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232357AbjIUWQD (ORCPT + 99 others); Thu, 21 Sep 2023 18:16:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232711AbjIUWPa (ORCPT ); Thu, 21 Sep 2023 18:15:30 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC635AF97E; Thu, 21 Sep 2023 11:07:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=PZoJibFgab/vN9GIaKJ3/1GHrki3dxSUD2jY1bTI4vI=; b=eRFcMdCA9qvR+q+a9CgGajuBM1 95+mHIxZFcop86v4Bg58gAHW33MUSAy/zRn/p0eTplitvq5yj70/F/Pbsg8ygMu8au1nuM6c4PWvO 2BPmXQe/3KXMYrV0CkO924pf+xQkdU4T1T6CfMnA/ZH6x4qEKhQrU+MX5omAYqLc2OyQ=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qjMFe-0076Ut-Gt; Thu, 21 Sep 2023 18:10:02 +0200 Date: Thu, 21 Sep 2023 18:10:02 +0200 From: Andrew Lunn To: MD Danish Anwar Cc: Vignesh Raghavendra , Nishanth Menon , afd@ti.com, Conor Dooley , Krzysztof Kozlowski , Rob Herring , Tero Kristo , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srk@ti.com, r-gunasekaran@ti.com Subject: Re: [PATCH v2 2/4] arm64: dts: ti: k3-am654-base-board: add ICSSG2 Ethernet support Message-ID: References: <20230921060913.721336-1-danishanwar@ti.com> <20230921060913.721336-3-danishanwar@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230921060913.721336-3-danishanwar@ti.com> X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 21 Sep 2023 15:16:07 -0700 (PDT) > + /* Dual Ethernet application node on PRU-ICSSG2 */ How relevant is "Dual Ethernet" here? You are talking of adding switchdev support, and runtime swapping the application. All these properties should be valid for the switch application as well? In fact, you are describing hardware here, so the application should not actually matter. So maybe this comment should be: Ethernet node on PRU-ICSSG2 Andrew