Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Thu, 21 Sep 2023 09:52:36 -0700
From:   Andi Kleen <ak@linux.intel.com>
To:     Ingo Molnar <mingo@kernel.org>
Cc:     Yi Sun <yi.sun@intel.com>, dave.hansen@intel.com,
        linux-kernel@vger.kernel.org, x86@kernel.org,
        sohil.mehta@intel.com, ilpo.jarvinen@linux.intel.com,
        heng.su@intel.com, tony.luck@intel.com, yi.sun@linux.intel.com,
        yu.c.chen@intel.com
Subject: Re: [PATCH v7 1/3] x86/fpu: Measure the Latency of XSAVE and XRSTOR
Message-ID: <ZQx01AfyvbJQYPsi@tassilo>
References: <20230921062900.864679-1-yi.sun@intel.com>
 <20230921062900.864679-2-yi.sun@intel.com>
 <ZQvqvpSbyub6gFZX@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZQvqvpSbyub6gFZX@gmail.com>
Precedence: bulk

> It seems unnecessarily complex: why does it have to measure latency 
> directly? Tracepoints *by default* come with event timestamps. A latency 
> measurement tool should be able to subtract two timestamps to extract the 
> latency between two tracepoints...
> 
> In fact, function tracing is enabled on all major Linux distros:
> 
>   kepler:~/tip> grep FUNCTION_TRACER /boot/config-6.2.0-33-generic 
>   CONFIG_HAVE_FUNCTION_TRACER=y
>   CONFIG_FUNCTION_TRACER=y
> 
> Why not just enable function tracing for the affected FPU context switching 
> functions?

Or use PT address filters to get it even accurately, as described
in [1]. In any case I agree the trace points are not needed.

-Andi

[1] https://lore.kernel.org/lkml/ZPOIVmC6aY9GBtdJ@tassilo/