Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
From:   Ying Liu <victor.liu@nxp.com>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        "andrzej.hajda@intel.com" <andrzej.hajda@intel.com>
CC:     "neil.armstrong@linaro.org" <neil.armstrong@linaro.org>,
        "rfoss@kernel.org" <rfoss@kernel.org>,
        "Laurent.pinchart@ideasonboard.com" 
        <Laurent.pinchart@ideasonboard.com>,
        "jonas@kwiboo.se" <jonas@kwiboo.se>,
        "jernej.skrabec@gmail.com" <jernej.skrabec@gmail.com>,
        "airlied@gmail.com" <airlied@gmail.com>,
        "daniel@ffwll.ch" <daniel@ffwll.ch>,
        "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel@collabora.com" <kernel@collabora.com>,
        "ehristev@collabora.com" <ehristev@collabora.com>,
        "wenst@chromium.org" <wenst@chromium.org>
Subject: RE: [PATCH v2] drm/bridge: panel: Fix device link for
 DRM_BRIDGE_ATTACH_NO_CONNECTOR
Thread-Topic: [PATCH v2] drm/bridge: panel: Fix device link for
 DRM_BRIDGE_ATTACH_NO_CONNECTOR
Thread-Index: AQHZ65xVPwJWT9OuK0+bOARGRXgXgrAjchKA
Date:   Wed, 20 Sep 2023 09:30:02 +0000
Message-ID: <DB8PR04MB70513CD4C2C41B1E6865A5DC98F9A@DB8PR04MB7051.eurprd04.prod.outlook.com>
References: <20230920082727.57729-1-angelogioacchino.delregno@collabora.com>
In-Reply-To: <20230920082727.57729-1-angelogioacchino.delregno@collabora.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GSYjOiRYnbjnMr9OfPlt7LxdYoV9eVFWHYWCz8xPnUncLnC9b4/ItPUjyHvU?=
 =?us-ascii?Q?myiArBmQeVNeGk/jkDzpcAgrVGVa9uFaAgTjColvnUb0y92Dyea/LJOAk7Qr?=
 =?us-ascii?Q?Bi5N14niOjPl1MySVmh8HBQnuTguxhAYcymcZMyz6GXBfYSZSZNzqzsT262L?=
 =?us-ascii?Q?+jxa9V4ipC3O1oe9kXvpj7Eya29WaAnDvL/2dZKyDWv6TjoI/137dwVU2DG8?=
 =?us-ascii?Q?POz8xEhWtIQfffYkLBpicdjWpky27HBTSP+5g31oEYEUArx+niNN88Q1lCwp?=
 =?us-ascii?Q?JTsPbzT0dvixeJBfvpmaxpyD6OUbXYch7keyHp/pL7rb5C9zMBODn1sQtmWh?=
 =?us-ascii?Q?1rDX7H5K4MoqkOW3TwbRYIfQpjr7x67sNQmLIVzEId9QHnaDqiwr3LWaQs+A?=
 =?us-ascii?Q?89MKnUZD4FA9dYkbNxiD43ECpzc6Rib+fN01kFLIyi++4/6/QHava4V84+o1?=
 =?us-ascii?Q?eb/X4Pd5URGFsYMNiWjLGppAUgWnfkidcbvuTaqUqr0NkbnZAUujiJNr7Peo?=
 =?us-ascii?Q?/AIf61URR243UsnRUrI+iV1Yg4En8IAjX3jynzmCkleeXZl7OcLVw5AzeYSn?=
 =?us-ascii?Q?b8YjlzB/OWhFwXIQDcywgIpWc/j40ANI13nnZ5tfmELPc8fEr34IlgEGCWry?=
 =?us-ascii?Q?BoVlIOleKpuuQe8Lk+C72aGxHaYeY/no5dAeWwh6ilRcRgzKJK/+L8vacuOb?=
 =?us-ascii?Q?02J0RwTrWbSrzCsAXTlqJ3lea04jAP3+AnxoaBV/kdTqQaNKdSzrnsrpI7UL?=
 =?us-ascii?Q?8i1PCwy4Ownh8Igeo9QU6ZIiWm9T/I1n68MvjsmLGKGieBfOaFdo7c3+gIxS?=
 =?us-ascii?Q?68K82tO5KNUxYkkLkWUbNpU46ZmRc4Dc+Q8FTBBxZB9rlyX3p+LpL/Cvsrmd?=
 =?us-ascii?Q?nSOG/6Sa3e+Rz3QnAsKh2k7ryG+cWUEka4VlFBL7D+nG1coup1wxbxh3uw+k?=
 =?us-ascii?Q?08WTuklSrD+xdqLMgr1QKfQeGr+pGJmmI5TlKSvGzrc/8USN+0oIECqt8XaX?=
 =?us-ascii?Q?XhlpuX7GpVp5EbuOUxVupmd6NadRbCO/uHO+SvXqJgNqr+bEG16c0ihcLjQo?=
 =?us-ascii?Q?WGt6+i82meKyqoT11FjaD23DEozgsE4/LO70SgXZDOMPNESg2KL5f5E6kUpX?=
 =?us-ascii?Q?l8Tl4YNnPxLUlv8Uf41RL3DE0gL2RoFTPDOD020zvK1stvn43AhEve5spCju?=
 =?us-ascii?Q?NpPB+JRhxEMi9cZiFub8IaVRlp/ObhzJqQs8klIQwkdx7pXXuC+4WyyVYqf7?=
 =?us-ascii?Q?3j/nYgbV6R4/7YGZx2ZojJfgGGliEJZZfKKjlPa4HsHqeId72PZKO8fC/xfr?=
 =?us-ascii?Q?qSaS8KnOb6h9/ecKm7G1likd5Iz1qEALH6Sa4F3HPq0qjOdn9HInxwQOVqf3?=
 =?us-ascii?Q?+gLJe/gXRHiBR8i6nh22Y1W+khfGB/6gOwi/9M/lJaxV81w2rqC9lz09KUD9?=
 =?us-ascii?Q?COeOXdyNtU524kpce22YA86vZ2CD+yg0CmT0bpzEL76zxcnRNUiaH011ksLJ?=
 =?us-ascii?Q?rqPYIcb13E9CDPNWajMFiIsgFtWRi8pFxui0fMa1kmYys072kz1lmwEGKjPA?=
 =?us-ascii?Q?3rLxZlRfV1grUSad2ro=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB8PR04MB7051.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 14e605f5-46ca-4f9c-c0d2-08dbb9bc2ab7
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Sep 2023 09:30:02.4482
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: RX1SalJxFFSNfdaoEndx9FqF3aSF5LCq6QnT//Xsu2SHyvj5/+a+1dKE47Vz2wX9ezRkDuCh3U50ZgNtkDjA8A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8447
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 20 Sep 2023 02:30:17 -0700 (PDT)

On Wednesday, September 20, 2023 4:27 PM AngeloGioacchino Del Regno <angelo=
gioacchino.delregno@collabora.com> wrote:
> When external bridges are attached with
> DRM_BRIDGE_ATTACH_NO_CONNECTOR,
> the panel bridge may also get the same flag, but in the .attach()
> callback for the panel bridge a device link is added only when this
> flag is not present; To make things worse, the .detach() callback
> tries to delete the device link unconditionally and without checking
> if it was created in the first place, crashing the kernel with a NULL
> pointer kernel panic upon calling panel_bridge_detach().
>=20
> Fix that by moving the device_link_add() call before checking if the
> DRM_BRIDGE_ATTACH_NO_CONNECTOR flag is present.
>=20
> Fixes: 199cf07ebd2b ("drm/bridge: panel: Add a device link between drm
> device and panel device")
> Signed-off-by: AngeloGioacchino Del Regno
> <angelogioacchino.delregno@collabora.com>
> ---
>=20
> Changes in v2:
>  - Added device_link_del() for (!bridge->encoder) error condition
>=20
>  drivers/gpu/drm/bridge/panel.c | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)

Reviewed-by: Liu Ying <victor.liu@nxp.com>