Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <252878a3-bcea-5810-dd94-951c266b8549@intel.com>
Date:   Fri, 22 Sep 2023 10:09:13 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v4 2/6] iommu/vt-d: Remove mm->pasid in
 intel_sva_bind_mm()
Content-Language: en-US
To:     Jason Gunthorpe <jgg@ziepe.ca>
CC:     Kevin Tian <kevin.tian@intel.com>,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Michael Shavit <mshavit@google.com>,
        Vasant Hegde <vasant.hegde@amd.com>, <iommu@lists.linux.dev>,
        <linux-kernel@vger.kernel.org>
References: <20230912125936.722348-1-tina.zhang@intel.com>
 <20230912125936.722348-3-tina.zhang@intel.com>
 <20230921185648.GY13795@ziepe.ca>
From:   Tina Zhang <tina.zhang@intel.com>
In-Reply-To: <20230921185648.GY13795@ziepe.ca>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SEpiQ0swdjlRVmE4RTJVYVp4cUpFMlRReGtrb202eVJZbmtzc3VudkpLOEZz?=
 =?utf-8?B?VjJ5TDZSdC83YUg2dnlOTTc2K1MyMDdyazdGTWMvNE9hVTVzOU02QkIvbklp?=
 =?utf-8?B?Um9xOVlFamxkeUNLZ21xd2Z5ZEJ2Z05yR2tmTE90N00vL1lWRHZYenpvM2lG?=
 =?utf-8?B?U2FKMU5wVnhUYzhnNFF4VTh5eTJ2dW5CWDd1MUNWbmozdTBQVmtjTitiWlZa?=
 =?utf-8?B?ZnBUekV1dGo3clhNRzNwMS9HRVBraUFpNzd5Q3BrSmhIcGtSUjlmWVNFanVS?=
 =?utf-8?B?YnZuRlBQTlVDaG1iVFJhSy8yVGdNVTFyYXFjUDFpbE1hSmhZVG1tZUk1eVps?=
 =?utf-8?B?cWtTRVlvWWU4cXNoOUVVZXJEaElsaXZ1S1RWM1NNTEl3VmQ1RXhOUzFqS2t1?=
 =?utf-8?B?cVlUNzBDbUJFVVhXRWU0bUxhTGczSHVad25LUk1hcmFZOGZGM0NJNHZvZ2hD?=
 =?utf-8?B?UEFYVWFaNGpqZ1oxVGVmbnlXQnJzSm44eWQ3eVhhOG1yQUZmSTRqaHB6VXpz?=
 =?utf-8?B?cjBVUENGZ2tvNFdyTENwUXlBbWxKTEpFbU93NGt2U1prUHNqb2NLWkZQSGhD?=
 =?utf-8?B?c2s5dmRsR2FyajJmZUk4N3JDMytRWHJmUUljWHJtWkNKQzVCSnNqb2lvOXN0?=
 =?utf-8?B?WmZTTkRsTEJSRi8xdGw1ZDNUUHp1R2w2YXp2VENZWE81bW45SmVzLzJTNlVB?=
 =?utf-8?B?Ukg0QTIwaHZ2cE1VdzdqY24reTlaY1FyczVmMjZlcWJFOGxKTDlMcUd6YUlQ?=
 =?utf-8?B?NmhkLzU4QmY3UE9ka2tMRXJRUnNBTE12K0JWK2RmVjc4ZFlpby9QL1FhVU5W?=
 =?utf-8?B?WjRIQ1Y0Z1M2NVFWZjF0cEo5VjhNMStscUtpS1Zrek83QUhOWHNtSWkzNm56?=
 =?utf-8?B?ellDMG80a2dybWJHV2tIdjRHek5jWFQ2UXVOTnkwL2ZQK2h6Ylo4bjhMajlm?=
 =?utf-8?B?aFNyd0VNSi9Lc3RjRytxYW1JbzZ3MVdtRWorYVVmclRGbHhhYS9wSGFDamhY?=
 =?utf-8?B?WXhGc3lvK013SC9hbjNRR3VBa1lzcWRkbTNFcmNPUm5TZlRvWWdxaGpPSFdk?=
 =?utf-8?B?SWFmNjZkNkFNTXpVWEVvN05WcC8rT21EOEVZUmRwZ1RyaVI5VjdVbWJWc25m?=
 =?utf-8?B?Z3JiM2JuSkVsbC9YRitxUU5QeElhRzl2MUFFd0J6TnUzL1kwU3VWR1Zvdkgr?=
 =?utf-8?B?NWdJd3ZDejRRV0xSdmtHQXFlVG9Vd0E0MjRiZktMc1RwZ1VPbHZPVXhHRm9t?=
 =?utf-8?B?dHpTcHdwM3VycFZmM2tTK2tBcmVSUFNqQVdWVU9FcHM1cmFCOUE2dnFSU3Vi?=
 =?utf-8?B?SWk5bmIzelFkLzVkQk40OEhBUHFrOGF6NnBUbHhiSmZBdkRFQWVSQ3pEcy9X?=
 =?utf-8?B?VVd1STFhUTNFYSs5T29FNjVmYzlLMWlUR3A5N2ErSkw5Mk5qV3M0VU43WFdK?=
 =?utf-8?B?TVFvc21ZYUNzUVlSMEN3dFJCSC85eUJVOVp4UDhqOFRNMDRwYzRzMVFEMnd5?=
 =?utf-8?B?cm1IQXlzejJ3RjE1VWxvb0k4cDRaZmp0SDExNmhoemJrNllhWElpZ2xvbDRu?=
 =?utf-8?B?R2psZFpuVUZ0S3UzOUw0bSszRzNQNjZOanFvZnBHWmNBSy9wQXArOUhpZW0z?=
 =?utf-8?B?T1hZRXVOeHRpUmRrRGdneVhiRThoc3NxZi9wU1JvR3ZYK1FEOW5TWHlQS0dp?=
 =?utf-8?B?RW55UG5TS0hyWDdoNUxuWmlTTldSamhTcUJicnRNL0U0WmhKeEdOb3g4WTF2?=
 =?utf-8?B?Vlk1UDFoNkxWeC9NVHNxUmhxMGlqMkl2WUwvbExvNTl1UW1lL1dEWE4vbDl0?=
 =?utf-8?B?RUZwTkVBMzdSOXJESklnaGoxMXhHeUEyVkJsZFBRSVR0U2MzWllTMVk1WFlt?=
 =?utf-8?B?SXIwSEdkUzVJRGlXdjZMU1M3eGRoL21Rc25DLzBjaDRORSt1bkZ1TEk3QjJP?=
 =?utf-8?B?M3dIc29kRzBoRFRQQm9sTStENytjTlBta2l6YVNHeVVLeGNRQjZxcUd0NGRv?=
 =?utf-8?B?V0JkaW91Vk1vMVVoRGYvbUJxNHU1UmREMk9CM3lybmpRWC9XdkJYWjNPbXpQ?=
 =?utf-8?B?em1PVThFcm90R2dKcERCd0tOdW83ekFpY05OZXdkTG5LeVpZQW54dFRrc1FZ?=
 =?utf-8?Q?fcW9AUjiXZF/lJCbeccw16FEb?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 600151eb-2f7d-4477-e1c9-08dbbb10efa4
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5881.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2023 02:09:21.9957
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FMNrX3F5ZI5WUQwv47xNrOKyvTH0++o+Aaia3Mo/GXVUIW2neTPSxcM3WR/9kquQZyllMI//vqXVv6kaGB8dgQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5265
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 21 Sep 2023 19:09:39 -0700 (PDT)


On 9/22/23 02:56, Jason Gunthorpe wrote:
> On Tue, Sep 12, 2023 at 08:59:32PM +0800, Tina Zhang wrote:
>> The pasid is passed in as a parameter through .set_dev_pasid() callback.
>> Thus, intel_sva_bind_mm() can directly use it instead of retrieving the
>> pasid value from mm->pasid.
>>
>> Suggested-by: Lu Baolu <baolu.lu@linux.intel.com>
>> Signed-off-by: Tina Zhang <tina.zhang@intel.com>
>> ---
>>   drivers/iommu/intel/svm.c | 14 +++++++-------
>>   1 file changed, 7 insertions(+), 7 deletions(-)
> 
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> 
> I would order this patch first in the series
OK.

Thanks,
-Tina
> 
> Jason