Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp2484256rdb; Thu, 21 Sep 2023 22:57:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHmx/p8j/Vi2REeQuL1l0IPtmYhLmFQ38WXd4Pp4S0zgoo2acQ5XCemmivpuy8bFJNTTWMW X-Received: by 2002:a05:6358:cd12:b0:143:6b2a:e906 with SMTP id gv18-20020a056358cd1200b001436b2ae906mr5951106rwb.26.1695362252560; Thu, 21 Sep 2023 22:57:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695362252; cv=none; d=google.com; s=arc-20160816; b=YwH6yIm5q3ZbbLnX3LhsrBqxQcVDkbORIUCYgk8AsGLqjfiuTxBSH9qcOOX8IVIcWk WHGqUMN6E8YM+A8wRmX9ejXtpeKgjUpdhz5+yW73lXDzuJlLKFKCgwuE3v6FEedy9ZKg 8FpcqFQZc11kVWRExrFZKie1kbWvbSzug3VDwFdcXS27NBO3Zauhiif5iU+kMHRsZ3qx n65tDVW8qwRvhAGcM/Mp/lL90UrNA2rwtvw1soz2ORyVaWwp+XTkNOy8gyAAD8fvkfsl W0KUTQGsQ0RGhj3RexwCLU5N3xKUNFgdDL0mqK3TWedT5dep9EqpgdJSoKmz0yiNineG x6dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=a52iiY+tyseLz6Yk6g/8D19m0gkFwe6R0iruncQiVIo=; fh=9EQxLfPG7gR1CZhhZSdlFk6nO8gPOgaupKXKXgXvi3Y=; b=pbuVSGrQtOfIVY4G5f0kzKCRd6YXJ3gqQ7Yw2vbjf210BJoSl41RQH/2T8f/MxjxxE V4w5Mp+0JAEOfqYxqoBz+8joeJQyYcjMB6OYVKNwKQwy7FqHJ6rIuHpKLKM2vtVuleXQ SSH4Oi4gSbOLMqDGHSxTrnrEyGbgsVqlztt497Zw2+YZBvToDjgnsCOuhDNrhMQ+dtT0 UcdIkCU0i1k09etkR25DaxJcett9ew4c1I6Ha83zAXpnHGOpod/CWmZBQxhPQMHUSBYo PZDB3X7C8hNmZlak8o+D/dfG7d8/M1Wzr7D9J5O0EDTBT3LzW4Mf6oU8GaP/Lx2TGPqt CQfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=DJh7vO8o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id k6-20020a6568c6000000b0055fd1bfacafsi3097347pgt.755.2023.09.21.22.57.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Sep 2023 22:57:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=DJh7vO8o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id D70D882C92F5; Thu, 21 Sep 2023 12:50:04 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230011AbjIUTuC (ORCPT + 99 others); Thu, 21 Sep 2023 15:50:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230269AbjIUTtf (ORCPT ); Thu, 21 Sep 2023 15:49:35 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C987D7D735 for ; Thu, 21 Sep 2023 10:50:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695318645; x=1726854645; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Dk15iRd1aecBASo2ilC0TfiCW6JmsYJjN8LYbsqz3K0=; b=DJh7vO8oKsUIn9HtwgaMgUJ8BKZ3sZsOdETah2XbI/HzInkT4tRLErEF OUqaWcaN8HvDMQQLqlmXdqriaW5Jps/B2jnHVJxvBm1M6lFvoj1MCTsdQ 1MzwdIgWyJbiTpjEKmKoTPHT8ABOZK9HekETCeMjuiaHk9iB7e1eUuGev s5gOP8Kb/AkCuvEI8wel4oMda0SAQa+flvq6aGAT7jG1VJ21zl7kRflY1 SZml21kVt8PBeeGcSyfvcXjG7Ubq9N0xygJXxfZS0iFPHxjVRBcOiGO9Y T8ElZ9bSwr+2R7wZ+HfMEy2JzGkxxdbXhICdvKStctStJ2vgGKtfoBI/m w==; X-IronPort-AV: E=McAfee;i="6600,9927,10839"; a="384313889" X-IronPort-AV: E=Sophos;i="6.03,165,1694761200"; d="scan'208";a="384313889" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2023 02:36:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10839"; a="812571405" X-IronPort-AV: E=Sophos;i="6.03,165,1694761200"; d="scan'208";a="812571405" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga008.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2023 02:36:47 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC0) (envelope-from ) id 1qjG73-0000000Gqt1-1S5R; Thu, 21 Sep 2023 12:36:45 +0300 Date: Thu, 21 Sep 2023 12:36:44 +0300 From: Andy Shevchenko To: Luis Chamberlain Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/6] params: Use sysfs_emit() to instead of scnprintf() Message-ID: References: <20230912150551.401537-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 21 Sep 2023 12:50:05 -0700 (PDT) On Wed, Sep 20, 2023 at 05:32:55PM -0700, Luis Chamberlain wrote: > On Mon, Sep 18, 2023 at 07:57:41PM +0300, Andy Shevchenko wrote: > > On Tue, Sep 12, 2023 at 06:05:46PM +0300, Andy Shevchenko wrote: > > > Follow the advice of the Documentation/filesystems/sysfs.rst and show() > > > should only use sysfs_emit() or sysfs_emit_at() when formatting the > > > value to be returned to user space. > > > > Any comments? > > What tree were you taretting, looks sane to me. I see that you was a person with last SoB in late patches in that area. Whatever it went through in your case. P.S. TBH I thought you have your own tree for things like this... -- With Best Regards, Andy Shevchenko