Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <d1d836c6-4597-4870-8c7f-ebede83c2392@infradead.org>
Date:   Thu, 21 Sep 2023 15:04:13 -0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] clk: imx: Select MXC_CLK for CLK_IMX8QXP
To:     Abel Vesa <abel.vesa@linaro.org>, Abel Vesa <abelvesa@kernel.org>,
        Peng Fan <peng.fan@nxp.com>,
        Mike Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>
Cc:     Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Aisheng Dong <aisheng.dong@nxp.com>, linux-clk@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <20230921093647.3901752-1-abel.vesa@linaro.org>
Content-Language: en-US
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20230921093647.3901752-1-abel.vesa@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 9/21/23 02:36, Abel Vesa wrote:
> If the i.MX8QXP clock provider is built-in but the MXC_CLK is
> built as module, build fails:
> 
> aarch64-linux-ld: drivers/clk/imx/clk-imx8-acm.o: in function `imx8_acm_clk_probe':
> clk-imx8-acm.c:(.text+0x3d0): undefined reference to `imx_check_clk_hws'
> 
> Fix that by selecting MXC_CLK in case of CLK_IMX8QXP.
> 
> Fixes: c2cccb6d0b33 ("clk: imx: add imx8qxp clk driver")
> Closes: https://lore.kernel.org/all/8b77219e-b59e-40f1-96f1-980a0b2debcf@infradead.org/
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>

Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  drivers/clk/imx/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig
> index f6b82e0b9703..db3bca5f4ec9 100644
> --- a/drivers/clk/imx/Kconfig
> +++ b/drivers/clk/imx/Kconfig
> @@ -96,6 +96,7 @@ config CLK_IMX8QXP
>  	depends on (ARCH_MXC && ARM64) || COMPILE_TEST
>  	depends on IMX_SCU && HAVE_ARM_SMCCC
>  	select MXC_CLK_SCU
> +	select MXC_CLK
>  	help
>  	  Build the driver for IMX8QXP SCU based clocks.
>  

-- 
~Randy